Skip to content

Conversation

@HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Aug 18, 2020

Proposed changes

In the process of historical data transformation of materialized views, it may occur that the transformation fails due to data quality.
Add an error status code :OLAP_ERR_DATE_QUALITY_ERR to determine if a data problem is causing the failure

#3344

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

OLAP_ERR_PREVIOUS_SCHEMA_CHANGE_NOT_FINISHED = -1603,
OLAP_ERR_SCHEMA_CHANGE_INFO_INVALID = -1604,
OLAP_ERR_QUERY_SPLIT_KEY_ERR = -1605,
OLAP_ERR_DATE_QUALITY_ERR = -1606,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe DATA ?

if (mutable_block == nullptr) {
LOG(FATAL) << "mutable block is uninitialized.";
return false;
return OLAP_ERR_NOT_INITED;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add docs to explain what these error codes mean.

Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added the area/materialized-view Issues or PRs related to materialized view label Aug 27, 2020
@EmmyMiao87 EmmyMiao87 merged commit ad738fa into apache:master Aug 27, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Gabriel39 pushed a commit to Gabriel39/incubator-doris that referenced this pull request Sep 25, 2025
…pache#4388)

## Proposed changes
Support to use view when create async materialized view

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/materialized-view Issues or PRs related to materialized view

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants