-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add OLAP_ERR_DATE_QUALITY_ERR error status to display schema change failure #4388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be/src/olap/olap_define.h
Outdated
| OLAP_ERR_PREVIOUS_SCHEMA_CHANGE_NOT_FINISHED = -1603, | ||
| OLAP_ERR_SCHEMA_CHANGE_INFO_INVALID = -1604, | ||
| OLAP_ERR_QUERY_SPLIT_KEY_ERR = -1605, | ||
| OLAP_ERR_DATE_QUALITY_ERR = -1606, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe DATA ?
| if (mutable_block == nullptr) { | ||
| LOG(FATAL) << "mutable block is uninitialized."; | ||
| return false; | ||
| return OLAP_ERR_NOT_INITED; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add docs to explain what these error codes mean.
EmmyMiao87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pache#4388) ## Proposed changes Support to use view when create async materialized view Issue Number: close #xxx <!--Describe your changes.-->
Proposed changes
In the process of historical data transformation of materialized views, it may occur that the transformation fails due to data quality.
Add an error status code :
OLAP_ERR_DATE_QUALITY_ERRto determine if a data problem is causing the failure#3344
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...