[NewFeature] Support ExternalCatalogResource to simplify external table manage operation.#4559
Merged
morningman merged 3 commits intoapache:masterfrom Sep 25, 2020
Merged
Conversation
ebc6c96 to
c4344cb
Compare
morningman
reviewed
Sep 19, 2020
| * CREATE EXTERNAL RESOURCE "odbc_mysql" | ||
| * PROPERTIES | ||
| * ( | ||
| * "type" = "external_catalog", [required] |
Contributor
There was a problem hiding this comment.
The current hierarchy is:
Resource -> external_catalog -> odbc_catalog
But I think it can be simplified as:
Resource -> odbc_catalog
So the "type" is "odbc_catalog", and "odbc_type" is "mysql".
| try { | ||
| // resource name | ||
| adler32.update(externalCatalogResourceName.getBytes(charsetName)); | ||
| // name |
Contributor
There was a problem hiding this comment.
the following host, port maybe null. we need to check them or use getxxx() methods.
…le operation. Fix apache#4556 1. Add new Resource ExternalCatalogResource ``` create external resource "odbc" properties ( "type" = "external_catalog", (required) "user" = "test",(required) "password" = "", (required) "host" = "192.168.0.1", (required) "port" = "8086", (required) "type" = "oracle" , (optinal,only odbc exteranl table use) "driver" = "Oracle 19 ODBC driver" (optional,only odbc exteranl table use) ) ``` 2.After create ExternalCatalogResource, can create external table like: ``` CREATE TABLE `test_mysql` ( `k1` tinyint(4) NOT NULL, `k2` smallint(6) NOT NULL, `k3` int(11) NOT NULL, `k4` bigint(20) NOT NULL, `k5` decimal(9,3) NOT NULL, `k6` char(5) NOT NULL, `k10` date DEFAULT NULL, `k11` datetime DEFAULT NULL, `k7` varchar(20) NOT NULL, `k8` double NOT NULL, `k9` float NOT NULL ) ENGINE=MYSQL PROPERTIES ( "external_catalog_resource" = "odbc", "database" = "test", "table" = "test" ); ```
c4344cb to
e6c3685
Compare
e6c3685 to
4c94d85
Compare
Closed
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Dec 30, 2025
…ug. apache#56083 (apache#5646) picked from apache#56083 related issue: apache#4559 Co-authored-by: James <lijibing@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4556
2.After create ExternalCatalogResource, can create external table like:
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.