[fix](LargeInt)Fix large int max_value + 1 not overflow bug. by Jibing-Li · Pull Request #56083 · apache/doris

Jibing-Li · 2025-09-16T02:27:37Z

What problem does this PR solve?

Fix large int max_value + 1 not overflow bug.
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-09-16T02:27:42Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Jibing-Li · 2025-09-16T02:30:12Z

run buildall

Jibing-Li · 2025-09-16T02:44:31Z

run buildall

doris-robot · 2025-09-16T03:13:50Z

TPC-H: Total hot run time: 34681 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 31c9e51bea0af093161afc87792f9f17adb50912, data reload: false

------ Round 1 ----------------------------------
q1	17620	5255	5050	5050
q2	2021	319	202	202
q3	10264	1376	719	719
q4	10236	1029	527	527
q5	7516	2385	2387	2385
q6	183	162	138	138
q7	969	745	645	645
q8	9366	1318	1095	1095
q9	6960	5077	5211	5077
q10	6901	2407	1988	1988
q11	490	292	285	285
q12	353	365	223	223
q13	17778	3588	3062	3062
q14	243	242	224	224
q15	561	504	480	480
q16	1004	988	952	952
q17	584	879	361	361
q18	7824	7101	7277	7101
q19	1241	957	576	576
q20	340	339	235	235
q21	3795	2552	2353	2353
q22	1096	1050	1003	1003
Total cold run time: 107345 ms
Total hot run time: 34681 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5096	5068	5108	5068
q2	249	342	238	238
q3	2151	2673	2336	2336
q4	1351	1797	1338	1338
q5	4220	4545	4569	4545
q6	221	177	137	137
q7	2058	1955	1857	1857
q8	2645	2646	2634	2634
q9	7566	7386	7350	7350
q10	3103	3323	2896	2896
q11	603	528	547	528
q12	686	805	716	716
q13	3621	3874	3432	3432
q14	307	329	291	291
q15	544	485	512	485
q16	1087	1118	1043	1043
q17	1187	1617	1400	1400
q18	7850	7771	7639	7639
q19	803	869	1035	869
q20	2052	2041	1856	1856
q21	4784	4300	4314	4300
q22	1083	1071	999	999
Total cold run time: 53267 ms
Total hot run time: 51957 ms

doris-robot · 2025-09-16T03:25:34Z

TPC-DS: Total hot run time: 188430 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 31c9e51bea0af093161afc87792f9f17adb50912, data reload: false

query1	1056	449	441	441
query2	6551	1706	1712	1706
query3	6759	226	218	218
query4	26592	23282	23562	23282
query5	4437	646	480	480
query6	366	241	228	228
query7	4644	516	306	306
query8	326	257	253	253
query9	8697	2630	2650	2630
query10	489	333	293	293
query11	15405	15003	14921	14921
query12	182	116	112	112
query13	1698	587	418	418
query14	11179	9133	9220	9133
query15	210	195	179	179
query16	7694	712	451	451
query17	1370	734	642	642
query18	2037	446	331	331
query19	251	201	170	170
query20	141	125	122	122
query21	216	135	118	118
query22	4164	4185	4192	4185
query23	34102	33243	32990	32990
query24	8511	2347	2385	2347
query25	591	499	457	457
query26	1241	275	164	164
query27	2728	520	363	363
query28	4333	2241	2208	2208
query29	777	612	487	487
query30	294	262	200	200
query31	929	802	730	730
query32	76	78	74	74
query33	586	374	332	332
query34	804	859	514	514
query35	825	845	747	747
query36	963	1033	911	911
query37	118	144	90	90
query38	3577	3673	3443	3443
query39	1515	1425	1409	1409
query40	219	131	122	122
query41	66	65	67	65
query42	129	114	114	114
query43	522	509	475	475
query44	1323	879	832	832
query45	185	175	168	168
query46	860	1038	668	668
query47	1796	1834	1765	1765
query48	388	417	317	317
query49	772	500	410	410
query50	647	699	411	411
query51	3975	3902	3856	3856
query52	113	109	102	102
query53	231	265	196	196
query54	596	583	551	551
query55	87	87	80	80
query56	319	309	314	309
query57	1182	1204	1151	1151
query58	276	280	272	272
query59	2637	2667	2637	2637
query60	358	350	348	348
query61	201	201	199	199
query62	805	736	729	729
query63	229	191	194	191
query64	4479	1199	826	826
query65	4040	3961	3950	3950
query66	1096	485	343	343
query67	15545	15239	15137	15137
query68	8245	928	592	592
query69	488	320	274	274
query70	1312	1333	1242	1242
query71	583	335	319	319
query72	5861	5019	4921	4921
query73	662	577	351	351
query74	9182	8941	8640	8640
query75	3956	3336	2779	2779
query76	3617	1169	742	742
query77	799	409	335	335
query78	9538	9584	8870	8870
query79	2153	837	575	575
query80	637	562	530	530
query81	474	296	228	228
query82	454	161	132	132
query83	294	257	249	249
query84	305	121	95	95
query85	897	473	439	439
query86	340	308	295	295
query87	3723	3825	3632	3632
query88	3538	2183	2198	2183
query89	399	320	310	310
query90	1948	212	210	210
query91	165	167	134	134
query92	91	66	64	64
query93	1627	982	656	656
query94	697	434	341	341
query95	393	316	311	311
query96	488	557	274	274
query97	2921	2968	2879	2879
query98	232	220	213	213
query99	1413	1416	1306	1306
Total cold run time: 276942 ms
Total hot run time: 188430 ms

doris-robot · 2025-09-16T03:31:03Z

ClickBench: Total hot run time: 30.17 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 31c9e51bea0af093161afc87792f9f17adb50912, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.05	0.06
query3	0.26	0.08	0.08
query4	1.60	0.12	0.11
query5	0.27	0.26	0.26
query6	1.18	0.66	0.64
query7	0.04	0.03	0.03
query8	0.05	0.05	0.04
query9	0.63	0.54	0.51
query10	0.56	0.58	0.57
query11	0.16	0.11	0.11
query12	0.16	0.12	0.12
query13	0.65	0.62	0.62
query14	1.01	1.01	1.03
query15	0.87	0.85	0.85
query16	0.40	0.40	0.41
query17	1.05	1.04	1.06
query18	0.22	0.20	0.21
query19	1.94	1.84	1.78
query20	0.01	0.02	0.01
query21	15.45	0.94	0.60
query22	0.75	1.33	0.75
query23	14.79	1.41	0.64
query24	6.78	1.18	0.91
query25	0.51	0.30	0.07
query26	0.58	0.16	0.14
query27	0.07	0.06	0.06
query28	10.02	0.96	0.45
query29	12.56	3.96	3.38
query30	0.28	0.13	0.10
query31	2.83	0.60	0.38
query32	3.24	0.55	0.48
query33	3.06	3.07	3.11
query34	16.03	5.42	4.86
query35	4.95	4.94	4.91
query36	0.69	0.52	0.51
query37	0.11	0.07	0.08
query38	0.07	0.06	0.04
query39	0.04	0.03	0.03
query40	0.16	0.16	0.15
query41	0.10	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.37 s
Total hot run time: 30.17 s

hello-stephen · 2025-09-16T03:51:26Z

FE UT Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

github-actions · 2025-09-16T04:26:48Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-09-16T04:26:50Z

PR approved by anyone and no changes requested.

Jibing-Li · 2025-09-16T09:53:42Z

run buildall

doris-robot · 2025-09-16T11:04:11Z

TPC-H: Total hot run time: 35016 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 459751f44029712cf52d5b3dffc182681b10e577, data reload: false

------ Round 1 ----------------------------------
q1	17659	5292	5032	5032
q2	2016	322	233	233
q3	10250	1351	727	727
q4	10248	1032	521	521
q5	7495	2502	2381	2381
q6	184	167	136	136
q7	961	786	646	646
q8	9362	1346	1201	1201
q9	7146	5181	5245	5181
q10	6959	2430	2010	2010
q11	509	300	292	292
q12	373	355	243	243
q13	17790	3671	3041	3041
q14	238	234	230	230
q15	594	505	486	486
q16	1001	994	951	951
q17	635	877	359	359
q18	7453	7165	7155	7155
q19	1171	952	553	553
q20	345	338	226	226
q21	3829	2580	2428	2428
q22	1062	1038	984	984
Total cold run time: 107280 ms
Total hot run time: 35016 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5208	5127	5122	5122
q2	246	332	227	227
q3	2230	2678	2302	2302
q4	1363	1807	1325	1325
q5	4227	4578	4535	4535
q6	219	174	133	133
q7	2050	2016	1842	1842
q8	2718	2536	2611	2536
q9	7612	7362	7342	7342
q10	3171	3309	2867	2867
q11	610	527	520	520
q12	744	793	642	642
q13	3548	3960	3437	3437
q14	290	324	291	291
q15	541	499	482	482
q16	1124	1111	1100	1100
q17	1244	1640	1423	1423
q18	7839	7744	7204	7204
q19	781	735	846	735
q20	1914	1954	1816	1816
q21	4769	4392	4289	4289
q22	1116	1048	1000	1000
Total cold run time: 53564 ms
Total hot run time: 51170 ms

doris-robot · 2025-09-16T11:15:55Z

TPC-DS: Total hot run time: 188464 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 459751f44029712cf52d5b3dffc182681b10e577, data reload: false

query1	1061	448	413	413
query2	6577	1762	1690	1690
query3	6753	218	232	218
query4	26629	23826	23216	23216
query5	4961	649	476	476
query6	337	252	214	214
query7	4659	507	297	297
query8	319	255	244	244
query9	8678	2606	2618	2606
query10	509	350	294	294
query11	15332	15046	14906	14906
query12	161	111	111	111
query13	1668	554	447	447
query14	10661	9271	9343	9271
query15	213	233	178	178
query16	7649	662	500	500
query17	1174	746	607	607
query18	2021	415	325	325
query19	199	256	180	180
query20	127	127	124	124
query21	218	133	113	113
query22	4153	4265	4050	4050
query23	33972	33203	32842	32842
query24	8473	2356	2445	2356
query25	543	519	419	419
query26	1234	276	160	160
query27	2734	506	361	361
query28	4406	2225	2224	2224
query29	812	597	490	490
query30	297	231	200	200
query31	938	832	731	731
query32	87	72	73	72
query33	578	382	328	328
query34	820	854	530	530
query35	832	852	759	759
query36	967	1059	912	912
query37	121	110	81	81
query38	3527	3560	3464	3464
query39	1506	1424	1413	1413
query40	227	139	124	124
query41	71	61	62	61
query42	129	113	113	113
query43	509	499	473	473
query44	1321	848	834	834
query45	187	185	167	167
query46	862	1036	634	634
query47	1760	1792	1734	1734
query48	399	425	311	311
query49	770	495	424	424
query50	669	692	406	406
query51	3917	3942	4057	3942
query52	117	114	101	101
query53	242	266	207	207
query54	618	605	540	540
query55	94	91	92	91
query56	347	336	318	318
query57	1204	1196	1125	1125
query58	285	283	278	278
query59	2634	2694	2615	2615
query60	361	356	351	351
query61	198	188	187	187
query62	849	761	673	673
query63	232	194	187	187
query64	4450	1195	817	817
query65	4044	3966	3987	3966
query66	1114	434	339	339
query67	15520	15312	15078	15078
query68	9027	927	586	586
query69	484	314	276	276
query70	1497	1291	1178	1178
query71	566	347	308	308
query72	5562	4906	5095	4906
query73	692	565	357	357
query74	8873	9138	8932	8932
query75	4296	3321	2883	2883
query76	3685	1173	732	732
query77	834	403	338	338
query78	9546	10119	8884	8884
query79	1829	842	593	593
query80	681	566	525	525
query81	486	264	229	229
query82	450	160	134	134
query83	265	274	253	253
query84	258	113	91	91
query85	875	468	511	468
query86	340	314	327	314
query87	3774	3781	3658	3658
query88	3347	2226	2233	2226
query89	404	327	305	305
query90	1911	217	220	217
query91	172	169	134	134
query92	75	66	62	62
query93	1154	1024	641	641
query94	695	437	331	331
query95	390	316	304	304
query96	484	553	275	275
query97	2937	2970	2885	2885
query98	248	214	207	207
query99	1669	1384	1314	1314
Total cold run time: 276542 ms
Total hot run time: 188464 ms

doris-robot · 2025-09-16T11:21:25Z

ClickBench: Total hot run time: 30.36 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 459751f44029712cf52d5b3dffc182681b10e577, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.05	0.05
query3	0.25	0.08	0.09
query4	1.60	0.11	0.11
query5	0.27	0.27	0.26
query6	1.16	0.67	0.64
query7	0.04	0.03	0.03
query8	0.06	0.05	0.04
query9	0.62	0.54	0.52
query10	0.58	0.58	0.59
query11	0.17	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	1.02	1.02	1.02
query15	0.87	0.90	0.87
query16	0.40	0.39	0.40
query17	1.06	1.05	1.06
query18	0.22	0.20	0.21
query19	1.91	1.86	1.86
query20	0.02	0.01	0.01
query21	15.44	0.90	0.58
query22	0.79	1.37	0.71
query23	14.76	1.43	0.66
query24	7.07	1.08	1.19
query25	0.49	0.20	0.09
query26	0.62	0.17	0.13
query27	0.07	0.06	0.06
query28	9.92	0.88	0.43
query29	12.62	3.95	3.23
query30	0.29	0.14	0.12
query31	2.88	0.60	0.38
query32	3.24	0.56	0.48
query33	3.04	3.16	3.26
query34	16.15	5.49	4.86
query35	4.92	4.98	4.92
query36	0.71	0.52	0.50
query37	0.11	0.07	0.08
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.16	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.76 s
Total hot run time: 30.36 s

github-actions · 2025-09-16T11:25:29Z

PR approved by at least one committer and no changes requested.

hello-stephen · 2025-09-16T13:58:10Z

FE Regression Coverage Report

Increment line coverage 25.00% (1/4) 🎉
Increment coverage report
Complete coverage report

…56083) Fix large int max_value + 1 not overflow bug.

…ug. #56083 (#57351) backport: #56083

…ug. apache#56083 (apache#5646) picked from apache#56083 related issue: apache#4559 Co-authored-by: James <lijibing@selectdb.com>

Jibing-Li marked this pull request as ready for review September 16, 2025 02:28

Jibing-Li force-pushed the bigint branch from d3f3a06 to 31c9e51 Compare September 16, 2025 02:33

yiguolei previously approved these changes Sep 16, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 16, 2025

github-actions bot added the reviewed label Sep 16, 2025

Fix large int max_value + 1 not overflow bug.

459751f

Jibing-Li dismissed yiguolei’s stale review via 459751f September 16, 2025 09:52

Jibing-Li force-pushed the bigint branch from 31c9e51 to 459751f Compare September 16, 2025 09:52

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 16, 2025

morrySnow approved these changes Sep 16, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 16, 2025

yiguolei approved these changes Sep 16, 2025

View reviewed changes

Jibing-Li merged commit 4833004 into apache:master Sep 17, 2025
28 of 30 checks passed

Jibing-Li deleted the bigint branch September 17, 2025 01:56

morrySnow added the dev/3.1.x label Oct 16, 2025

github-actions bot added the dev/3.1.x-conflict label Oct 16, 2025

Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 27, 2025

[fix](LargeInt)Fix large int max_value + 1 not overflow bug. (apache#…

af5f04f

…56083) Fix large int max_value + 1 not overflow bug.

Jibing-Li mentioned this pull request Oct 27, 2025

branch-3.1: [fix](LargeInt)Fix large int max_value + 1 not overflow bug. #56083 #57351

Merged

morrySnow pushed a commit that referenced this pull request Oct 28, 2025

branch-3.1: [fix](LargeInt)Fix large int max_value + 1 not overflow b…

525fca8

…ug. #56083 (#57351) backport: #56083

morrySnow added dev/3.1.3-merged not-merge/4.0 and removed dev/3.1.x dev/3.1.x-conflict labels Oct 28, 2025

Conversation

Jibing-Li commented Sep 16, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Sep 16, 2025

Uh oh!

Jibing-Li commented Sep 16, 2025

Uh oh!

Jibing-Li commented Sep 16, 2025

Uh oh!

doris-robot commented Sep 16, 2025

Uh oh!

doris-robot commented Sep 16, 2025

Uh oh!

doris-robot commented Sep 16, 2025

Uh oh!

hello-stephen commented Sep 16, 2025

FE UT Coverage Report

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

Jibing-Li commented Sep 16, 2025

Uh oh!

doris-robot commented Sep 16, 2025

Uh oh!

doris-robot commented Sep 16, 2025

Uh oh!

doris-robot commented Sep 16, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

hello-stephen commented Sep 16, 2025

FE Regression Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants