Skip to content

[fix](vault) fix CreateTableLikeStmt cannot work in stoarge vault mode #46625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jan 8, 2025
Merged

[fix](vault) fix CreateTableLikeStmt cannot work in stoarge vault mode #46625

dataroaring merged 1 commit into from
Jan 8, 2025

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Jan 8, 2025 •
edited
Loading 

  Failed to execute CREATE TABLE LIKE demo_table. Reason: errCode = 2, detailMessage = Unknown properties

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@swjtu-zhanglei
[fix](vault) fix CreateTableLikeStmt cannot work in stoarge vault mode
7221f6d 
```
  Failed to execute CREATE TABLE LIKE demo_table. Reason: errCode = 2, detailMessage = Unknown properties
```
@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Jan 8, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

TPC-H: Total hot run time: 32430 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7221f6dade3e4907068188d7048aa4bb1d87acf5, data reload: false

------ Round 1 ----------------------------------
q1	17596	6168	6003	6003
q2	2047	296	166	166
q3	10449	1214	766	766
q4	10231	868	434	434
q5	7957	2162	1948	1948
q6	211	183	148	148
q7	879	728	591	591
q8	9227	1340	1121	1121
q9	5150	4836	4862	4836
q10	6790	2290	1839	1839
q11	489	276	254	254
q12	349	358	226	226
q13	17787	3626	3115	3115
q14	230	245	223	223
q15	569	494	512	494
q16	632	620	575	575
q17	561	841	325	325
q18	6809	6501	6381	6381
q19	2158	981	560	560
q20	303	312	185	185
q21	3005	2145	1930	1930
q22	364	335	310	310
Total cold run time: 103793 ms
Total hot run time: 32430 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6296	6214	6180	6180
q2	235	339	232	232
q3	2223	2593	2310	2310
q4	1401	1814	1358	1358
q5	4324	4686	4704	4686
q6	183	178	144	144
q7	2058	1900	1830	1830
q8	2596	2787	2694	2694
q9	7237	7157	7243	7157
q10	3041	3326	2839	2839
q11	572	540	490	490
q12	638	721	599	599
q13	3460	3903	3261	3261
q14	293	297	292	292
q15	570	517	524	517
q16	649	689	644	644
q17	1209	1725	1262	1262
q18	7726	7451	7238	7238
q19	851	1184	1058	1058
q20	2040	2070	1885	1885
q21	5661	5274	4900	4900
q22	624	629	586	586
Total cold run time: 53887 ms
Total hot run time: 52162 ms

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

TPC-DS: Total hot run time: 194908 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7221f6dade3e4907068188d7048aa4bb1d87acf5, data reload: false

query1	1302	965	936	936
query2	6472	2257	2362	2257
query3	10952	4804	4712	4712
query4	32886	23489	23371	23371
query5	4066	598	450	450
query6	288	204	213	204
query7	3996	484	315	315
query8	319	257	242	242
query9	9589	2735	2729	2729
query10	477	307	256	256
query11	17768	15259	15167	15167
query12	168	103	102	102
query13	1641	549	402	402
query14	11196	7590	7212	7212
query15	249	200	187	187
query16	7934	603	495	495
query17	1583	756	582	582
query18	2158	410	312	312
query19	189	183	154	154
query20	130	110	112	110
query21	212	120	104	104
query22	4445	4705	4299	4299
query23	33758	33642	33049	33049
query24	6337	2281	2312	2281
query25	517	483	402	402
query26	809	276	155	155
query27	2034	473	341	341
query28	5646	2497	2464	2464
query29	650	556	440	440
query30	211	188	149	149
query31	956	897	812	812
query32	73	55	58	55
query33	479	344	297	297
query34	782	847	520	520
query35	791	816	734	734
query36	1029	1016	965	965
query37	119	98	77	77
query38	4075	4062	4333	4062
query39	1492	1475	1460	1460
query40	206	115	107	107
query41	47	53	48	48
query42	122	110	110	110
query43	529	530	491	491
query44	1386	856	845	845
query45	184	186	172	172
query46	884	1054	688	688
query47	1914	1908	1820	1820
query48	390	409	332	332
query49	705	477	377	377
query50	662	671	404	404
query51	7048	7041	7044	7041
query52	102	99	91	91
query53	242	259	183	183
query54	516	506	405	405
query55	87	87	77	77
query56	258	251	231	231
query57	1198	1182	1151	1151
query58	245	227	215	215
query59	3085	3366	3107	3107
query60	295	265	242	242
query61	109	118	109	109
query62	843	789	710	710
query63	229	199	190	190
query64	3470	1040	638	638
query65	3276	3283	3250	3250
query66	871	403	304	304
query67	16247	15655	15387	15387
query68	8705	753	512	512
query69	467	295	249	249
query70	1184	1128	1141	1128
query71	435	291	252	252
query72	6217	3851	3817	3817
query73	648	760	360	360
query74	9850	9042	9040	9040
query75	3898	3156	2660	2660
query76	3598	1187	771	771
query77	808	350	275	275
query78	10045	10010	9222	9222
query79	3480	828	589	589
query80	590	524	446	446
query81	493	273	226	226
query82	657	147	117	117
query83	152	163	145	145
query84	244	91	67	67
query85	827	357	300	300
query86	391	319	280	280
query87	4407	4276	4332	4276
query88	4576	2194	2202	2194
query89	412	329	290	290
query90	1800	185	191	185
query91	128	131	103	103
query92	65	54	50	50
query93	2151	891	524	524
query94	648	384	291	291
query95	334	266	265	265
query96	488	609	287	287
query97	2788	2941	2798	2798
query98	211	193	197	193
query99	1712	1505	1410	1410
Total cold run time: 295337 ms
Total hot run time: 194908 ms

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

ClickBench: Total hot run time: 31.57 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7221f6dade3e4907068188d7048aa4bb1d87acf5, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.08	0.07
query4	1.62	0.11	0.10
query5	0.41	0.44	0.40
query6	1.16	0.66	0.64
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.60	0.50	0.50
query10	0.55	0.57	0.55
query11	0.14	0.11	0.10
query12	0.13	0.11	0.10
query13	0.61	0.60	0.60
query14	2.71	2.75	2.81
query15	0.88	0.81	0.82
query16	0.38	0.39	0.38
query17	1.09	1.05	1.05
query18	0.23	0.21	0.21
query19	1.90	1.84	1.97
query20	0.01	0.01	0.01
query21	15.36	0.87	0.58
query22	0.75	0.94	0.58
query23	15.27	1.46	0.53
query24	3.04	1.43	2.17
query25	0.20	0.07	0.18
query26	0.18	0.14	0.13
query27	0.05	0.05	0.06
query28	14.54	1.50	1.05
query29	12.59	3.96	3.26
query30	0.25	0.09	0.06
query31	2.85	0.60	0.37
query32	3.23	0.55	0.46
query33	3.07	3.08	3.21
query34	16.76	5.12	4.50
query35	4.49	4.44	4.44
query36	0.83	0.49	0.49
query37	0.10	0.05	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.04
query40	0.17	0.13	0.12
query41	0.09	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.8 s
Total hot run time: 31.57 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c5953f8 into apache:master Jan 8, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@swjtu-zhanglei
[fix](vault) fix CreateTableLikeStmt cannot work in stoarge vault m…
321909a 
…ode (#46625)

```
  Failed to execute CREATE TABLE LIKE demo_table. Reason: errCode = 2, detailMessage = Unknown properties
```
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 13, 2025
@github-actions @swjtu-zhanglei
branch-3.0: [fix](vault) fix CreateTableLikeStmt cannot work in sto…
a0b2195 
…arge vault mode #46625 (#46654)

Cherry-picked from #46625

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swjtu-zhanglei @hello-stephen @doris-robot @gavinchou @dataroaring