Skip to content

branch-3.0: [fix](vault) fix CreateTableLikeStmt cannot work in stoarge vault mode #46625 #46654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jan 13, 2025
Merged

branch-3.0: [fix](vault) fix CreateTableLikeStmt cannot work in stoarge vault mode #46625 #46654

dataroaring merged 1 commit into from
Jan 13, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

Cherry-picked from #46625

@swjtu-zhanglei
[fix](vault) fix CreateTableLikeStmt cannot work in stoarge vault m…
321909a 
…ode (#46625)

```
  Failed to execute CREATE TABLE LIKE demo_table. Reason: errCode = 2, detailMessage = Unknown properties
```
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 8, 2025
@dataroaring dataroaring reopened this Jan 8, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

TPC-H: Total hot run time: 41397 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 321909a29373c4a8e4b01c73a5455e7f24ed3515, data reload: false

------ Round 1 ----------------------------------
q1	17857	7797	7409	7409
q2	2521	175	167	167
q3	11338	1160	1241	1160
q4	10711	761	794	761
q5	8086	2943	2810	2810
q6	241	155	156	155
q7	994	622	607	607
q8	9693	2023	2087	2023
q9	6867	6500	6472	6472
q10	6990	2320	2327	2320
q11	467	261	256	256
q12	420	207	206	206
q13	17786	2989	3010	2989
q14	232	219	206	206
q15	578	516	502	502
q16	667	630	623	623
q17	983	604	606	604
q18	7302	6774	6632	6632
q19	1402	1102	1048	1048
q20	483	198	201	198
q21	4040	3252	3342	3252
q22	1117	997	1008	997
Total cold run time: 110775 ms
Total hot run time: 41397 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7292	7324	7303	7303
q2	350	245	252	245
q3	3155	3035	3001	3001
q4	2107	1817	1828	1817
q5	5676	5732	5711	5711
q6	221	139	147	139
q7	2242	1791	1819	1791
q8	3339	3505	3526	3505
q9	8817	8855	8866	8855
q10	3639	3530	3534	3530
q11	605	493	497	493
q12	805	593	606	593
q13	7467	3139	3127	3127
q14	291	267	285	267
q15	574	523	513	513
q16	706	665	671	665
q17	1848	1645	1596	1596
q18	8271	7769	7490	7490
q19	1665	1571	1528	1528
q20	2042	1813	1814	1813
q21	5365	5148	5264	5148
q22	1119	986	983	983
Total cold run time: 67596 ms
Total hot run time: 60113 ms

@doris-robot
Copy link

doris-robot commented Jan 8, 2025

TPC-DS: Total hot run time: 191698 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 321909a29373c4a8e4b01c73a5455e7f24ed3515, data reload: false

query1	1000	376	377	376
query2	6516	2089	2085	2085
query3	6706	216	217	216
query4	34014	23439	23508	23439
query5	4327	446	442	442
query6	272	168	174	168
query7	4632	309	312	309
query8	296	235	226	226
query9	9581	2700	2699	2699
query10	486	260	269	260
query11	18028	15127	15225	15127
query12	155	104	106	104
query13	1669	433	411	411
query14	9760	7213	6415	6415
query15	273	174	177	174
query16	8117	456	505	456
query17	1635	573	566	566
query18	2125	321	315	315
query19	286	163	157	157
query20	119	109	109	109
query21	213	104	103	103
query22	4601	4531	4330	4330
query23	34882	34115	33830	33830
query24	11226	2836	2884	2836
query25	703	415	406	406
query26	1389	173	173	173
query27	2891	346	341	341
query28	7926	2464	2446	2446
query29	919	453	445	445
query30	331	171	168	168
query31	1046	813	817	813
query32	90	61	61	61
query33	796	298	298	298
query34	953	491	521	491
query35	867	717	740	717
query36	1116	957	947	947
query37	149	76	74	74
query38	3997	3927	3894	3894
query39	1526	1578	1433	1433
query40	287	103	109	103
query41	56	53	53	53
query42	119	102	99	99
query43	554	505	496	496
query44	1249	818	812	812
query45	185	170	174	170
query46	1159	722	724	722
query47	2000	1883	1889	1883
query48	478	383	397	383
query49	1206	416	420	416
query50	813	412	408	408
query51	7298	7109	7147	7109
query52	108	94	93	93
query53	261	187	188	187
query54	1226	469	478	469
query55	75	80	88	80
query56	277	265	259	259
query57	1218	1123	1125	1123
query58	254	214	220	214
query59	3325	3027	3247	3027
query60	292	253	246	246
query61	115	126	136	126
query62	904	673	664	664
query63	240	190	186	186
query64	5291	660	634	634
query65	3299	3228	3214	3214
query66	1441	308	314	308
query67	16145	15778	15715	15715
query68	4896	566	575	566
query69	434	267	260	260
query70	1199	1130	1140	1130
query71	334	253	247	247
query72	6397	4057	4028	4028
query73	752	352	354	352
query74	10257	9009	9016	9009
query75	3401	2641	2666	2641
query76	2920	1055	964	964
query77	410	278	268	268
query78	10545	9754	9667	9667
query79	2563	603	612	603
query80	1165	435	436	435
query81	555	242	246	242
query82	928	121	124	121
query83	243	149	145	145
query84	240	81	81	81
query85	1415	303	303	303
query86	443	303	290	290
query87	4523	4285	4300	4285
query88	4247	2355	2338	2338
query89	408	290	299	290
query90	2195	184	191	184
query91	183	150	149	149
query92	69	54	50	50
query93	1719	555	557	555
query94	1073	291	292	291
query95	361	255	256	255
query96	605	285	276	276
query97	3387	3150	3193	3150
query98	213	209	196	196
query99	1544	1315	1268	1268
Total cold run time: 305117 ms
Total hot run time: 191698 ms

@swjtu-zhanglei
Copy link
Contributor

swjtu-zhanglei commented Jan 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

TPC-H: Total hot run time: 41187 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 321909a29373c4a8e4b01c73a5455e7f24ed3515, data reload: false

------ Round 1 ----------------------------------
q1	17564	7365	7240	7240
q2	2059	178	172	172
q3	10561	1080	1170	1080
q4	10576	735	814	735
q5	7732	2828	2864	2828
q6	234	150	150	150
q7	971	620	600	600
q8	9372	1921	2020	1921
q9	6551	6379	6369	6369
q10	7001	2302	2311	2302
q11	474	273	270	270
q12	396	212	212	212
q13	17778	3024	3040	3024
q14	232	203	212	203
q15	563	518	526	518
q16	673	612	608	608
q17	969	577	614	577
q18	7205	6890	7167	6890
q19	1397	1106	1042	1042
q20	496	228	213	213
q21	4053	3239	3252	3239
q22	1113	1000	994	994
Total cold run time: 107970 ms
Total hot run time: 41187 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7247	7196	7188	7188
q2	323	242	231	231
q3	2919	2831	2948	2831
q4	2033	1879	1890	1879
q5	5720	5716	5762	5716
q6	229	141	139	139
q7	2242	1825	1782	1782
q8	3377	3603	3542	3542
q9	8812	8906	8926	8906
q10	3572	3523	3527	3523
q11	608	498	497	497
q12	857	581	581	581
q13	10966	3186	3149	3149
q14	331	279	269	269
q15	569	539	525	525
q16	707	674	691	674
q17	1857	1612	1628	1612
q18	8240	7778	7759	7759
q19	1666	1576	1549	1549
q20	2032	1863	1896	1863
q21	5434	5425	5485	5425
q22	1136	1063	1004	1004
Total cold run time: 70877 ms
Total hot run time: 60644 ms

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

TPC-DS: Total hot run time: 196930 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 321909a29373c4a8e4b01c73a5455e7f24ed3515, data reload: false

query1	1274	892	904	892
query2	6229	2129	2075	2075
query3	10821	4208	4300	4208
query4	62392	28325	23502	23502
query5	5238	457	463	457
query6	406	170	173	170
query7	5443	312	310	310
query8	306	234	224	224
query9	8117	2676	2685	2676
query10	468	285	253	253
query11	17305	15098	15562	15098
query12	164	105	106	105
query13	1424	454	433	433
query14	10802	6601	7167	6601
query15	224	172	190	172
query16	7160	469	496	469
query17	1182	598	596	596
query18	1795	335	318	318
query19	215	178	162	162
query20	120	114	125	114
query21	205	106	107	106
query22	4712	4347	4838	4347
query23	34821	34154	34449	34154
query24	6116	2979	3002	2979
query25	536	418	430	418
query26	684	185	181	181
query27	1929	364	358	358
query28	4027	2514	2464	2464
query29	732	490	470	470
query30	260	169	166	166
query31	1000	816	791	791
query32	64	61	61	61
query33	445	295	297	295
query34	928	531	532	531
query35	878	719	714	714
query36	1084	973	957	957
query37	120	76	69	69
query38	4053	4045	4032	4032
query39	1501	1469	1499	1469
query40	209	107	104	104
query41	51	48	47	47
query42	116	100	98	98
query43	559	491	507	491
query44	1216	836	828	828
query45	193	172	174	172
query46	1182	750	734	734
query47	2022	1919	1930	1919
query48	487	388	399	388
query49	725	384	390	384
query50	858	434	422	422
query51	7251	7186	7277	7186
query52	111	91	92	91
query53	268	194	186	186
query54	587	482	470	470
query55	83	77	77	77
query56	275	269	267	267
query57	1277	1177	1170	1170
query58	220	212	215	212
query59	3237	2980	2893	2893
query60	280	249	247	247
query61	109	108	104	104
query62	755	660	659	659
query63	223	195	187	187
query64	1384	688	640	640
query65	3250	3176	3201	3176
query66	676	302	307	302
query67	15870	15655	15544	15544
query68	4439	587	567	567
query69	444	302	269	269
query70	1217	1062	1131	1062
query71	341	259	256	256
query72	6337	4097	3968	3968
query73	751	345	356	345
query74	10270	8939	8944	8939
query75	3377	2640	2706	2640
query76	1897	1094	1036	1036
query77	539	286	276	276
query78	10579	9588	9650	9588
query79	1853	590	611	590
query80	1451	411	416	411
query81	526	242	237	237
query82	1254	116	119	116
query83	170	151	150	150
query84	285	79	77	77
query85	1022	314	296	296
query86	382	299	290	290
query87	4412	4270	4304	4270
query88	3993	2446	2422	2422
query89	423	285	294	285
query90	1977	189	191	189
query91	185	148	149	148
query92	70	52	52	52
query93	2013	560	564	560
query94	792	253	303	253
query95	361	261	259	259
query96	621	292	284	284
query97	3325	3223	3210	3210
query98	216	203	201	201
query99	1570	1291	1289	1289
Total cold run time: 315746 ms
Total hot run time: 196930 ms

@doris-robot
Copy link

doris-robot commented Jan 13, 2025

ClickBench: Total hot run time: 32.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 321909a29373c4a8e4b01c73a5455e7f24ed3515, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.11
query5	0.51	0.51	0.53
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.51	0.50
query10	0.54	0.56	0.57
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.90	2.99	2.92
query15	0.88	0.83	0.81
query16	0.38	0.37	0.38
query17	1.05	0.97	1.01
query18	0.24	0.22	0.22
query19	1.90	1.76	2.00
query20	0.02	0.01	0.01
query21	15.35	0.59	0.59
query22	2.79	1.88	2.03
query23	16.91	1.05	0.87
query24	3.38	0.87	1.08
query25	0.31	0.16	0.17
query26	0.35	0.13	0.13
query27	0.04	0.04	0.04
query28	10.68	1.13	1.07
query29	12.55	3.22	3.22
query30	0.25	0.06	0.06
query31	2.87	0.39	0.37
query32	3.26	0.47	0.46
query33	2.97	2.99	3.04
query34	17.07	4.44	4.47
query35	4.58	4.53	4.50
query36	0.67	0.52	0.48
query37	0.10	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 107.56 s
Total hot run time: 32.87 s

@dataroaring dataroaring merged commit a0b2195 into branch-3.0 Jan 13, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-46625-branch-3.0 branch January 13, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @swjtu-zhanglei @dataroaring