-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) fix convert to date literal throw exception #48980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) fix convert to date literal throw exception #48980
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32406 ms |
TPC-DS: Total hot run time: 184930 ms |
ClickBench: Total hot run time: 31.27 s |
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
TPC-DS: Total hot run time: 192457 ms |
ClickBench: Total hot run time: 30.84 s |
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 32327 ms |
TPC-DS: Total hot run time: 185153 ms |
ClickBench: Total hot run time: 31.17 s |
…#48980 (#48773) ### What problem does this PR solve? when nereids cast invalid date literal to date like type, it will throws exceptions: ``` select '' = cast('2020-10-20' as date); (1105, 'errCode = 2, detailMessage = date/datetime literal [] is invalid') ``` But old planner will not throw exceptions, so let neredis don't throw exceptions too. This PR is pick code from: #48980 ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
) ### What problem does this PR solve? when parse date literal failed, no throw DateTimeException, all throw AnalysisException. and for cast date literal met Exception, will skip parsing it, and give it to be for processing. Relate PR: apache#40202
What problem does this PR solve?
when parse date literal failed, no throw DateTimeException, all throw AnalysisException. and for cast date literal met Exception, will skip parsing it, and give it to be for processing.
Relate PR: #40202
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)