-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [fix](nereids) fix convert to date literal throw exception #48980 #48773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch-3.0: [fix](nereids) fix convert to date literal throw exception #48980 #48773
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run performance |
TPC-H: Total hot run time: 39951 ms |
TPC-DS: Total hot run time: 197819 ms |
ClickBench: Total hot run time: 31.6 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
TPC-DS: Total hot run time: 197741 ms |
ClickBench: Total hot run time: 31.86 s |
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 39977 ms |
TPC-DS: Total hot run time: 196893 ms |
ClickBench: Total hot run time: 32.73 s |
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40757 ms |
TPC-DS: Total hot run time: 192361 ms |
ClickBench: Total hot run time: 32.45 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
when nereids cast invalid date literal to date like type, it will throws exceptions:
But old planner will not throw exceptions, so let neredis don't throw exceptions too.
This PR is pick code from: #48980
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)