-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](Nereids) cse extract wrong expression from lambda expressions #49166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32603 ms |
TPC-DS: Total hot run time: 184858 ms |
ClickBench: Total hot run time: 31.24 s |
englefly
approved these changes
Mar 18, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
feiniaofeiafei
approved these changes
Mar 18, 2025
924060929
pushed a commit
to 924060929/incubator-doris
that referenced
this pull request
Apr 10, 2025
…pache#49166) ### What problem does this PR solve? Related PR: apache#33087 Problem Summary: CSE should not extract ArrayItemSlot and ArrayItemReference. Because they could not be computed out of Lambda expression. NOTICE: currently, we could not extract common expression from Lambda, because ArrayItemSlot in Lambda are not same. (cherry picked from commit 9d4faa5)
924060929
pushed a commit
to 924060929/incubator-doris
that referenced
this pull request
Apr 10, 2025
…pache#49166) ### What problem does this PR solve? Related PR: apache#33087 Problem Summary: CSE should not extract ArrayItemSlot and ArrayItemReference. Because they could not be computed out of Lambda expression. NOTICE: currently, we could not extract common expression from Lambda, because ArrayItemSlot in Lambda are not same. (cherry picked from commit 9d4faa5)
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…pache#49166) ### What problem does this PR solve? Related PR: apache#33087 Problem Summary: CSE should not extract ArrayItemSlot and ArrayItemReference. Because they could not be computed out of Lambda expression. NOTICE: currently, we could not extract common expression from Lambda, because ArrayItemSlot in Lambda are not same.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.10-merged
dev/3.0.6-merged
reviewed
usercase
Important user case type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #33087
Problem Summary:
CSE should not extract ArrayItemSlot and ArrayItemReference. Because they could not be computed out of Lambda expression.
NOTICE: currently, we could not extract common expression from Lambda, because ArrayItemSlot in Lambda are not same.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)