Skip to content

branch-3.0: [fix](Nereids) cse extract wrong expression from lambda expressions #49166 #49941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 22, 2025
Merged

branch-3.0: [fix](Nereids) cse extract wrong expression from lambda expressions #49166 #49941

dataroaring merged 1 commit into from
Apr 22, 2025
+92 −19

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Apr 10, 2025

cherry pick from #49166

@morrySnow @924060929
[fix](Nereids) cse extract wrong expression from lambda expressions (a…
883a50d 
…pache#49166)

### What problem does this PR solve?

Related PR: apache#33087

Problem Summary:

CSE should not extract ArrayItemSlot and ArrayItemReference. Because
they could not be computed out of Lambda expression.
NOTICE: currently, we could not extract common expression from Lambda,
because ArrayItemSlot in Lambda are not same.

(cherry picked from commit 9d4faa5)
@Thearas
Copy link
Contributor

Thearas commented Apr 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929 924060929 changed the base branch from master to branch-3.0 April 10, 2025 05:22
@924060929
Copy link
Contributor Author

924060929 commented Apr 10, 2025

run buildall

@morrySnow morrySnow changed the title branch-3.0: [fix](Nereids) cse extract wrong expression from lambda expressions (#49166) branch-3.0: [fix](Nereids) cse extract wrong expression from lambda expressions #49166 Apr 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring reopened this Apr 22, 2025
dataroaring
dataroaring approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 962c009 into apache:branch-3.0 Apr 22, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@924060929 @Thearas @dataroaring @morrySnow