Skip to content

fix httpv2 append extra useless information in get_small_file api #4953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 28, 2020
Merged

fix httpv2 append extra useless information in get_small_file api #4953

morningman merged 1 commit into from
Nov 28, 2020

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Nov 25, 2020

Proposed changes

Fix #4952

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix 【BUG】httpv2 append extra useless information in get_small_file api #4952 ), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yangzhg yangzhg self-assigned this Nov 25, 2020
@yangzhg yangzhg added the kind/fix Categorizes issue or PR as related to a bug. label Nov 25, 2020
morningman
morningman approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Nov 27, 2020
@morningman morningman merged commit c6bc30e into apache:master Nov 28, 2020
@yangzhg yangzhg deleted the remove_extra_msg branch December 22, 2020 07:13
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
@dataroaring @liaoxin01
[fix](load_stream) close brpc stream after load stream is closed (apa…
a9aed9c 
…che#56… (apache#4953)

…120)

Otherwise, auto partition on multi bes may lead to segment num mismatch
problem.

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>
Co-authored-by: Xin Liao <liaoxinbit@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

@yangzhg yangzhg

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

【BUG】httpv2 append extra useless information in get_small_file api

2 participants

@yangzhg @morningman