Skip to content

[fix](cloud) Add check for cluster_name empty in cloud #49775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 15, 2025
Merged

[fix](cloud) Add check for cluster_name empty in cloud #49775

dataroaring merged 1 commit into from
Apr 15, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Apr 2, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

deardeng commented Apr 2, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Apr 2, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.05% (1088/1310)
Line Coverage: 66.13% (18124/27405)
Region Coverage: 65.50% (8919/13617)
Branch Coverage: 55.29% (4799/8680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f7672a1a315eb9e70135a5c86f15a8ddd4ceafda_f7672a1a315eb9e70135a5c86f15a8ddd4ceafda_cloud/report/index.html

dataroaring
dataroaring approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deardeng
Copy link
Contributor Author

deardeng commented Apr 11, 2025

run cloud_p0:

@deardeng
Copy link
Contributor Author

deardeng commented Apr 11, 2025

run cloud_p0

1 similar comment
@deardeng
Copy link
Contributor Author

deardeng commented Apr 11, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 11, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.07% (1089/1311)
Line Coverage: 66.12% (18177/27493)
Region Coverage: 65.56% (8957/13662)
Branch Coverage: 55.39% (4826/8712)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f7672a1a315eb9e70135a5c86f15a8ddd4ceafda_f7672a1a315eb9e70135a5c86f15a8ddd4ceafda_cloud/report/index.html

@deardeng
Copy link
Contributor Author

deardeng commented Apr 12, 2025

run cloud_p0

@dataroaring dataroaring merged commit 3eddb5f into apache:master Apr 15, 2025
28 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
@deardeng
[fix](cloud) Add check for cluster_name empty in cloud (#49775)
b20f011
@github-actions github-actions bot mentioned this pull request Apr 15, 2025
Merged
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
@deardeng @seawinde
[fix](cloud) Add check for cluster_name empty in cloud (apache#49775)
16117ac
@deardeng deardeng mentioned this pull request Apr 17, 2025
Merged
16 tasks
gavinchou pushed a commit that referenced this pull request Apr 22, 2025
@deardeng
[fix](cloud) Some resource APIs should not check if cluster_name is e…
6aa9a33 
…mpty (#50148)

due to #49775

but some api cant check cluster name, 
1. Cloud Management The request may not have passed in the cluster_name
in the inventory logic
2. sql node mode also not pass cluster_name to ms, so in cloud use sql
`ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster
name
dataroaring pushed a commit that referenced this pull request May 19, 2025
@github-actions @deardeng
branch-3.0: [fix](cloud) Add check for cluster_name empty in cloud #4…
8a3626c 
…9775 (#50072)

Cherry-picked from #49775

Co-authored-by: deardeng <dengxin@selectdb.com>
deardeng added a commit to deardeng/incubator-doris that referenced this pull request May 19, 2025
@deardeng
[fix](cloud) Some resource APIs should not check if cluster_name is e…
cb3e2b7 
…mpty (apache#50148)

due to apache#49775

but some api cant check cluster name, 
1. Cloud Management The request may not have passed in the cluster_name
in the inventory logic
2. sql node mode also not pass cluster_name to ms, so in cloud use sql
`ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster
name
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@deardeng @koarz
[fix](cloud) Add check for cluster_name empty in cloud (apache#49775)
811b56f
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@deardeng @koarz
[fix](cloud) Some resource APIs should not check if cluster_name is e…
354b98d 
…mpty (apache#50148)

due to apache#49775

but some api cant check cluster name, 
1. Cloud Management The request may not have passed in the cluster_name
in the inventory logic
2. sql node mode also not pass cluster_name to ms, so in cloud use sql
`ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster
name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deardeng @hello-stephen @doris-robot @gavinchou @dataroaring