Skip to content

Conversation

@deardeng
Copy link
Contributor

What problem does this PR solve?

due to #49775

but some api cant check cluster name,

  1. Cloud Management The request may not have passed in the cluster_name in the inventory logic
  2. sql node mode also not pass cluster_name to ms, so in cloud use sql ALTER SYSTEM ADD BACKEND ip:host will return err, not have cluster name

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1089/1312)
Line Coverage: 66.12% (18184/27500)
Region Coverage: 65.57% (8962/13668)
Branch Coverage: 55.44% (4832/8716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/75a28d6097b66bd27a96242784561db8f574570f_75a28d6097b66bd27a96242784561db8f574570f_cloud/report/index.html

dataroaring
dataroaring previously approved these changes Apr 21, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 21, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 21, 2025
@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.93% (1093/1318)
Line Coverage: 65.66% (18263/27814)
Region Coverage: 65.07% (9047/13904)
Branch Coverage: 55.08% (4875/8850)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f46444949770ccc8ab4e92430be9c2485c419448_f46444949770ccc8ab4e92430be9c2485c419448_cloud/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 21, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou changed the title [fix](cloud) Some APIs cannot check if cluster_name is empty [fix](cloud) Some APIs should not check if cluster_name is empty Apr 22, 2025
@gavinchou gavinchou changed the title [fix](cloud) Some APIs should not check if cluster_name is empty [fix](cloud) Some resource APIs should not check if cluster_name is empty Apr 22, 2025
@gavinchou gavinchou merged commit 6aa9a33 into apache:master Apr 22, 2025
28 of 29 checks passed
deardeng added a commit to deardeng/incubator-doris that referenced this pull request May 19, 2025
…mpty (apache#50148)

due to apache#49775

but some api cant check cluster name, 
1. Cloud Management The request may not have passed in the cluster_name
in the inventory logic
2. sql node mode also not pass cluster_name to ms, so in cloud use sql
`ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster
name
dataroaring pushed a commit that referenced this pull request May 20, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…mpty (apache#50148)

due to apache#49775

but some api cant check cluster name, 
1. Cloud Management The request may not have passed in the cluster_name
in the inventory logic
2. sql node mode also not pass cluster_name to ms, so in cloud use sql
`ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster
name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants