-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](cloud) Some resource APIs should not check if cluster_name is empty #50148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
TeamCity cloud ut coverage result: |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
TeamCity cloud ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…mpty (apache#50148) due to apache#49775 but some api cant check cluster name, 1. Cloud Management The request may not have passed in the cluster_name in the inventory logic 2. sql node mode also not pass cluster_name to ms, so in cloud use sql `ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster name
…mpty (apache#50148) due to apache#49775 but some api cant check cluster name, 1. Cloud Management The request may not have passed in the cluster_name in the inventory logic 2. sql node mode also not pass cluster_name to ms, so in cloud use sql `ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster name
What problem does this PR solve?
due to #49775
but some api cant check cluster name,
ALTER SYSTEM ADD BACKEND ip:hostwill return err, not have cluster nameIssue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)