Skip to content

branch-3.0: [fix](cloud) Some resource APIs should not check if cluster_name is empty #50148 #51046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
May 20, 2025
Merged

branch-3.0: [fix](cloud) Some resource APIs should not check if cluster_name is empty #50148 #51046

dataroaring merged 1 commit into from
May 20, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented May 19, 2025

cherry pick from #50148

@deardeng
[fix](cloud) Some resource APIs should not check if cluster_name is e…
cb3e2b7 
…mpty (apache#50148)

due to apache#49775

but some api cant check cluster name, 
1. Cloud Management The request may not have passed in the cluster_name
in the inventory logic
2. sql node mode also not pass cluster_name to ms, so in cloud use sql
`ALTER SYSTEM ADD BACKEND ip:host` will return err, not have cluster
name
@deardeng deardeng requested a review from dataroaring as a code owner May 19, 2025 12:39
@deardeng
Copy link
Contributor Author

deardeng commented May 19, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented May 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented May 19, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.13% (1094/1316)
Line Coverage 66.19% (18162/27438)
Region Coverage 65.93% (8993/13641)
Branch Coverage 55.66% (4855/8722)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit aa67fd8 into apache:branch-3.0 May 20, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deardeng @hello-stephen @doris-robot @gavinchou @dataroaring