Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Apr 21, 2025

What problem does this PR solve?

No need to forward show table stats command. Forwarding to master is to make sure regression case can pass. But it is not the right way. Because forward to master makes it impossible to get Observer's table stats. After this change, we should fix the case if it depends on forward.
Previous pr that forward show table stats to master:
#48189

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review April 21, 2025 02:10
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33711 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f01ad06c6280540d1dd4f7a8bcedd85a7cd68dba, data reload: false

------ Round 1 ----------------------------------
q1	25783	4959	4933	4933
q2	2041	275	192	192
q3	10384	1255	686	686
q4	10217	997	514	514
q5	7499	2323	2344	2323
q6	181	160	133	133
q7	933	740	606	606
q8	9314	1214	1127	1127
q9	7029	5098	5141	5098
q10	6847	2310	1884	1884
q11	473	272	280	272
q12	347	357	213	213
q13	17785	3626	3056	3056
q14	229	236	218	218
q15	541	502	482	482
q16	441	443	399	399
q17	582	851	363	363
q18	7428	7092	7129	7092
q19	1346	948	542	542
q20	333	324	218	218
q21	3924	3335	2391	2391
q22	1061	1033	969	969
Total cold run time: 114718 ms
Total hot run time: 33711 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5115	5084	5040	5040
q2	244	333	232	232
q3	2126	2625	2279	2279
q4	1427	1835	1354	1354
q5	4435	4419	4487	4419
q6	217	170	130	130
q7	2027	1949	1802	1802
q8	2611	2542	2549	2542
q9	7357	7364	7197	7197
q10	2975	3165	2718	2718
q11	586	500	508	500
q12	691	758	609	609
q13	3509	4189	3289	3289
q14	304	297	296	296
q15	529	490	472	472
q16	473	497	456	456
q17	1150	1593	1335	1335
q18	7729	7535	7380	7380
q19	802	745	812	745
q20	2035	1958	1837	1837
q21	5235	4892	4770	4770
q22	1136	1113	1026	1026
Total cold run time: 52713 ms
Total hot run time: 50428 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192417 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f01ad06c6280540d1dd4f7a8bcedd85a7cd68dba, data reload: false

query1	1404	1081	1038	1038
query2	6465	1762	1744	1744
query3	11144	4585	4635	4585
query4	53978	24570	23328	23328
query5	5085	571	447	447
query6	341	192	179	179
query7	4870	505	280	280
query8	312	255	233	233
query9	5287	2567	2545	2545
query10	415	317	254	254
query11	15206	14957	14910	14910
query12	157	103	99	99
query13	1014	500	384	384
query14	10034	6302	6334	6302
query15	203	200	175	175
query16	7090	637	469	469
query17	1063	709	573	573
query18	1561	416	316	316
query19	198	187	159	159
query20	127	122	126	122
query21	202	129	112	112
query22	4398	4565	4453	4453
query23	34117	33560	33445	33445
query24	6585	2431	2457	2431
query25	488	480	426	426
query26	691	272	159	159
query27	2234	500	333	333
query28	2931	2140	2111	2111
query29	619	561	429	429
query30	263	214	193	193
query31	876	864	777	777
query32	77	62	65	62
query33	466	363	307	307
query34	766	859	519	519
query35	785	829	760	760
query36	942	1000	891	891
query37	115	105	78	78
query38	4112	4303	4219	4219
query39	1494	1435	1502	1435
query40	212	126	109	109
query41	56	54	51	51
query42	120	108	106	106
query43	479	492	473	473
query44	1321	809	800	800
query45	179	176	171	171
query46	818	1015	659	659
query47	1876	1854	1808	1808
query48	381	424	306	306
query49	658	515	407	407
query50	663	693	411	411
query51	4298	4318	4333	4318
query52	106	109	103	103
query53	234	269	198	198
query54	587	575	504	504
query55	79	81	89	81
query56	337	304	276	276
query57	1211	1164	1119	1119
query58	273	286	272	272
query59	2745	2781	2711	2711
query60	327	317	312	312
query61	133	129	150	129
query62	714	751	687	687
query63	233	194	185	185
query64	1729	1020	694	694
query65	4361	4246	4226	4226
query66	756	397	300	300
query67	15704	15468	15462	15462
query68	7701	871	509	509
query69	528	291	267	267
query70	1225	1100	1097	1097
query71	496	300	297	297
query72	5766	4754	4662	4662
query73	1459	579	340	340
query74	8934	9220	8680	8680
query75	3975	3199	2668	2668
query76	4339	1182	742	742
query77	693	367	290	290
query78	9987	10232	9386	9386
query79	2026	793	557	557
query80	566	503	434	434
query81	468	251	220	220
query82	443	124	97	97
query83	248	250	235	235
query84	300	105	85	85
query85	788	359	304	304
query86	355	307	294	294
query87	4368	4293	4267	4267
query88	3355	2202	2170	2170
query89	404	316	282	282
query90	1976	210	206	206
query91	144	217	113	113
query92	74	57	60	57
query93	1111	926	585	585
query94	670	427	306	306
query95	366	289	280	280
query96	479	553	271	271
query97	3116	3202	3116	3116
query98	235	209	193	193
query99	1685	1433	1247	1247
Total cold run time: 296985 ms
Total hot run time: 192417 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.18 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f01ad06c6280540d1dd4f7a8bcedd85a7cd68dba, data reload: false

query1	0.04	0.03	0.03
query2	0.13	0.10	0.12
query3	0.26	0.20	0.19
query4	1.61	0.19	0.19
query5	0.59	0.60	0.59
query6	1.19	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.50
query10	0.56	0.56	0.57
query11	0.16	0.10	0.11
query12	0.15	0.12	0.11
query13	0.61	0.60	0.60
query14	1.15	1.15	1.15
query15	0.87	0.85	0.86
query16	0.40	0.40	0.37
query17	1.03	1.00	1.09
query18	0.22	0.20	0.20
query19	1.90	1.80	1.81
query20	0.02	0.01	0.01
query21	15.40	0.93	0.55
query22	0.77	1.16	0.77
query23	14.77	1.37	0.61
query24	7.01	2.15	0.38
query25	0.34	0.14	0.15
query26	0.68	0.17	0.13
query27	0.05	0.06	0.04
query28	9.57	0.86	0.42
query29	12.55	4.02	3.32
query30	0.26	0.09	0.07
query31	2.81	0.58	0.39
query32	3.22	0.55	0.46
query33	3.03	2.97	3.01
query34	15.73	5.15	4.50
query35	4.58	4.57	4.51
query36	0.67	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.15	0.13
query41	0.07	0.02	0.02
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 103.44 s
Total hot run time: 29.18 s

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add realted PR

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 21, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@Jibing-Li Jibing-Li merged commit 66b8e8d into apache:master Apr 21, 2025
29 of 30 checks passed
@Jibing-Li Jibing-Li deleted the forward branch April 21, 2025 06:53
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Apr 21, 2025
…#50207)

No need to forward show table stats command. Forwarding to master is to
make sure regression case can pass. But it is not the right way. Because
forward to master makes it impossible to get Observer's table stats.
After this change, we should fix the case if it depends on forward.
Previous pr that forward show table stats to master:
apache#48189
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…#50207)

### What problem does this PR solve?

No need to forward show table stats command. Forwarding to master is to
make sure regression case can pass. But it is not the right way. Because
forward to master makes it impossible to get Observer's table stats.
After this change, we should fix the case if it depends on forward.
Previous pr that forward show table stats to master:
apache#48189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants