Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

backport: #50207

…#50207)

No need to forward show table stats command. Forwarding to master is to
make sure regression case can pass. But it is not the right way. Because
forward to master makes it impossible to get Observer's table stats.
After this change, we should fix the case if it depends on forward.
Previous pr that forward show table stats to master:
apache#48189
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review April 21, 2025 07:07
@Jibing-Li Jibing-Li requested a review from dataroaring as a code owner April 21, 2025 07:07
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39990 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d914d3c376f3751b0ad6b1fa08a4ada074167040, data reload: false

------ Round 1 ----------------------------------
q1	17705	7391	6719	6719
q2	2120	164	175	164
q3	11752	1153	1193	1153
q4	10537	802	710	710
q5	7719	2825	2858	2825
q6	219	133	131	131
q7	980	612	601	601
q8	9378	1939	1998	1939
q9	6639	6379	6358	6358
q10	6982	2266	2247	2247
q11	453	277	254	254
q12	403	213	209	209
q13	17780	2983	2990	2983
q14	234	218	212	212
q15	524	474	472	472
q16	654	575	577	575
q17	971	544	593	544
q18	7441	6578	6614	6578
q19	1400	1136	1078	1078
q20	488	198	202	198
q21	4003	3281	3060	3060
q22	1119	985	980	980
Total cold run time: 109501 ms
Total hot run time: 39990 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6693	6590	6626	6590
q2	326	229	228	228
q3	2882	2855	3000	2855
q4	2042	1817	1775	1775
q5	5728	5721	5722	5721
q6	205	129	126	126
q7	2227	1828	1816	1816
q8	3377	3547	3481	3481
q9	8781	8861	8912	8861
q10	3593	3586	3568	3568
q11	586	496	492	492
q12	797	621	633	621
q13	7423	3149	3244	3149
q14	299	279	274	274
q15	506	466	468	466
q16	678	651	638	638
q17	1807	1619	1613	1613
q18	8346	7720	7843	7720
q19	1666	1688	1624	1624
q20	2089	1829	1887	1829
q21	5689	5147	5150	5147
q22	1110	1030	992	992
Total cold run time: 66850 ms
Total hot run time: 59586 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189362 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d914d3c376f3751b0ad6b1fa08a4ada074167040, data reload: false

query1	978	374	356	356
query2	6517	2011	1936	1936
query3	6710	218	217	217
query4	33904	23343	23465	23343
query5	4321	473	421	421
query6	277	169	171	169
query7	4775	314	308	308
query8	269	224	210	210
query9	9596	2609	2595	2595
query10	484	267	252	252
query11	18366	15133	15153	15133
query12	143	100	101	100
query13	1648	422	419	419
query14	9618	7060	6570	6570
query15	256	169	179	169
query16	8069	489	464	464
query17	1628	574	558	558
query18	2112	314	316	314
query19	231	177	157	157
query20	117	119	109	109
query21	210	102	100	100
query22	4489	4293	4238	4238
query23	34222	33327	33239	33239
query24	11281	2762	2788	2762
query25	692	380	394	380
query26	1501	164	168	164
query27	2976	344	341	341
query28	8088	2426	2378	2378
query29	959	431	416	416
query30	322	162	168	162
query31	1031	776	813	776
query32	98	56	59	56
query33	771	282	286	282
query34	995	495	501	495
query35	862	717	691	691
query36	1099	927	945	927
query37	129	65	65	65
query38	3962	3789	3817	3789
query39	1499	1406	1460	1406
query40	284	98	98	98
query41	51	49	47	47
query42	109	98	96	96
query43	518	487	476	476
query44	1198	788	783	783
query45	184	166	164	164
query46	1147	700	719	700
query47	1911	1814	1870	1814
query48	471	379	377	377
query49	1207	388	380	380
query50	820	419	425	419
query51	7270	7103	7058	7058
query52	106	85	92	85
query53	254	182	180	180
query54	1300	466	471	466
query55	85	75	78	75
query56	272	252	248	248
query57	1219	1122	1088	1088
query58	236	211	227	211
query59	2998	2928	2798	2798
query60	306	270	268	268
query61	138	133	134	133
query62	897	680	681	680
query63	218	189	195	189
query64	5546	762	741	741
query65	3283	3211	3190	3190
query66	1455	335	330	330
query67	15738	15711	15531	15531
query68	4569	574	583	574
query69	457	284	287	284
query70	1162	1063	1114	1063
query71	347	258	262	258
query72	6607	4260	3933	3933
query73	737	353	351	351
query74	10283	8922	9016	8922
query75	3361	2638	2646	2638
query76	2928	1140	1058	1058
query77	415	264	265	264
query78	10387	9637	9566	9566
query79	2393	604	606	604
query80	1112	427	417	417
query81	542	237	240	237
query82	944	90	89	89
query83	214	144	146	144
query84	239	77	80	77
query85	1342	306	297	297
query86	424	311	297	297
query87	4378	4168	4268	4168
query88	4367	2382	2376	2376
query89	402	292	295	292
query90	2024	183	182	182
query91	188	151	149	149
query92	66	51	54	51
query93	1495	567	554	554
query94	925	298	296	296
query95	360	250	252	250
query96	611	281	288	281
query97	3278	3146	3132	3132
query98	219	204	193	193
query99	1514	1278	1273	1273
Total cold run time: 302716 ms
Total hot run time: 189362 ms

@Jibing-Li
Copy link
Contributor Author

run feut

@doris-robot
Copy link

ClickBench: Total hot run time: 31.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d914d3c376f3751b0ad6b1fa08a4ada074167040, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.23	0.06	0.07
query4	1.62	0.10	0.10
query5	0.50	0.51	0.53
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.03	0.03	0.05
query9	0.56	0.50	0.50
query10	0.56	0.55	0.55
query11	0.15	0.10	0.10
query12	0.14	0.12	0.11
query13	0.60	0.58	0.60
query14	2.84	2.84	2.73
query15	0.90	0.84	0.83
query16	0.38	0.39	0.38
query17	1.03	1.00	0.97
query18	0.24	0.22	0.21
query19	1.97	1.87	2.00
query20	0.01	0.01	0.01
query21	15.36	0.61	0.60
query22	2.93	2.73	1.40
query23	17.13	1.07	0.87
query24	3.36	0.56	1.11
query25	0.12	0.21	0.16
query26	0.44	0.14	0.13
query27	0.05	0.06	0.04
query28	10.54	0.49	0.50
query29	12.57	3.22	3.26
query30	0.24	0.07	0.06
query31	2.86	0.38	0.39
query32	3.22	0.47	0.45
query33	2.97	2.98	3.06
query34	16.86	4.45	4.51
query35	4.53	4.58	4.48
query36	0.68	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.36 s
Total hot run time: 31.37 s

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

1 similar comment
@Jibing-Li
Copy link
Contributor Author

run cloud_p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit b6de049 into apache:branch-3.0 Apr 22, 2025
23 of 24 checks passed
@Jibing-Li Jibing-Li deleted the forward3.0 branch April 24, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants