-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](refactor-param) refactor outfile's code about fileformat #50471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CalvinKirs
merged 3 commits into
apache:master
from
BePPPower:refactorOutfileFileFormat2
Apr 29, 2025
Merged
[feat](refactor-param) refactor outfile's code about fileformat #50471
CalvinKirs
merged 3 commits into
apache:master
from
BePPPower:refactorOutfileFileFormat2
Apr 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33953 ms |
TPC-DS: Total hot run time: 192512 ms |
ClickBench: Total hot run time: 30.07 s |
morningman
reviewed
Apr 28, 2025
...c/main/java/org/apache/doris/datasource/property/fileformat/ParquetFileFormatProperties.java
Show resolved
Hide resolved
...e/src/main/java/org/apache/doris/datasource/property/fileformat/OrcFileFormatProperties.java
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33628 ms |
TPC-DS: Total hot run time: 192378 ms |
ClickBench: Total hot run time: 29.22 s |
Contributor
Author
|
run cloud_p0 |
morningman
approved these changes
Apr 29, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Apr 29, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…he#50471) Issue Number: apache#50238 Problem Summary: Previously, we refactored the code of the fileFormat attribute (apache#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the `SELECT INTO OUTFILE` feature that is related to the fileformat.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 21, 2025
…he#50471) Issue Number: apache#50238 Problem Summary: Previously, we refactored the code of the fileFormat attribute (apache#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the `SELECT INTO OUTFILE` feature that is related to the fileformat.
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
Oct 27, 2025
### What problem does this PR solve? introduced by #50471 Fix copy into load orc/parquet format fail: ``` mysql> copy into orc_test from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') ) properties ('file.type' = 'orc', 'copy.async' = 'false'); ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
dwdwqfwe
pushed a commit
to dwdwqfwe/doris
that referenced
this pull request
Oct 31, 2025
### What problem does this PR solve? introduced by apache#50471 Fix copy into load orc/parquet format fail: ``` mysql> copy into orc_test from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') ) properties ('file.type' = 'orc', 'copy.async' = 'false'); ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
sollhui
added a commit
to sollhui/doris
that referenced
this pull request
Dec 1, 2025
introduced by apache#50471 Fix copy into load orc/parquet format fail: ``` mysql> copy into orc_test from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') ) properties ('file.type' = 'orc', 'copy.async' = 'false'); ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null ``` None - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
sollhui
added a commit
to sollhui/doris
that referenced
this pull request
Dec 1, 2025
introduced by apache#50471 Fix copy into load orc/parquet format fail: ``` mysql> copy into orc_test from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') ) properties ('file.type' = 'orc', 'copy.async' = 'false'); ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null ``` None - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This was referenced Dec 1, 2025
sollhui
added a commit
to sollhui/doris
that referenced
this pull request
Dec 1, 2025
introduced by apache#50471 Fix copy into load orc/parquet format fail: ``` mysql> copy into orc_test from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') ) properties ('file.type' = 'orc', 'copy.async' = 'false'); ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null ``` None - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
yiguolei
pushed a commit
that referenced
this pull request
Dec 2, 2025
…#57362) (#58552) pick #57362 introduced by #50471 Fix copy into load orc/parquet format fail: ``` mysql> copy into orc_test from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') ) properties ('file.type' = 'orc', 'copy.async' = 'false'); ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null ``` None - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #50238
Problem Summary:
Previously, we refactored the code of the fileFormat attribute (#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the
SELECT INTO OUTFILEfeature that is related to the fileformat.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)