Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Oct 27, 2025

What problem does this PR solve?

introduced by #50471

Fix copy into load orc/parquet format fail:

mysql> copy into orc_test              from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') )              properties ('file.type' = 'orc', 'copy.async' = 'false');
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui
Copy link
Contributor Author

sollhui commented Oct 27, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 27.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 54bc373b4631c46340d8f97eafb042ac6a2986c7, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.12	0.12
query5	0.28	0.27	0.25
query6	1.17	0.64	0.64
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.63	0.53	0.53
query10	0.59	0.58	0.60
query11	0.16	0.10	0.11
query12	0.16	0.12	0.13
query13	0.63	0.61	0.60
query14	1.03	1.01	1.01
query15	0.85	0.83	0.84
query16	0.40	0.41	0.40
query17	1.04	1.06	1.04
query18	0.22	0.21	0.20
query19	1.90	1.80	1.82
query20	0.01	0.02	0.01
query21	15.45	0.18	0.13
query22	5.17	0.08	0.05
query23	15.65	0.27	0.11
query24	2.50	1.07	0.42
query25	0.09	0.06	0.05
query26	0.15	0.13	0.13
query27	0.08	0.05	0.05
query28	4.84	1.13	0.93
query29	12.56	3.97	3.31
query30	0.29	0.14	0.11
query31	2.83	0.59	0.39
query32	3.23	0.55	0.47
query33	2.99	3.03	3.02
query34	15.85	5.15	4.57
query35	4.60	4.54	4.63
query36	0.65	0.50	0.50
query37	0.10	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.04	0.03
query40	0.17	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 98.65 s
Total hot run time: 27.63 s

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 27, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 33.33% (1/3) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit fba8f6a into apache:master Oct 27, 2025
30 checks passed
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
### What problem does this PR solve?

introduced by apache#50471

Fix copy into load orc/parquet format fail:
```
mysql> copy into orc_test              from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') )              properties ('file.type' = 'orc', 'copy.async' = 'false');
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null
```

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
sollhui added a commit to sollhui/doris that referenced this pull request Dec 1, 2025
introduced by apache#50471

Fix copy into load orc/parquet format fail:
```
mysql> copy into orc_test              from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') )              properties ('file.type' = 'orc', 'copy.async' = 'false');
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null
```

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
sollhui added a commit to sollhui/doris that referenced this pull request Dec 1, 2025
introduced by apache#50471

Fix copy into load orc/parquet format fail:
```
mysql> copy into orc_test              from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') )              properties ('file.type' = 'orc', 'copy.async' = 'false');
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null
```

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
sollhui added a commit to sollhui/doris that referenced this pull request Dec 1, 2025
introduced by apache#50471

Fix copy into load orc/parquet format fail:
```
mysql> copy into orc_test              from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') )              properties ('file.type' = 'orc', 'copy.async' = 'false');
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null
```

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Dec 2, 2025
…#57362) (#58552)

pick #57362

introduced by #50471

Fix copy into load orc/parquet format fail:
```
mysql> copy into orc_test              from (select p_partkey, p_name, p_mfgr, p_brand, p_type, p_size from @regression_test_customer('copy_into/orc/part.orc') )              properties ('file.type' = 'orc', 'copy.async' = 'false');
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.toLowerCase()" because the return value of "java.util.Map.get(Object)" is null
```

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change. - [ ] No code files have been
changed. - [ ] Other reason <!-- Add your reason? -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants