Skip to content

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented May 27, 2025

What problem does this PR solve?

complete: #49317

Co-Author: DongLiang-0

Issue Number: close #48892

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented May 27, 2025

run buildall

@koarz koarz marked this pull request as draft May 27, 2025 07:31
@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.12% (18663/28224)
Region Coverage 65.79% (9262/14079)
Branch Coverage 55.55% (4981/8966)

@doris-robot
Copy link

TPC-H: Total hot run time: 34079 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 31f732ee69d304590ffab5db8e4c39538bedb8b2, data reload: false

------ Round 1 ----------------------------------
q1	26605	5026	5024	5024
q2	2079	302	194	194
q3	10496	1243	704	704
q4	10232	1010	541	541
q5	7701	2387	2350	2350
q6	189	165	132	132
q7	896	728	616	616
q8	9306	1252	1080	1080
q9	6808	5148	5127	5127
q10	6871	2320	1900	1900
q11	502	295	271	271
q12	353	352	221	221
q13	17802	3710	3146	3146
q14	228	237	213	213
q15	529	491	482	482
q16	426	436	370	370
q17	611	869	358	358
q18	8030	7103	7163	7103
q19	1702	954	589	589
q20	339	344	231	231
q21	3954	3230	2433	2433
q22	1055	1021	994	994
Total cold run time: 116714 ms
Total hot run time: 34079 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5228	5073	5135	5073
q2	236	332	234	234
q3	2157	2642	2268	2268
q4	1439	1785	1493	1493
q5	4569	4381	4327	4327
q6	210	169	126	126
q7	1975	1912	1782	1782
q8	2572	2529	2426	2426
q9	7268	7227	7132	7132
q10	2983	3169	2712	2712
q11	578	516	498	498
q12	706	734	624	624
q13	3478	3915	3308	3308
q14	279	307	266	266
q15	521	465	477	465
q16	455	498	444	444
q17	1236	1548	1377	1377
q18	7774	7518	7368	7368
q19	813	827	862	827
q20	2000	2045	1890	1890
q21	4832	4363	4285	4285
q22	1095	1030	994	994
Total cold run time: 52404 ms
Total hot run time: 49919 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186687 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 31f732ee69d304590ffab5db8e4c39538bedb8b2, data reload: false

query1	998	471	507	471
query2	6554	1857	1898	1857
query3	6744	228	218	218
query4	26252	23324	23309	23309
query5	4367	648	493	493
query6	321	213	204	204
query7	4635	512	291	291
query8	323	259	247	247
query9	8601	2595	2599	2595
query10	471	332	287	287
query11	15193	15022	14870	14870
query12	158	115	104	104
query13	1660	513	424	424
query14	8773	6263	6458	6263
query15	214	205	170	170
query16	7328	629	505	505
query17	1224	714	598	598
query18	1982	408	310	310
query19	197	196	171	171
query20	123	117	117	117
query21	220	139	108	108
query22	4096	4082	4052	4052
query23	34310	33055	33222	33055
query24	8401	2398	2455	2398
query25	565	478	396	396
query26	1237	264	151	151
query27	2749	494	338	338
query28	4335	2100	2088	2088
query29	790	551	433	433
query30	279	220	190	190
query31	932	869	771	771
query32	72	65	66	65
query33	559	372	326	326
query34	811	867	528	528
query35	778	808	713	713
query36	942	982	900	900
query37	110	102	77	77
query38	4116	4083	4125	4083
query39	1482	1414	1417	1414
query40	215	120	105	105
query41	58	55	52	52
query42	124	108	120	108
query43	492	524	483	483
query44	1291	796	807	796
query45	184	173	172	172
query46	825	1020	637	637
query47	1745	1783	1726	1726
query48	379	420	305	305
query49	782	509	460	460
query50	646	690	397	397
query51	4147	4179	4116	4116
query52	108	104	97	97
query53	222	247	186	186
query54	602	581	508	508
query55	85	88	87	87
query56	300	309	290	290
query57	1145	1134	1085	1085
query58	269	253	255	253
query59	2676	2760	2623	2623
query60	334	323	305	305
query61	127	127	127	127
query62	812	732	650	650
query63	224	217	191	191
query64	4389	1009	682	682
query65	4302	4256	4215	4215
query66	1178	408	317	317
query67	15697	15664	15654	15654
query68	8703	881	518	518
query69	479	299	273	273
query70	1185	1148	1088	1088
query71	455	325	309	309
query72	5666	4828	4777	4777
query73	709	645	357	357
query74	9210	9126	9002	9002
query75	4060	3183	2658	2658
query76	3617	1197	749	749
query77	783	368	300	300
query78	10001	10285	9355	9355
query79	1914	830	572	572
query80	683	558	481	481
query81	472	253	227	227
query82	446	132	104	104
query83	276	269	233	233
query84	260	108	87	87
query85	786	364	320	320
query86	337	304	295	295
query87	4371	4444	4238	4238
query88	3453	2261	2262	2261
query89	441	314	303	303
query90	1929	216	219	216
query91	154	171	111	111
query92	77	67	56	56
query93	1186	940	577	577
query94	678	428	309	309
query95	386	295	281	281
query96	498	554	292	292
query97	2694	2728	2657	2657
query98	234	217	207	207
query99	1443	1394	1257	1257
Total cold run time: 273846 ms
Total hot run time: 186687 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 31f732ee69d304590ffab5db8e4c39538bedb8b2, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.10
query3	0.26	0.20	0.20
query4	1.59	0.20	0.11
query5	0.43	0.42	0.43
query6	1.15	0.65	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.52	0.52
query10	0.58	0.57	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.61	0.60
query14	0.80	0.81	0.81
query15	0.88	0.88	0.86
query16	0.39	0.38	0.39
query17	1.04	1.02	1.02
query18	0.22	0.22	0.21
query19	1.92	1.79	1.92
query20	0.02	0.01	0.01
query21	15.40	0.93	0.56
query22	0.74	1.24	0.77
query23	14.79	1.45	0.60
query24	7.10	0.98	0.99
query25	0.46	0.22	0.12
query26	0.66	0.18	0.13
query27	0.05	0.04	0.05
query28	8.76	0.94	0.45
query29	12.56	3.96	3.28
query30	0.25	0.09	0.07
query31	2.83	0.61	0.40
query32	3.24	0.56	0.48
query33	3.07	3.06	3.07
query34	15.75	5.15	4.54
query35	4.57	4.52	4.52
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.09	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 102.44 s
Total hot run time: 29.36 s

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.12% (18663/28224)
Region Coverage 65.73% (9254/14079)
Branch Coverage 55.59% (4984/8966)

@koarz
Copy link
Contributor Author

koarz commented May 27, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.15% (18669/28224)
Region Coverage 65.76% (9259/14079)
Branch Coverage 55.58% (4983/8966)

@doris-robot
Copy link

TPC-H: Total hot run time: 34975 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 943d1b6e753ef9ea3d4df1f8b4b68535b73c2c87, data reload: false

------ Round 1 ----------------------------------
q1	26403	5143	5050	5050
q2	2063	282	193	193
q3	10387	1308	730	730
q4	10228	1031	517	517
q5	7545	2449	2350	2350
q6	192	167	139	139
q7	915	754	613	613
q8	9298	1314	1138	1138
q9	6781	5129	5185	5129
q10	6903	2333	1909	1909
q11	499	302	275	275
q12	355	365	222	222
q13	17776	3753	3197	3197
q14	245	238	221	221
q15	523	489	487	487
q16	438	436	393	393
q17	627	881	401	401
q18	7647	7289	7188	7188
q19	1832	972	574	574
q20	346	358	228	228
q21	4248	3330	3052	3052
q22	1055	1015	969	969
Total cold run time: 116306 ms
Total hot run time: 34975 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5303	5132	5336	5132
q2	248	332	246	246
q3	2148	2633	2267	2267
q4	1392	1989	1434	1434
q5	4547	4456	4419	4419
q6	236	176	140	140
q7	2037	1969	1748	1748
q8	2637	2676	2634	2634
q9	7227	6984	7139	6984
q10	3029	3188	2746	2746
q11	590	528	485	485
q12	655	787	574	574
q13	3610	3985	3454	3454
q14	300	290	263	263
q15	520	482	479	479
q16	470	492	471	471
q17	1170	1609	1393	1393
q18	7764	7490	7452	7452
q19	873	856	892	856
q20	1991	2016	1820	1820
q21	5055	4699	4609	4609
q22	1149	1078	1033	1033
Total cold run time: 52951 ms
Total hot run time: 50639 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193813 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 943d1b6e753ef9ea3d4df1f8b4b68535b73c2c87, data reload: false

query1	1416	1104	1057	1057
query2	6317	1830	1815	1815
query3	11075	4674	4349	4349
query4	51883	25609	23231	23231
query5	5101	616	471	471
query6	354	228	231	228
query7	4888	528	293	293
query8	304	249	230	230
query9	5365	2658	2648	2648
query10	435	330	270	270
query11	15105	14984	14941	14941
query12	172	111	103	103
query13	1020	525	426	426
query14	10305	6626	6445	6445
query15	196	190	178	178
query16	7084	693	488	488
query17	1090	746	596	596
query18	1538	389	314	314
query19	194	193	169	169
query20	138	123	121	121
query21	204	126	112	112
query22	4370	4404	4302	4302
query23	34706	33654	33744	33654
query24	6714	2490	2532	2490
query25	482	476	433	433
query26	679	279	159	159
query27	2176	531	357	357
query28	3079	2176	2164	2164
query29	616	609	473	473
query30	272	216	193	193
query31	911	880	810	810
query32	80	71	73	71
query33	480	385	334	334
query34	821	887	568	568
query35	828	859	748	748
query36	961	995	907	907
query37	123	108	83	83
query38	4322	4327	4242	4242
query39	1541	1486	1460	1460
query40	220	136	118	118
query41	64	64	61	61
query42	128	114	115	114
query43	560	513	491	491
query44	1398	841	830	830
query45	189	187	175	175
query46	889	1057	668	668
query47	1817	1834	1776	1776
query48	399	448	337	337
query49	702	518	446	446
query50	725	721	419	419
query51	4272	4297	4270	4270
query52	115	110	101	101
query53	243	270	193	193
query54	599	585	554	554
query55	89	88	86	86
query56	336	382	309	309
query57	1194	1196	1158	1158
query58	271	277	269	269
query59	2621	2751	2723	2723
query60	358	346	334	334
query61	133	127	134	127
query62	735	762	711	711
query63	247	206	202	202
query64	1450	1047	684	684
query65	4346	4234	4252	4234
query66	751	405	308	308
query67	15975	15556	15721	15556
query68	7137	912	517	517
query69	538	307	263	263
query70	1219	1157	1122	1122
query71	494	324	299	299
query72	5803	4858	4889	4858
query73	1440	672	351	351
query74	9196	9198	8787	8787
query75	4069	3212	2707	2707
query76	4151	1216	801	801
query77	752	379	287	287
query78	10137	10203	9354	9354
query79	2631	793	579	579
query80	671	528	451	451
query81	500	253	230	230
query82	447	133	95	95
query83	300	257	244	244
query84	283	107	82	82
query85	791	363	321	321
query86	368	312	287	287
query87	4392	4459	4427	4427
query88	3887	2296	2306	2296
query89	408	327	296	296
query90	1929	218	219	218
query91	141	146	115	115
query92	75	63	58	58
query93	1689	946	590	590
query94	663	402	321	321
query95	381	302	287	287
query96	505	574	284	284
query97	2717	2762	2633	2633
query98	236	225	202	202
query99	1440	1420	1264	1264
Total cold run time: 297561 ms
Total hot run time: 193813 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 943d1b6e753ef9ea3d4df1f8b4b68535b73c2c87, data reload: false

query1	0.04	0.04	0.03
query2	0.15	0.10	0.10
query3	0.34	0.20	0.20
query4	1.59	0.20	0.11
query5	0.41	0.42	0.40
query6	1.16	0.66	0.66
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.63	0.53	0.53
query10	0.57	0.58	0.58
query11	0.25	0.13	0.13
query12	0.26	0.13	0.13
query13	0.64	0.62	0.61
query14	0.80	0.82	0.85
query15	0.98	0.89	0.87
query16	0.37	0.38	0.38
query17	1.07	1.06	1.10
query18	0.19	0.18	0.17
query19	2.02	1.80	1.85
query20	0.01	0.01	0.02
query21	15.42	0.99	0.68
query22	0.93	1.01	0.79
query23	14.69	1.53	0.77
query24	5.57	0.58	0.27
query25	0.17	0.09	0.08
query26	0.56	0.22	0.19
query27	0.09	0.09	0.09
query28	10.97	1.18	0.58
query29	12.54	4.03	3.42
query30	0.30	0.09	0.07
query31	2.82	0.62	0.43
query32	3.23	0.60	0.51
query33	3.16	3.14	3.04
query34	16.30	5.15	4.38
query35	4.50	4.48	4.45
query36	0.63	0.51	0.50
query37	0.19	0.18	0.17
query38	0.17	0.16	0.16
query39	0.05	0.04	0.05
query40	0.19	0.16	0.16
query41	0.11	0.05	0.05
query42	0.06	0.05	0.04
query43	0.05	0.05	0.05
Total cold run time: 104.25 s
Total hot run time: 29.56 s

@koarz
Copy link
Contributor Author

koarz commented May 28, 2025

run feut

@koarz
Copy link
Contributor Author

koarz commented May 28, 2025

run vault_p0

@koarz
Copy link
Contributor Author

koarz commented May 28, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.18% (18680/28224)
Region Coverage 65.79% (9263/14079)
Branch Coverage 55.62% (4987/8966)

@koarz
Copy link
Contributor Author

koarz commented Jun 6, 2025

run beut

1 similar comment
@koarz
Copy link
Contributor Author

koarz commented Jun 6, 2025

run beut

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koarz
Copy link
Contributor Author

koarz commented Jun 9, 2025

run beut

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.65% (1/153) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.36% (15069/26738)
Line Coverage 45.13% (134666/298367)
Region Coverage 44.24% (67761/153152)
Branch Coverage 38.80% (34741/89528)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 79.08% (121/153) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.57% (21008/26402)
Line Coverage 72.64% (217061/298828)
Region Coverage 70.88% (127833/180349)
Branch Coverage 64.58% (66195/102500)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 91c8cdc into apache:master Jun 17, 2025
27 of 30 checks passed
@koarz koarz deleted the backend_tablets branch June 18, 2025 10:08
morrySnow pushed a commit that referenced this pull request Jun 30, 2025
gavinchou pushed a commit to apache/doris-website that referenced this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] add a system table in information_schema named be_tablets which contains meta about tablets in be.

8 participants