Skip to content

[fix](system-table)fix tablet table tablet id #51934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 23, 2025
Merged

[fix](system-table)fix tablet table tablet id #51934

dataroaring merged 1 commit into from
Jun 23, 2025

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented Jun 19, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Jun 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 19, 2025

TPC-H: Total hot run time: 33972 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 968d7fe1491fbaf8a6d78987a95a66ca3a17cbeb, data reload: false

------ Round 1 ----------------------------------
q1	17761	5289	5033	5033
q2	1932	288	176	176
q3	10435	1330	743	743
q4	10264	1010	514	514
q5	7619	2371	2335	2335
q6	180	163	131	131
q7	895	740	602	602
q8	9326	1294	1174	1174
q9	6823	5106	5086	5086
q10	6922	2380	1949	1949
q11	500	287	271	271
q12	343	348	214	214
q13	17761	3625	3125	3125
q14	235	229	208	208
q15	555	478	490	478
q16	438	431	368	368
q17	606	871	371	371
q18	7590	7098	7169	7098
q19	1727	965	559	559
q20	320	329	222	222
q21	3688	3161	2339	2339
q22	1039	994	976	976
Total cold run time: 106959 ms
Total hot run time: 33972 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5238	5071	5056	5056
q2	237	323	234	234
q3	2151	2654	2326	2326
q4	1357	1754	1381	1381
q5	4222	4121	4414	4121
q6	211	173	128	128
q7	1974	1911	1764	1764
q8	2602	2462	2503	2462
q9	7273	7134	7179	7134
q10	3100	3263	2882	2882
q11	564	509	476	476
q12	675	735	595	595
q13	3479	3852	3216	3216
q14	295	306	282	282
q15	521	491	482	482
q16	431	483	434	434
q17	1147	1527	1399	1399
q18	7620	7176	7053	7053
q19	784	767	948	767
q20	1950	1976	1853	1853
q21	4734	4389	4238	4238
q22	1063	1027	971	971
Total cold run time: 51628 ms
Total hot run time: 49254 ms

@doris-robot
Copy link

doris-robot commented Jun 19, 2025

TPC-DS: Total hot run time: 185961 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 968d7fe1491fbaf8a6d78987a95a66ca3a17cbeb, data reload: false

query1	993	393	403	393
query2	6536	1908	1870	1870
query3	6752	237	215	215
query4	26552	23292	23217	23217
query5	4325	617	463	463
query6	301	208	200	200
query7	4627	499	295	295
query8	277	218	213	213
query9	8595	2624	2635	2624
query10	496	320	269	269
query11	15267	15113	14756	14756
query12	159	112	106	106
query13	1660	529	411	411
query14	9194	6135	6103	6103
query15	195	196	175	175
query16	7469	589	506	506
query17	1198	750	581	581
query18	1991	415	316	316
query19	193	192	162	162
query20	125	122	118	118
query21	221	126	112	112
query22	4289	4303	4144	4144
query23	34016	33096	33113	33096
query24	8302	2399	2356	2356
query25	534	465	386	386
query26	1231	271	148	148
query27	2709	504	347	347
query28	4291	2118	2102	2102
query29	736	571	429	429
query30	286	222	192	192
query31	899	836	754	754
query32	71	63	62	62
query33	553	363	308	308
query34	819	833	533	533
query35	760	799	730	730
query36	938	1001	860	860
query37	111	102	78	78
query38	4145	4179	4024	4024
query39	1470	1424	1414	1414
query40	214	116	105	105
query41	65	57	58	57
query42	131	106	106	106
query43	494	506	477	477
query44	1309	823	818	818
query45	181	190	165	165
query46	845	1024	615	615
query47	1774	1793	1725	1725
query48	380	420	307	307
query49	740	491	394	394
query50	632	688	395	395
query51	4048	4206	4168	4168
query52	108	105	105	105
query53	220	249	184	184
query54	562	564	493	493
query55	86	81	80	80
query56	301	289	290	289
query57	1202	1217	1141	1141
query58	266	262	248	248
query59	2680	2802	2657	2657
query60	327	305	315	305
query61	123	122	122	122
query62	773	725	651	651
query63	223	186	175	175
query64	4297	978	693	693
query65	4251	4164	4186	4164
query66	1122	412	317	317
query67	15706	15647	15788	15647
query68	8042	869	517	517
query69	468	298	270	270
query70	1231	1100	1099	1099
query71	462	323	305	305
query72	5510	4649	4693	4649
query73	684	573	345	345
query74	9249	9108	8925	8925
query75	3792	3191	2679	2679
query76	3612	1197	759	759
query77	778	370	363	363
query78	9948	10208	9286	9286
query79	2094	768	568	568
query80	651	530	439	439
query81	481	256	233	233
query82	446	126	92	92
query83	292	247	234	234
query84	297	107	93	93
query85	785	354	356	354
query86	346	303	303	303
query87	4437	4483	4299	4299
query88	2896	2264	2262	2262
query89	383	316	284	284
query90	1914	206	205	205
query91	144	138	110	110
query92	81	57	63	57
query93	1098	926	584	584
query94	665	430	299	299
query95	371	300	282	282
query96	497	563	281	281
query97	2716	2765	2645	2645
query98	220	207	199	199
query99	1468	1378	1270	1270
Total cold run time: 272404 ms
Total hot run time: 185961 ms

@doris-robot
Copy link

doris-robot commented Jun 19, 2025

ClickBench: Total hot run time: 29.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 968d7fe1491fbaf8a6d78987a95a66ca3a17cbeb, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.42	0.43	0.42
query6	1.15	0.68	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.52	0.51
query10	0.57	0.60	0.57
query11	0.16	0.10	0.11
query12	0.15	0.11	0.11
query13	0.64	0.60	0.61
query14	0.81	0.82	0.82
query15	0.89	0.86	0.92
query16	0.38	0.38	0.38
query17	1.02	1.06	1.02
query18	0.23	0.20	0.21
query19	1.90	1.85	1.89
query20	0.01	0.01	0.02
query21	15.40	0.90	0.54
query22	0.74	1.20	0.64
query23	14.98	1.40	0.64
query24	7.08	1.63	0.57
query25	0.46	0.21	0.12
query26	0.66	0.16	0.15
query27	0.05	0.05	0.06
query28	9.23	0.90	0.45
query29	12.55	4.01	3.35
query30	0.25	0.10	0.07
query31	2.81	0.61	0.39
query32	3.23	0.55	0.49
query33	3.11	3.06	3.16
query34	16.05	5.37	4.75
query35	4.86	4.83	4.80
query36	0.68	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.15	0.15
query41	0.09	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.58 s
Total hot run time: 29.29 s

@koarz
Copy link
Contributor Author

koarz commented Jun 20, 2025

run beut

@koarz
Copy link
Contributor Author

koarz commented Jun 20, 2025

run nonconcurrent

@koarz
Copy link
Contributor Author

koarz commented Jun 20, 2025

run NonConcurrent Regression

@koarz
Copy link
Contributor Author

koarz commented Jun 20, 2025

run NonConcurrent

@doris-robot
Copy link

doris-robot commented Jun 20, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.36% (15053/26709)
Line Coverage 45.14% (134705/298427)
Region Coverage 44.27% (67726/152983)
Branch Coverage 38.87% (34764/89440)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 20, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.03% (16043/26285)
Line Coverage 50.49% (150593/298252)
Region Coverage 47.81% (86043/179972)
Branch Coverage 41.24% (42165/102254)

@koarz
Copy link
Contributor Author

koarz commented Jun 20, 2025

run nonConcurrent

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 20, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.03% (16043/26285)
Line Coverage 50.49% (150593/298252)
Region Coverage 47.81% (86043/179972)
Branch Coverage 41.24% (42165/102254)

dataroaring
dataroaring approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit a99eb34 into apache:master Jun 23, 2025
27 of 30 checks passed
@koarz koarz deleted the fix_tablet_table branch June 24, 2025 02:03
@morrySnow morrySnow mentioned this pull request Jun 30, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 30, 2025
@koarz
branch-3.1: [feature](schema_table) add information_schema backend_ta…
9d449e7 
…blets table #51282 #51934 (#52485)

Cherry-picked from #51282 #51934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@koarz @Thearas @doris-robot @hello-stephen @Yukang-Lian @dataroaring @morrySnow