Skip to content

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Jun 19, 2025

What problem does this PR solve?

fix error message Cast cannot be cast to class org.apache.doris.nereids.trees.expressions.NamedExpression, introduced by #40202

the right error message should be Unknown column 'xxx' in 'table list' in UNBOUND_OLAP_TABLE_SINK clause

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@924060929
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 33944 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dace1502087bc60748358613d2685d1b96549848, data reload: false

------ Round 1 ----------------------------------
q1	17575	5165	5014	5014
q2	1934	280	202	202
q3	10365	1401	722	722
q4	10236	1009	519	519
q5	7635	2416	2302	2302
q6	176	158	129	129
q7	896	734	615	615
q8	9324	1247	1170	1170
q9	6800	5166	5127	5127
q10	6916	2383	1976	1976
q11	500	298	263	263
q12	339	353	219	219
q13	17775	3692	3039	3039
q14	226	229	224	224
q15	575	470	477	470
q16	435	439	370	370
q17	601	855	359	359
q18	7537	7279	7104	7104
q19	1779	967	554	554
q20	329	336	220	220
q21	3711	3141	2358	2358
q22	1088	1031	988	988
Total cold run time: 106752 ms
Total hot run time: 33944 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5160	5108	5083	5083
q2	235	326	224	224
q3	2169	2643	2299	2299
q4	1384	1796	1355	1355
q5	4224	4125	4352	4125
q6	211	187	130	130
q7	1966	1926	1713	1713
q8	2582	2548	2486	2486
q9	7272	7187	7145	7145
q10	3099	3228	2807	2807
q11	581	506	485	485
q12	656	777	616	616
q13	3427	3873	3229	3229
q14	283	291	271	271
q15	528	479	478	478
q16	450	497	456	456
q17	1131	1519	1335	1335
q18	7763	7234	7084	7084
q19	791	783	855	783
q20	1925	1979	1808	1808
q21	4856	4337	4331	4331
q22	1088	1048	1056	1048
Total cold run time: 51781 ms
Total hot run time: 49291 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186464 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dace1502087bc60748358613d2685d1b96549848, data reload: false

query1	1017	396	380	380
query2	6550	1879	1843	1843
query3	6744	218	229	218
query4	26636	23339	23475	23339
query5	4332	624	456	456
query6	311	203	189	189
query7	4615	505	292	292
query8	258	216	202	202
query9	8572	2607	2619	2607
query10	493	345	293	293
query11	15296	14999	14826	14826
query12	159	112	110	110
query13	1662	525	409	409
query14	8678	6276	6979	6276
query15	194	197	178	178
query16	7563	653	544	544
query17	1219	745	572	572
query18	2019	416	316	316
query19	204	193	175	175
query20	129	117	120	117
query21	219	134	110	110
query22	4261	4202	4121	4121
query23	34064	33270	33158	33158
query24	7765	2365	2387	2365
query25	549	460	390	390
query26	1206	268	151	151
query27	2616	467	343	343
query28	4345	2118	2103	2103
query29	723	567	445	445
query30	289	211	192	192
query31	945	834	771	771
query32	71	67	113	67
query33	557	382	314	314
query34	817	822	540	540
query35	764	814	728	728
query36	972	992	894	894
query37	109	94	82	82
query38	4023	4086	4013	4013
query39	1494	1398	1401	1398
query40	212	120	131	120
query41	62	56	59	56
query42	117	105	109	105
query43	493	506	486	486
query44	1331	828	835	828
query45	180	173	163	163
query46	838	1015	624	624
query47	1769	1796	1734	1734
query48	386	412	309	309
query49	740	510	387	387
query50	644	670	399	399
query51	4146	4196	4126	4126
query52	110	110	102	102
query53	221	247	184	184
query54	578	574	504	504
query55	85	85	85	85
query56	308	311	299	299
query57	1152	1200	1154	1154
query58	274	262	263	262
query59	2593	2769	2581	2581
query60	326	314	307	307
query61	130	124	124	124
query62	797	719	647	647
query63	219	183	182	182
query64	4271	1010	673	673
query65	4308	4164	4208	4164
query66	1126	416	320	320
query67	15758	15583	15524	15524
query68	8219	881	520	520
query69	471	317	271	271
query70	1210	1133	1116	1116
query71	478	332	315	315
query72	5600	4798	4836	4798
query73	756	654	356	356
query74	8826	9104	8914	8914
query75	3892	3214	2717	2717
query76	3723	1197	754	754
query77	807	365	281	281
query78	10164	10304	9376	9376
query79	2601	765	579	579
query80	613	522	438	438
query81	496	261	221	221
query82	682	123	97	97
query83	260	244	229	229
query84	246	106	88	88
query85	816	354	314	314
query86	380	320	278	278
query87	4383	4440	4261	4261
query88	3564	2281	2274	2274
query89	397	318	291	291
query90	1836	208	204	204
query91	154	145	116	116
query92	75	65	55	55
query93	1652	925	580	580
query94	677	419	313	313
query95	376	291	279	279
query96	493	567	276	276
query97	2700	2736	2698	2698
query98	236	212	205	205
query99	1635	1430	1274	1274
Total cold run time: 274032 ms
Total hot run time: 186464 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dace1502087bc60748358613d2685d1b96549848, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.08
query4	1.61	0.10	0.10
query5	0.43	0.43	0.40
query6	1.18	0.66	0.65
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.58	0.51	0.51
query10	0.56	0.58	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.64	0.61	0.61
query14	0.80	0.83	0.81
query15	0.90	0.87	0.90
query16	0.39	0.39	0.38
query17	1.09	1.03	1.10
query18	0.23	0.22	0.21
query19	1.90	1.82	1.80
query20	0.01	0.02	0.01
query21	15.39	0.89	0.55
query22	0.77	1.20	0.65
query23	14.94	1.36	0.62
query24	7.40	1.67	1.06
query25	0.51	0.15	0.07
query26	0.58	0.16	0.14
query27	0.06	0.05	0.05
query28	9.80	0.83	0.45
query29	12.66	4.00	3.34
query30	0.27	0.10	0.07
query31	2.86	0.59	0.39
query32	3.23	0.55	0.49
query33	3.03	3.04	3.08
query34	16.21	5.43	4.79
query35	4.86	4.83	4.85
query36	0.68	0.50	0.49
query37	0.08	0.06	0.06
query38	0.06	0.04	0.03
query39	0.04	0.02	0.03
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.8 s
Total hot run time: 29.7 s

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 19, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

morrySnow pushed a commit that referenced this pull request Jun 20, 2025
@924060929 924060929 merged commit 8a44c57 into apache:master Jun 20, 2025
26 of 28 checks passed
@924060929 924060929 deleted the fix-insert-namedexpr branch June 20, 2025 02:43
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants