Skip to content

[fix](nereids) fix Cast cannot be cast to class org.apache.doris.nereids.trees.expressions.NamedExpression #51925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
924060929 merged 2 commits into from
Jun 20, 2025
Merged

[fix](nereids) fix Cast cannot be cast to class org.apache.doris.nereids.trees.expressions.NamedExpression #51925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bc1f13
fix error message
924060929 Jun 19, 2025
dace150
fix error message
924060929 Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,16 +529,16 @@ value, new ExpressionRewriteContext(expressionAnalyzer.getCascadesContext())
optimizedRowConstructor.add(value);
}

private static Expression castValue(Expression value, DataType targetType) {
private static Alias castValue(Expression value, DataType targetType) {
if (value instanceof Alias) {
Expression oldChild = value.child(0);
Expression newChild = TypeCoercionUtils.castUnbound(oldChild, targetType);
return oldChild == newChild ? value : value.withChildren(newChild);
return (Alias) (oldChild == newChild ? value : value.withChildren(newChild));
} else if (value instanceof UnboundAlias) {
UnboundAlias unboundAlias = (UnboundAlias) value;
return new Alias(TypeCoercionUtils.castUnbound(unboundAlias.child(), targetType));
} else {
return TypeCoercionUtils.castUnbound(value, targetType);
return new Alias(TypeCoercionUtils.castUnbound(value, targetType));
}
}

Expand Down
5 changes: 5 additions & 0 deletions regression-test/suites/insert_p0/insert.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,9 @@ suite("insert") {
def rows1 = sql """select count() from source;"""
def rows2 = sql """select count() from dest;"""
assertTrue(rows1 == rows2);

test {
sql("insert into dest values(now(), 0xff, 0xaa)")
exception "Unknown column '0xff' in 'table list' in UNBOUND_OLAP_TABLE_SINK clause"
}
}
Loading