-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](load) fix bad load id in injection #52339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 35149 ms |
TPC-DS: Total hot run time: 188660 ms |
ClickBench: Total hot run time: 29.74 s |
|
skip buildall |
|
PR approved by at least one committer and no changes requested. |
### What problem does this PR solve? Followup #52042 Modifying `hdr.load_id()` is unsafe and may cause undefined behavior. Also passing load_id by reference in constructors.
### What problem does this PR solve? Followup #52042 Modifying `hdr.load_id()` is unsafe and may cause undefined behavior. Also passing load_id by reference in constructors.
Followup apache#52042 Modifying `hdr.load_id()` is unsafe and may cause undefined behavior. Also passing load_id by reference in constructors.
…ache#52426) Cherry-picked from apache#52339 Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
What problem does this PR solve?
Followup #52042
Modifying
hdr.load_id()is unsafe and may cause undefined behavior.Also passing load_id by reference in constructors.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)