Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #52339

### What problem does this PR solve?

Followup #52042 
Modifying `hdr.load_id()` is unsafe and may cause undefined behavior.
Also passing load_id by reference in constructors.
@github-actions github-actions bot requested a review from dataroaring as a code owner June 27, 2025 06:54
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39950 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ef47cc3e087c644a554b5f5f5beb35070affd32b, data reload: false

------ Round 1 ----------------------------------
q1	17595	6841	6648	6648
q2	2097	168	157	157
q3	10779	1063	1169	1063
q4	10567	761	769	761
q5	7736	2864	2842	2842
q6	213	132	130	130
q7	998	633	603	603
q8	9348	1955	2062	1955
q9	6608	6451	6447	6447
q10	6949	2251	2335	2251
q11	465	266	259	259
q12	396	212	213	212
q13	17825	2986	2954	2954
q14	244	208	214	208
q15	495	459	449	449
q16	448	364	376	364
q17	980	559	590	559
q18	7385	6730	6590	6590
q19	1390	1071	1090	1071
q20	474	208	197	197
q21	3909	3253	3374	3253
q22	1102	977	984	977
Total cold run time: 108003 ms
Total hot run time: 39950 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6617	6596	6617	6596
q2	327	241	226	226
q3	2921	2754	2905	2754
q4	2007	1807	1813	1807
q5	5776	5761	5784	5761
q6	208	131	129	129
q7	2187	1811	1802	1802
q8	3373	3588	3557	3557
q9	8933	8824	8967	8824
q10	3563	3527	3530	3527
q11	594	488	508	488
q12	792	607	651	607
q13	7253	3131	3201	3131
q14	294	257	277	257
q15	501	451	462	451
q16	486	446	448	446
q17	1845	1640	1591	1591
q18	8296	7862	7757	7757
q19	1676	1621	1533	1533
q20	2178	1864	1807	1807
q21	5147	4975	4979	4975
q22	1175	1035	1058	1035
Total cold run time: 66149 ms
Total hot run time: 59061 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196691 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ef47cc3e087c644a554b5f5f5beb35070affd32b, data reload: false

query1	1298	901	895	895
query2	6342	1939	1892	1892
query3	10838	4192	4257	4192
query4	61603	29661	23504	23504
query5	5228	462	456	456
query6	388	174	184	174
query7	5477	305	305	305
query8	309	230	226	226
query9	8467	2583	2575	2575
query10	464	281	257	257
query11	18025	15241	15774	15241
query12	155	102	105	102
query13	1415	438	430	430
query14	9738	6832	7835	6832
query15	204	184	191	184
query16	7102	506	483	483
query17	1226	597	600	597
query18	1861	318	312	312
query19	217	170	164	164
query20	122	108	115	108
query21	207	103	103	103
query22	4635	4319	4772	4319
query23	34998	34487	34051	34051
query24	6091	2969	2843	2843
query25	610	433	430	430
query26	817	174	170	170
query27	2015	374	367	367
query28	4218	2195	2176	2176
query29	764	495	434	434
query30	256	166	160	160
query31	994	792	850	792
query32	73	56	56	56
query33	454	310	294	294
query34	926	507	526	507
query35	847	749	765	749
query36	1088	957	944	944
query37	107	68	70	68
query38	4117	4014	3992	3992
query39	1538	1479	1441	1441
query40	194	98	108	98
query41	47	44	48	44
query42	111	101	100	100
query43	525	472	487	472
query44	1201	817	822	817
query45	189	171	177	171
query46	1152	755	760	755
query47	2011	1906	1968	1906
query48	488	387	364	364
query49	725	409	405	405
query50	846	430	433	430
query51	7558	7236	7255	7236
query52	103	94	90	90
query53	271	192	195	192
query54	571	472	457	457
query55	84	79	80	79
query56	259	242	252	242
query57	1349	1205	1212	1205
query58	219	213	206	206
query59	3214	3050	3016	3016
query60	289	259	248	248
query61	113	175	108	108
query62	812	710	686	686
query63	226	190	189	189
query64	2641	671	626	626
query65	3374	3282	3222	3222
query66	645	302	304	302
query67	16090	15561	15717	15561
query68	4306	588	575	575
query69	427	263	259	259
query70	1172	1143	1056	1056
query71	323	256	254	254
query72	6353	4141	4178	4141
query73	760	354	362	354
query74	10185	9029	9319	9029
query75	3351	2592	2676	2592
query76	2155	1208	1094	1094
query77	484	272	264	264
query78	10704	9681	9630	9630
query79	1547	615	613	613
query80	891	421	433	421
query81	489	220	217	217
query82	1236	89	90	89
query83	237	143	139	139
query84	276	78	75	75
query85	885	298	294	294
query86	330	293	292	292
query87	4480	4305	4233	4233
query88	3604	2410	2356	2356
query89	422	293	296	293
query90	1926	185	190	185
query91	182	147	150	147
query92	67	49	53	49
query93	1853	558	552	552
query94	701	296	293	293
query95	354	255	250	250
query96	620	278	289	278
query97	3346	3136	3165	3136
query98	215	195	192	192
query99	1576	1295	1287	1287
Total cold run time: 315998 ms
Total hot run time: 196691 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.99 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ef47cc3e087c644a554b5f5f5beb35070affd32b, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.22	0.07	0.06
query4	1.63	0.10	0.11
query5	0.53	0.52	0.52
query6	1.14	0.74	0.72
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.50
query10	0.54	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.61	0.59	0.59
query14	0.78	0.78	0.81
query15	0.84	0.83	0.82
query16	0.39	0.38	0.38
query17	1.05	1.04	1.04
query18	0.24	0.22	0.20
query19	1.88	1.82	1.76
query20	0.01	0.02	0.01
query21	15.43	0.61	0.61
query22	2.56	2.05	1.71
query23	17.06	0.91	0.82
query24	3.04	1.28	0.86
query25	0.22	0.17	0.23
query26	0.36	0.14	0.13
query27	0.04	0.04	0.05
query28	10.30	0.51	0.47
query29	12.59	3.26	3.24
query30	0.25	0.05	0.06
query31	2.85	0.40	0.37
query32	3.25	0.47	0.45
query33	2.98	2.99	3.03
query34	16.85	4.47	4.48
query35	4.53	4.55	4.52
query36	0.67	0.51	0.47
query37	0.08	0.05	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 104.35 s
Total hot run time: 29.99 s

@dataroaring dataroaring reopened this Jun 27, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8e3fe1e into branch-3.0 Jun 27, 2025
22 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-52339-branch-3.0 branch June 27, 2025 14:00
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
…ache#52426)

Cherry-picked from apache#52339

Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants