Skip to content

branch-3.1: [fix](inverted index) fix error when writing empty index file #51984 #52690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 3 commits into from
Jul 3, 2025
Merged

branch-3.1: [fix](inverted index) fix error when writing empty index file #51984 #52690

morrySnow merged 3 commits into from
Jul 3, 2025

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Jul 2, 2025

cherry pick from #51984

@airborne12 @zhiqiang-hhhh
[fix](inverted index) fix error when writing empty index file (apache…
8ac4128 
…#51984)

Related PR: apache#51393

Problem Summary:
This PR ensures that copying an empty inverted index segment no longer
throws an exception.
@zhiqiang-hhhh zhiqiang-hhhh requested a review from morrySnow as a code owner July 2, 2025 12:58
@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Jul 2, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Jul 2, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 2, 2025

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.08% (12394/27492)
Line Coverage 36.06% (109711/304280)
Region Coverage 35.13% (56844/161817)
Branch Coverage 32.25% (30830/95604)

@morrySnow morrySnow merged commit 43cb31c into apache:branch-3.1 Jul 3, 2025
18 of 21 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick_51984_to_upstream_branch-3.1 branch July 3, 2025 06:52
etah000 pushed a commit to etah000/doris that referenced this pull request Jul 7, 2025
@zhiqiang-hhhh @airborne12 @etah000
branch-3.1: [fix](inverted index) fix error when writing empty index …
8ad96e7 
…file apache#51984 (apache#52690)

cherry pick from apache#51984

---------

Co-authored-by: airborne12 <jiangkai@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiqiang-hhhh @hello-stephen @morrySnow @airborne12