Skip to content

Conversation

@zhiqiang-hhhh
Copy link
Contributor

cherry pick from #51984

…#51984)

Related PR: apache#51393

Problem Summary:
This PR ensures that copying an empty inverted index segment no longer
throws an exception.
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Jul 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 39661 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6483c4aaa5f5a0e696a623f715505ec91ec2a98b, data reload: false

------ Round 1 ----------------------------------
q1	17626	7139	6601	6601
q2	2065	173	160	160
q3	10793	1060	1140	1060
q4	10532	727	714	714
q5	7747	2831	2801	2801
q6	212	134	133	133
q7	963	600	606	600
q8	9363	1935	2019	1935
q9	6611	6407	6422	6407
q10	6971	2287	2289	2287
q11	446	255	250	250
q12	390	212	212	212
q13	17766	2992	2978	2978
q14	240	214	201	201
q15	509	473	461	461
q16	464	388	388	388
q17	973	556	507	507
q18	7279	6815	6700	6700
q19	1412	1042	1035	1035
q20	470	206	202	202
q21	3856	3186	3046	3046
q22	1095	1012	983	983
Total cold run time: 107783 ms
Total hot run time: 39661 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6580	6646	6587	6587
q2	325	234	222	222
q3	2905	2739	2849	2739
q4	2053	1825	1789	1789
q5	5776	5739	5707	5707
q6	210	131	130	130
q7	2241	1765	1768	1765
q8	3342	3579	3511	3511
q9	8901	8770	8912	8770
q10	3545	3537	3502	3502
q11	605	501	500	500
q12	801	629	598	598
q13	5495	3127	3151	3127
q14	315	290	266	266
q15	512	459	457	457
q16	479	422	435	422
q17	1813	1625	1624	1624
q18	8185	7836	7777	7777
q19	1687	1487	1617	1487
q20	2159	1805	1792	1792
q21	5079	4975	4944	4944
q22	1155	1044	1049	1044
Total cold run time: 64163 ms
Total hot run time: 58760 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196157 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6483c4aaa5f5a0e696a623f715505ec91ec2a98b, data reload: false

query1	1320	918	892	892
query2	6261	1927	1862	1862
query3	10942	4512	4462	4462
query4	62028	28823	23527	23527
query5	5149	452	448	448
query6	388	179	166	166
query7	5456	320	315	315
query8	310	221	246	221
query9	8476	2584	2575	2575
query10	469	269	263	263
query11	17413	15086	15633	15086
query12	157	103	106	103
query13	1400	441	434	434
query14	9786	7251	6678	6678
query15	203	179	169	169
query16	7128	477	509	477
query17	1204	589	596	589
query18	1884	313	311	311
query19	211	158	154	154
query20	117	111	118	111
query21	211	102	106	102
query22	4672	4497	4693	4497
query23	34563	34044	34009	34009
query24	6180	2873	2981	2873
query25	544	431	435	431
query26	670	171	168	168
query27	2003	369	347	347
query28	4350	2178	2154	2154
query29	731	468	426	426
query30	244	155	159	155
query31	987	775	820	775
query32	65	57	52	52
query33	434	286	306	286
query34	900	509	514	509
query35	862	751	730	730
query36	1063	944	926	926
query37	110	72	67	67
query38	4047	3931	3899	3899
query39	1491	1485	1473	1473
query40	199	96	102	96
query41	50	47	47	47
query42	116	102	103	102
query43	523	487	501	487
query44	1191	818	820	818
query45	185	174	167	167
query46	1140	735	707	707
query47	2028	1961	1942	1942
query48	500	393	370	370
query49	747	401	403	401
query50	858	419	429	419
query51	7425	7267	7234	7234
query52	104	97	91	91
query53	278	189	187	187
query54	585	462	471	462
query55	80	80	78	78
query56	261	274	258	258
query57	1326	1210	1224	1210
query58	217	206	206	206
query59	3126	3065	3085	3065
query60	285	268	264	264
query61	109	110	110	110
query62	797	666	677	666
query63	230	191	184	184
query64	1397	631	629	629
query65	3237	3175	3156	3156
query66	717	301	289	289
query67	15882	15485	15746	15485
query68	4113	568	570	568
query69	426	266	263	263
query70	1160	1110	1031	1031
query71	346	252	255	252
query72	6310	4017	4009	4009
query73	740	343	358	343
query74	10198	9285	9055	9055
query75	3365	2630	2643	2630
query76	1887	1035	1094	1035
query77	469	273	270	270
query78	10802	9654	9560	9560
query79	2192	605	597	597
query80	1378	414	418	414
query81	520	221	219	219
query82	1254	87	89	87
query83	266	144	140	140
query84	281	74	82	74
query85	1039	308	288	288
query86	398	293	279	279
query87	4435	4289	4225	4225
query88	3724	2384	2347	2347
query89	412	295	289	289
query90	1969	183	182	182
query91	188	153	144	144
query92	60	48	51	48
query93	2921	545	555	545
query94	798	301	278	278
query95	359	252	250	250
query96	623	286	276	276
query97	3326	3197	3113	3113
query98	215	200	194	194
query99	1564	1303	1300	1300
Total cold run time: 315760 ms
Total hot run time: 196157 ms

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39541 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 35f16438bacfa3f3ca924f6f0b04b112b192bfed, data reload: false

------ Round 1 ----------------------------------
q1	17580	6768	6564	6564
q2	2069	167	163	163
q3	10552	1144	1226	1144
q4	10203	775	686	686
q5	7764	2870	2791	2791
q6	216	131	128	128
q7	980	604	616	604
q8	9359	1976	2009	1976
q9	6580	6425	6387	6387
q10	6998	2321	2259	2259
q11	451	252	258	252
q12	402	212	214	212
q13	17765	3005	2968	2968
q14	247	201	203	201
q15	504	465	454	454
q16	470	388	370	370
q17	1000	605	575	575
q18	7360	6582	6664	6582
q19	1400	1060	1038	1038
q20	476	199	199	199
q21	3967	2990	3194	2990
q22	1126	1008	998	998
Total cold run time: 107469 ms
Total hot run time: 39541 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6645	6567	6577	6567
q2	320	235	225	225
q3	2888	2771	2760	2760
q4	1940	1676	1716	1676
q5	5419	5447	5434	5434
q6	203	124	121	121
q7	2111	1702	1685	1685
q8	3244	3392	3429	3392
q9	8482	8539	8526	8526
q10	3653	3412	3425	3412
q11	588	482	485	482
q12	785	555	578	555
q13	9421	2993	2988	2988
q14	283	266	251	251
q15	497	449	448	448
q16	456	416	424	416
q17	1772	1566	1571	1566
q18	7776	7511	7365	7365
q19	1638	1402	1480	1402
q20	2021	1795	1823	1795
q21	5170	4903	4866	4866
q22	1111	1028	1010	1010
Total cold run time: 66423 ms
Total hot run time: 56942 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189717 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 35f16438bacfa3f3ca924f6f0b04b112b192bfed, data reload: false

query1	992	367	354	354
query2	6518	1928	1977	1928
query3	6711	219	219	219
query4	33772	23954	23459	23459
query5	4891	463	430	430
query6	282	178	176	176
query7	4653	319	304	304
query8	277	233	229	229
query9	9825	2584	2577	2577
query10	522	261	261	261
query11	18269	15682	15155	15155
query12	172	99	102	99
query13	1671	435	419	419
query14	11850	6572	6981	6572
query15	262	167	184	167
query16	8013	500	467	467
query17	1622	573	562	562
query18	2138	315	312	312
query19	383	161	153	153
query20	120	111	110	110
query21	209	107	105	105
query22	4555	4353	4233	4233
query23	33944	33440	33969	33440
query24	10966	2836	2879	2836
query25	686	408	419	408
query26	1286	170	175	170
query27	2404	351	363	351
query28	7555	2106	2092	2092
query29	891	455	454	454
query30	315	161	160	160
query31	1021	804	788	788
query32	101	58	62	58
query33	801	326	312	312
query34	888	502	507	502
query35	899	731	728	728
query36	1098	931	935	931
query37	132	69	72	69
query38	3914	3799	3794	3794
query39	1482	1436	1444	1436
query40	208	101	104	101
query41	55	52	53	52
query42	118	104	103	103
query43	525	484	475	475
query44	1235	793	802	793
query45	184	168	180	168
query46	1123	719	704	704
query47	1920	1803	1801	1801
query48	486	385	377	377
query49	1162	405	417	405
query50	805	403	412	403
query51	7322	7078	7127	7078
query52	100	90	92	90
query53	259	185	191	185
query54	1368	479	486	479
query55	82	80	82	80
query56	307	261	270	261
query57	1278	1156	1153	1153
query58	259	211	230	211
query59	3169	2849	2863	2849
query60	322	259	262	259
query61	117	115	111	111
query62	851	671	676	671
query63	221	188	196	188
query64	5289	662	659	659
query65	3313	3198	3186	3186
query66	1428	342	304	304
query67	15952	15610	15439	15439
query68	5077	575	580	575
query69	456	259	259	259
query70	1145	1045	1112	1045
query71	332	265	259	259
query72	6412	4014	3997	3997
query73	753	344	352	344
query74	10229	8915	8962	8915
query75	3417	2633	2681	2633
query76	2990	1134	987	987
query77	424	275	283	275
query78	10514	9684	9667	9667
query79	1278	602	603	602
query80	1050	446	424	424
query81	541	222	216	216
query82	1034	91	88	88
query83	231	146	144	144
query84	239	81	83	81
query85	1290	312	294	294
query86	363	303	301	301
query87	4451	4203	4234	4203
query88	3390	2368	2320	2320
query89	401	304	300	300
query90	1991	183	192	183
query91	191	151	167	151
query92	59	51	52	51
query93	1079	561	552	552
query94	948	297	278	278
query95	362	260	258	258
query96	670	282	278	278
query97	3305	3155	3132	3132
query98	213	210	195	195
query99	1515	1352	1305	1305
Total cold run time: 301898 ms
Total hot run time: 189717 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.75 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 35f16438bacfa3f3ca924f6f0b04b112b192bfed, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.02
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.52	0.54	0.52
query6	1.13	0.72	0.72
query7	0.04	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.50
query10	0.55	0.56	0.55
query11	0.13	0.10	0.10
query12	0.13	0.11	0.11
query13	0.60	0.59	0.60
query14	0.76	0.77	0.79
query15	0.85	0.82	0.82
query16	0.38	0.38	0.40
query17	1.03	1.04	1.04
query18	0.23	0.22	0.22
query19	1.88	1.88	1.86
query20	0.01	0.01	0.01
query21	15.42	0.56	0.59
query22	2.54	2.06	1.67
query23	17.13	0.88	0.71
query24	3.25	1.95	1.81
query25	0.33	0.11	0.08
query26	0.50	0.14	0.13
query27	0.04	0.05	0.04
query28	8.66	0.49	0.44
query29	12.59	3.22	3.20
query30	0.24	0.06	0.06
query31	2.85	0.39	0.37
query32	3.26	0.46	0.46
query33	2.92	2.96	3.03
query34	17.14	4.51	4.54
query35	4.61	4.54	4.59
query36	0.66	0.49	0.47
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.43 s
Total hot run time: 30.75 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.24% (10945/26538)
Line Coverage 32.03% (93721/292633)
Region Coverage 31.12% (48329/155296)
Branch Coverage 27.57% (24749/89780)

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@airborne12 airborne12 closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants