Skip to content

[fix](chore) fix cache release core #52756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 1 commit into from
Jul 7, 2025
Merged

[fix](chore) fix cache release core #52756

zhannngchen merged 1 commit into from
Jul 7, 2025

Conversation

@zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Jul 4, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #52718

Problem Summary:

LRUCache::release handed nullptr, but ShardedLRUCache::release not, introduced by #52718

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Jul 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

TPC-H: Total hot run time: 34051 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 29d61f07de68827508ffd1fe4488957a1ceef11a, data reload: false

------ Round 1 ----------------------------------
q1	17626	5207	5065	5065
q2	1942	277	179	179
q3	10349	1270	727	727
q4	10208	1029	530	530
q5	7577	2436	2309	2309
q6	183	160	130	130
q7	905	751	609	609
q8	9296	1323	1108	1108
q9	7428	5145	5106	5106
q10	6866	2358	1991	1991
q11	487	293	283	283
q12	341	350	212	212
q13	17754	3713	3143	3143
q14	239	229	215	215
q15	543	482	477	477
q16	419	429	374	374
q17	613	867	378	378
q18	7632	7283	7098	7098
q19	1378	950	549	549
q20	329	357	225	225
q21	3819	2589	2391	2391
q22	1033	1022	952	952
Total cold run time: 106967 ms
Total hot run time: 34051 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5143	5127	5108	5108
q2	244	329	222	222
q3	2196	2692	2330	2330
q4	1435	1775	1414	1414
q5	4248	4640	4545	4545
q6	217	167	129	129
q7	2239	1966	1831	1831
q8	2673	2619	2610	2610
q9	7467	7353	7314	7314
q10	3114	3318	2841	2841
q11	597	523	495	495
q12	713	777	608	608
q13	3692	3983	3451	3451
q14	291	308	289	289
q15	530	480	468	468
q16	463	513	459	459
q17	1197	1636	1412	1412
q18	7938	7707	7685	7685
q19	838	877	953	877
q20	2000	2196	1970	1970
q21	5109	4726	4727	4726
q22	1076	1031	1029	1029
Total cold run time: 53420 ms
Total hot run time: 51813 ms

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

TPC-DS: Total hot run time: 185287 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 29d61f07de68827508ffd1fe4488957a1ceef11a, data reload: false

query1	994	385	384	384
query2	6531	1673	1662	1662
query3	6742	212	214	212
query4	26632	23701	23115	23115
query5	4388	600	443	443
query6	315	226	204	204
query7	4632	502	298	298
query8	271	227	233	227
query9	8588	2622	2648	2622
query10	467	306	267	267
query11	15374	15713	14769	14769
query12	152	105	102	102
query13	1632	548	420	420
query14	8646	5715	5834	5715
query15	204	191	170	170
query16	7112	599	475	475
query17	914	704	587	587
query18	1951	392	291	291
query19	195	188	154	154
query20	123	119	108	108
query21	208	126	112	112
query22	4093	4069	4559	4069
query23	34911	33906	33440	33440
query24	8400	2386	2401	2386
query25	533	465	389	389
query26	1222	259	140	140
query27	2785	510	339	339
query28	4328	2143	2105	2105
query29	769	565	472	472
query30	275	225	185	185
query31	931	819	783	783
query32	78	67	64	64
query33	584	381	320	320
query34	790	855	514	514
query35	783	830	758	758
query36	940	982	903	903
query37	122	101	78	78
query38	4181	4083	4035	4035
query39	1463	1436	1421	1421
query40	207	123	108	108
query41	59	59	60	59
query42	125	108	112	108
query43	510	511	473	473
query44	1358	842	828	828
query45	181	178	171	171
query46	856	1007	637	637
query47	1746	1761	1760	1760
query48	387	429	323	323
query49	746	511	415	415
query50	636	671	419	419
query51	4118	4285	4082	4082
query52	110	156	97	97
query53	236	264	184	184
query54	569	568	503	503
query55	84	81	77	77
query56	305	308	291	291
query57	1166	1158	1105	1105
query58	271	249	243	243
query59	2566	2585	2538	2538
query60	341	311	307	307
query61	161	117	117	117
query62	784	710	656	656
query63	231	191	187	187
query64	4394	995	670	670
query65	4297	4206	4194	4194
query66	1137	398	299	299
query67	15612	15502	15226	15226
query68	8799	900	525	525
query69	479	299	284	284
query70	1211	1140	1100	1100
query71	464	321	291	291
query72	5665	4758	4941	4758
query73	718	600	349	349
query74	9259	9005	8935	8935
query75	4143	3173	2676	2676
query76	3634	1148	726	726
query77	784	397	296	296
query78	10127	10351	9293	9293
query79	1738	790	599	599
query80	648	531	492	492
query81	466	265	226	226
query82	422	128	97	97
query83	289	261	249	249
query84	295	104	83	83
query85	778	355	307	307
query86	336	326	286	286
query87	4429	4498	4363	4363
query88	2883	2293	2285	2285
query89	401	314	290	290
query90	1913	208	210	208
query91	134	139	111	111
query92	84	60	56	56
query93	1180	935	592	592
query94	672	424	302	302
query95	377	299	283	283
query96	499	570	281	281
query97	2724	2763	2662	2662
query98	234	235	195	195
query99	1476	1416	1272	1272
Total cold run time: 273713 ms
Total hot run time: 185287 ms

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

ClickBench: Total hot run time: 29.5 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 29d61f07de68827508ffd1fe4488957a1ceef11a, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.24	0.08	0.08
query4	1.66	0.11	0.10
query5	0.44	0.42	0.44
query6	1.16	0.67	0.66
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.61	0.51	0.52
query10	0.56	0.56	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.62
query14	0.80	0.81	0.82
query15	0.89	0.89	0.89
query16	0.40	0.40	0.40
query17	1.09	1.10	1.11
query18	0.23	0.22	0.22
query19	1.95	1.88	1.85
query20	0.02	0.02	0.01
query21	15.40	0.90	0.54
query22	0.76	1.14	0.76
query23	14.84	1.39	0.64
query24	7.13	2.58	0.48
query25	0.54	0.18	0.06
query26	0.46	0.17	0.16
query27	0.07	0.06	0.05
query28	9.69	0.89	0.46
query29	12.55	4.02	3.34
query30	0.25	0.09	0.06
query31	2.83	0.61	0.39
query32	3.23	0.56	0.48
query33	3.06	3.07	3.13
query34	16.05	5.37	4.79
query35	4.83	4.83	4.83
query36	0.70	0.50	0.49
query37	0.09	0.07	0.07
query38	0.06	0.04	0.03
query39	0.03	0.03	0.02
query40	0.19	0.13	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.09 s
Total hot run time: 29.5 s

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.16% (15404/26949)
Line Coverage 46.17% (139659/302478)
Region Coverage 45.48% (70784/155646)
Branch Coverage 40.22% (37331/92808)

@zhannngchen
Copy link
Contributor Author

zhannngchen commented Jul 4, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

TPC-H: Total hot run time: 34026 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9c05c606c8f334cc8eda46584de42e15b4de2785, data reload: false

------ Round 1 ----------------------------------
q1	17565	5140	5076	5076
q2	1934	275	190	190
q3	10305	1331	738	738
q4	10219	1043	512	512
q5	7534	2421	2334	2334
q6	177	157	124	124
q7	877	737	599	599
q8	9321	1302	1075	1075
q9	6928	5185	5127	5127
q10	6876	2384	1966	1966
q11	469	312	283	283
q12	335	344	213	213
q13	17788	3674	3120	3120
q14	231	222	210	210
q15	538	469	498	469
q16	429	427	387	387
q17	605	889	362	362
q18	7899	7266	7156	7156
q19	1211	944	560	560
q20	325	337	230	230
q21	3864	2543	2330	2330
q22	1044	1016	965	965
Total cold run time: 106474 ms
Total hot run time: 34026 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5081	5034	5107	5034
q2	251	320	214	214
q3	2182	2672	2258	2258
q4	1373	1806	1298	1298
q5	4245	4501	4566	4501
q6	218	170	140	140
q7	2030	1957	1826	1826
q8	2697	2672	2619	2619
q9	7447	7343	7285	7285
q10	3080	3575	2859	2859
q11	580	494	487	487
q12	679	792	633	633
q13	3660	4079	3325	3325
q14	298	302	297	297
q15	520	483	470	470
q16	459	513	441	441
q17	1196	1618	1397	1397
q18	8001	7851	7733	7733
q19	836	876	921	876
q20	2017	2079	2045	2045
q21	5083	4593	4541	4541
q22	1116	1049	1073	1049
Total cold run time: 53049 ms
Total hot run time: 51328 ms

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

TPC-DS: Total hot run time: 185945 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9c05c606c8f334cc8eda46584de42e15b4de2785, data reload: false

query1	1018	392	383	383
query2	6523	1795	1771	1771
query3	6743	211	215	211
query4	26323	23736	23287	23287
query5	4341	582	423	423
query6	289	222	194	194
query7	4628	490	285	285
query8	263	222	212	212
query9	8606	2639	2643	2639
query10	470	319	264	264
query11	15622	15081	14746	14746
query12	173	108	103	103
query13	1648	526	410	410
query14	8581	5627	5645	5627
query15	204	196	171	171
query16	7268	663	491	491
query17	1221	731	588	588
query18	1994	431	305	305
query19	200	199	155	155
query20	124	113	113	113
query21	218	122	108	108
query22	4140	4470	4667	4470
query23	35139	33643	33557	33557
query24	8418	2358	2343	2343
query25	540	458	387	387
query26	1235	256	138	138
query27	2758	501	333	333
query28	4286	2145	2121	2121
query29	732	559	427	427
query30	303	215	184	184
query31	903	833	739	739
query32	74	58	62	58
query33	541	358	299	299
query34	797	831	511	511
query35	773	832	749	749
query36	925	950	847	847
query37	110	91	70	70
query38	4176	4127	4021	4021
query39	1447	1422	1429	1422
query40	203	113	102	102
query41	62	51	50	50
query42	123	103	107	103
query43	493	510	489	489
query44	1305	841	816	816
query45	169	171	161	161
query46	876	991	626	626
query47	1752	1802	1737	1737
query48	388	409	299	299
query49	737	476	393	393
query50	628	683	396	396
query51	4109	4221	4243	4221
query52	109	102	94	94
query53	228	253	183	183
query54	557	568	484	484
query55	81	79	79	79
query56	313	300	267	267
query57	1169	1221	1100	1100
query58	263	245	249	245
query59	2648	2802	2696	2696
query60	331	321	314	314
query61	124	116	115	115
query62	798	693	653	653
query63	223	190	175	175
query64	4338	1006	653	653
query65	4344	4178	4157	4157
query66	1141	439	311	311
query67	15695	15617	15590	15590
query68	7950	887	525	525
query69	450	306	265	265
query70	1189	1118	1090	1090
query71	481	308	308	308
query72	5566	4778	4867	4778
query73	724	649	349	349
query74	8932	8857	9010	8857
query75	3700	3187	2689	2689
query76	3450	1131	707	707
query77	735	371	285	285
query78	9989	10298	9324	9324
query79	2277	824	582	582
query80	637	507	435	435
query81	480	252	221	221
query82	427	120	92	92
query83	286	243	240	240
query84	296	106	81	81
query85	764	358	311	311
query86	327	286	287	286
query87	4445	4412	4328	4328
query88	3300	2307	2304	2304
query89	396	373	279	279
query90	1883	209	206	206
query91	137	145	109	109
query92	71	57	58	57
query93	1125	971	588	588
query94	667	399	294	294
query95	371	286	282	282
query96	500	569	281	281
query97	2716	2771	2648	2648
query98	243	203	205	203
query99	1462	1379	1270	1270
Total cold run time: 272937 ms
Total hot run time: 185945 ms

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

ClickBench: Total hot run time: 29.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9c05c606c8f334cc8eda46584de42e15b4de2785, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.04	0.04
query3	0.25	0.09	0.07
query4	1.63	0.10	0.10
query5	0.43	0.42	0.43
query6	1.16	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.53	0.53
query10	0.57	0.59	0.56
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.62	0.62	0.60
query14	0.81	0.81	0.82
query15	0.91	0.87	0.88
query16	0.38	0.39	0.38
query17	1.05	1.03	1.06
query18	0.23	0.21	0.20
query19	1.99	1.93	1.85
query20	0.01	0.02	0.01
query21	15.40	0.88	0.55
query22	0.75	1.31	0.62
query23	14.88	1.38	0.65
query24	6.52	2.30	1.14
query25	0.47	0.23	0.16
query26	0.71	0.17	0.16
query27	0.07	0.06	0.05
query28	10.25	0.84	0.45
query29	12.54	3.95	3.29
query30	0.25	0.09	0.07
query31	2.84	0.58	0.38
query32	3.25	0.55	0.48
query33	3.11	3.10	3.25
query34	15.99	5.44	4.73
query35	4.86	4.80	4.78
query36	0.70	0.50	0.50
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.16	0.14	0.14
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.17 s
Total hot run time: 29.88 s

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.33% (15482/27006)
Line Coverage 46.30% (140633/303773)
Region Coverage 45.59% (71166/156114)
Branch Coverage 40.29% (37488/93038)

@zhannngchen zhannngchen merged commit 969f5fe into apache:master Jul 7, 2025
24 of 27 checks passed
zhannngchen pushed a commit to zhannngchen/incubator-doris that referenced this pull request Jul 7, 2025
[fix](chore) fix cache release core (apache#52756)
6d2c349
@zhannngchen zhannngchen mentioned this pull request Jul 7, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 7, 2025
branch-3.1: [fix](mow) fix potential mem leak for DeleteBitmap::get_agg
29d5d99 
#52718,#52756 (#52860)

cherry-pick #52718 #52756
etah000 pushed a commit to etah000/doris that referenced this pull request Jul 7, 2025
@etah000
branch-3.1: [fix](mow) fix potential mem leak for DeleteBitmap::get_agg
cc39d59 
apache#52718,apache#52756 (apache#52860)

cherry-pick apache#52718 apache#52756
zhannngchen pushed a commit to zhannngchen/incubator-doris that referenced this pull request Jul 8, 2025
[fix](chore) fix cache release core (apache#52756)
8b74b19
@zhannngchen zhannngchen mentioned this pull request Jul 8, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 9, 2025
branch-3.0:[fix](mow) fix potential mem leak for DeleteBitmap::get_agg (
cfa4f67 
#52718, #52756) (#52931)

cherry-pick #52718, #52756
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

+1 more reviewer

@bobhan1 bobhan1 bobhan1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhannngchen @hello-stephen @doris-robot @gavinchou @bobhan1 @dataroaring @morrySnow