Skip to content

Conversation

@zhannngchen
Copy link
Contributor

cherry-pick #52718, #52756

@zhannngchen zhannngchen requested a review from dataroaring as a code owner July 8, 2025 07:40
@Thearas
Copy link
Contributor

Thearas commented Jul 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhannngchen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39500 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8b74b19c225f479c23c46e320a1449423cd9363d, data reload: false

------ Round 1 ----------------------------------
q1	17622	6909	6591	6591
q2	2060	203	163	163
q3	10630	1102	1138	1102
q4	10388	741	771	741
q5	7719	2862	2760	2760
q6	214	134	131	131
q7	971	621	596	596
q8	9348	1956	1994	1956
q9	6599	6383	6396	6383
q10	7036	2257	2283	2257
q11	469	260	259	259
q12	397	207	211	207
q13	17775	2970	2996	2970
q14	234	208	208	208
q15	516	477	475	475
q16	505	385	376	376
q17	967	603	539	539
q18	7178	6549	6777	6549
q19	1411	1038	1040	1038
q20	458	197	203	197
q21	3859	3109	3029	3029
q22	1097	973	993	973
Total cold run time: 107453 ms
Total hot run time: 39500 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6659	6662	6573	6573
q2	338	234	228	228
q3	2876	2913	2910	2910
q4	2055	1765	1878	1765
q5	5689	5743	5728	5728
q6	216	129	132	129
q7	2237	1780	1815	1780
q8	3453	3546	3584	3546
q9	8828	9052	8976	8976
q10	3613	3536	3555	3536
q11	584	510	500	500
q12	831	630	623	623
q13	8414	3199	3152	3152
q14	294	259	278	259
q15	517	472	471	471
q16	488	438	429	429
q17	1833	1611	1607	1607
q18	8320	7930	7753	7753
q19	1640	1435	1573	1435
q20	2062	1883	1880	1880
q21	5083	5094	4965	4965
q22	1131	1061	1026	1026
Total cold run time: 67161 ms
Total hot run time: 59271 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195420 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8b74b19c225f479c23c46e320a1449423cd9363d, data reload: false

query1	1285	913	898	898
query2	6254	1892	1831	1831
query3	10818	4266	4213	4213
query4	32881	23769	23695	23695
query5	4028	455	436	436
query6	254	170	182	170
query7	4002	319	314	314
query8	277	219	223	219
query9	9652	2574	2579	2574
query10	477	268	269	268
query11	17795	15548	15228	15228
query12	152	104	102	102
query13	1553	431	422	422
query14	8852	7053	6556	6556
query15	259	184	190	184
query16	7969	513	486	486
query17	1641	588	594	588
query18	2120	320	314	314
query19	219	165	164	164
query20	124	109	113	109
query21	202	116	106	106
query22	4597	4380	4387	4380
query23	35232	34034	33791	33791
query24	11412	2907	2928	2907
query25	696	427	428	427
query26	1233	165	168	165
query27	2620	348	360	348
query28	7260	2194	2156	2156
query29	884	481	476	476
query30	260	160	156	156
query31	1057	803	804	803
query32	84	55	60	55
query33	768	296	305	296
query34	916	505	503	503
query35	862	701	742	701
query36	1088	943	980	943
query37	137	68	69	68
query38	4094	4055	3877	3877
query39	1503	1501	1485	1485
query40	202	100	101	100
query41	51	50	50	50
query42	117	103	101	101
query43	524	485	491	485
query44	1292	802	814	802
query45	192	172	171	171
query46	1144	716	703	703
query47	2006	1869	1972	1869
query48	473	394	402	394
query49	978	415	401	401
query50	826	407	405	405
query51	7472	7183	7196	7183
query52	96	89	90	89
query53	251	186	189	186
query54	1442	468	495	468
query55	81	81	77	77
query56	273	251	248	248
query57	1325	1236	1198	1198
query58	222	203	217	203
query59	3162	3066	2933	2933
query60	286	264	263	263
query61	112	124	113	113
query62	845	701	693	693
query63	220	187	194	187
query64	4130	668	639	639
query65	3350	3250	3246	3246
query66	804	294	290	290
query67	15784	15451	15525	15451
query68	4430	622	582	582
query69	435	265	261	261
query70	1183	1115	1120	1115
query71	355	300	252	252
query72	6351	3989	4032	3989
query73	747	341	341	341
query74	10238	8819	8941	8819
query75	3402	2635	2672	2635
query76	2658	1073	977	977
query77	410	275	279	275
query78	10622	9618	9532	9532
query79	1208	613	587	587
query80	920	424	432	424
query81	521	216	219	216
query82	1332	93	86	86
query83	206	144	143	143
query84	243	77	80	77
query85	1092	306	291	291
query86	315	303	305	303
query87	4398	4254	4153	4153
query88	3477	2407	2372	2372
query89	409	291	299	291
query90	2031	184	183	183
query91	173	147	144	144
query92	61	51	51	51
query93	1197	546	539	539
query94	734	292	299	292
query95	362	248	248	248
query96	610	283	279	279
query97	3280	3113	3201	3113
query98	211	207	194	194
query99	1575	1294	1302	1294
Total cold run time: 298363 ms
Total hot run time: 195420 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8b74b19c225f479c23c46e320a1449423cd9363d, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.53	0.52	0.53
query6	1.14	0.72	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.54	0.49	0.47
query10	0.58	0.54	0.55
query11	0.14	0.09	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.60
query14	0.77	0.79	0.79
query15	0.84	0.81	0.81
query16	0.39	0.38	0.41
query17	1.06	1.01	1.01
query18	0.23	0.22	0.22
query19	1.92	1.86	1.86
query20	0.02	0.01	0.01
query21	15.39	0.60	0.59
query22	2.40	1.50	1.74
query23	16.89	1.07	0.84
query24	3.06	1.79	1.68
query25	0.28	0.15	0.09
query26	0.53	0.14	0.15
query27	0.05	0.05	0.04
query28	9.16	0.49	0.46
query29	12.60	3.23	3.19
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.24	0.47	0.45
query33	2.96	2.96	3.05
query34	17.04	4.51	4.47
query35	4.50	4.52	4.48
query36	0.67	0.48	0.47
query37	0.09	0.07	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.09	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.33 s
Total hot run time: 30.47 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.21% (10949/26567)
Line Coverage 32.00% (93795/293144)
Region Coverage 31.10% (48359/155473)
Branch Coverage 27.56% (24770/89892)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit cfa4f67 into apache:branch-3.0 Jul 9, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants