Skip to content

[Enhancement-3.0](type) Support cast between time and datetime #53734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Aug 13, 2025
Merged

[Enhancement-3.0](type) Support cast between time and datetime #53734

dataroaring merged 3 commits into from
Aug 13, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Jul 22, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

Support cast between time and datetime

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Mryange @zclllyybb
[feature](cast) support time cast to date/datetime (apache#49483)
434f15e 
In the past, we did not support time cast to datetime/date.
Here we add the support because time cast to date involves the current
date, so most of the tests are BEUT.

1. Support casting the time type to date/datetime.
2. The time type can be implicitly converted to date/datetime.

None

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@zclllyybb zclllyybb requested a review from dataroaring as a code owner July 22, 2025 14:05
@zclllyybb zclllyybb added usercase Important user case type label dev/3.0.x dev/3.1.x labels Jul 22, 2025
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 22, 2025

run buildall

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 22, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-H: Total hot run time: 40070 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 40d1d1263c6438dddde061feb50e8db65f0e22dd, data reload: false

------ Round 1 ----------------------------------
q1	17631	6806	6649	6649
q2	2080	169	166	166
q3	10674	1155	1171	1155
q4	10495	752	749	749
q5	7763	2932	2847	2847
q6	213	131	128	128
q7	970	614	608	608
q8	9358	1972	2069	1972
q9	6706	6443	6491	6443
q10	6989	2257	2278	2257
q11	462	272	259	259
q12	405	210	216	210
q13	17862	2964	2974	2964
q14	244	220	211	211
q15	514	473	468	468
q16	483	393	383	383
q17	999	548	604	548
q18	7478	6594	6625	6594
q19	1395	1135	1109	1109
q20	494	202	208	202
q21	3944	3176	3182	3176
q22	1110	990	972	972
Total cold run time: 108269 ms
Total hot run time: 40070 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6615	6622	6575	6575
q2	332	228	226	226
q3	3018	2940	2940	2940
q4	2086	1859	1795	1795
q5	5764	5783	5828	5783
q6	221	124	127	124
q7	2204	1831	1808	1808
q8	3433	3610	3449	3449
q9	8922	9013	8874	8874
q10	3589	3542	3559	3542
q11	596	513	498	498
q12	800	651	638	638
q13	9465	3102	3132	3102
q14	298	269	266	266
q15	506	472	460	460
q16	495	425	446	425
q17	1846	1603	1608	1603
q18	8440	7918	7717	7717
q19	1671	1563	1509	1509
q20	2121	1863	1877	1863
q21	5286	5046	5116	5046
q22	1168	1041	1042	1041
Total cold run time: 68876 ms
Total hot run time: 59284 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

BE UT Coverage Report

Increment line coverage 16.54% (22/133) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.90% (11138/26584)
Line Coverage 32.43% (95428/294220)
Region Coverage 31.56% (49265/156096)
Branch Coverage 28.00% (25254/90202)

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-DS: Total hot run time: 196165 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 40d1d1263c6438dddde061feb50e8db65f0e22dd, data reload: false

query1	1324	973	912	912
query2	6244	1907	1825	1825
query3	10960	4372	4637	4372
query4	33267	23508	23595	23508
query5	4203	461	460	460
query6	282	187	183	183
query7	3992	308	311	308
query8	282	233	218	218
query9	9598	2595	2590	2590
query10	483	253	241	241
query11	17701	15224	15412	15224
query12	154	103	103	103
query13	1542	408	402	402
query14	8962	7012	6591	6591
query15	223	193	197	193
query16	7962	491	498	491
query17	1586	587	623	587
query18	2197	329	332	329
query19	221	172	161	161
query20	128	123	117	117
query21	206	107	106	106
query22	4897	4605	4483	4483
query23	35081	33713	34112	33713
query24	11919	2927	2889	2889
query25	715	418	434	418
query26	1773	182	169	169
query27	2858	344	347	344
query28	8031	2154	2165	2154
query29	1060	470	462	462
query30	268	170	158	158
query31	1050	812	827	812
query32	100	59	59	59
query33	783	322	307	307
query34	1321	506	513	506
query35	859	715	721	715
query36	1110	969	952	952
query37	277	70	67	67
query38	4077	3977	3886	3886
query39	1511	1454	1482	1454
query40	248	98	98	98
query41	53	51	48	48
query42	122	104	101	101
query43	519	471	471	471
query44	1281	824	822	822
query45	183	161	168	161
query46	1183	735	718	718
query47	2048	1940	1937	1937
query48	473	387	375	375
query49	1145	389	393	389
query50	840	419	423	419
query51	7423	7224	7279	7224
query52	105	99	96	96
query53	264	186	182	182
query54	1338	493	471	471
query55	77	74	78	74
query56	262	233	241	233
query57	1369	1223	1215	1215
query58	231	211	220	211
query59	3162	3000	2977	2977
query60	288	258	254	254
query61	139	111	101	101
query62	903	678	674	674
query63	220	193	186	186
query64	5008	650	609	609
query65	3286	3209	3190	3190
query66	1364	296	303	296
query67	15802	15664	15557	15557
query68	5006	579	578	578
query69	448	261	264	261
query70	1132	1094	1116	1094
query71	341	248	257	248
query72	6145	4074	4191	4074
query73	754	344	353	344
query74	10659	9186	9274	9186
query75	3377	2682	2605	2605
query76	3203	1114	1055	1055
query77	373	276	284	276
query78	10494	9604	9602	9602
query79	1668	604	604	604
query80	1126	412	415	412
query81	548	221	218	218
query82	923	88	88	88
query83	231	143	142	142
query84	230	77	84	77
query85	1470	296	286	286
query86	453	286	289	286
query87	4360	4169	4222	4169
query88	3735	2395	2357	2357
query89	416	293	293	293
query90	2149	181	182	181
query91	188	168	172	168
query92	66	50	48	48
query93	2482	540	539	539
query94	1090	300	284	284
query95	361	251	247	247
query96	631	283	285	283
query97	3300	3132	3123	3123
query98	225	199	196	196
query99	1496	1313	1283	1283
Total cold run time: 307623 ms
Total hot run time: 196165 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

ClickBench: Total hot run time: 30.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 40d1d1263c6438dddde061feb50e8db65f0e22dd, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.23	0.06	0.07
query4	1.62	0.11	0.10
query5	0.51	0.52	0.52
query6	1.12	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.51	0.51
query10	0.55	0.57	0.58
query11	0.15	0.11	0.10
query12	0.14	0.11	0.10
query13	0.60	0.59	0.61
query14	0.78	0.78	0.81
query15	0.84	0.82	0.83
query16	0.39	0.38	0.40
query17	1.08	1.06	1.08
query18	0.23	0.21	0.21
query19	1.81	1.78	1.89
query20	0.02	0.01	0.02
query21	15.41	0.59	0.60
query22	2.20	2.04	1.59
query23	16.98	0.91	0.82
query24	3.34	0.95	2.29
query25	0.31	0.19	0.22
query26	0.39	0.14	0.14
query27	0.04	0.04	0.03
query28	9.05	0.52	0.46
query29	12.58	3.19	3.23
query30	0.25	0.06	0.06
query31	2.87	0.39	0.37
query32	3.22	0.45	0.46
query33	2.97	2.98	3.04
query34	17.15	4.51	4.53
query35	4.56	4.59	4.56
query36	0.65	0.48	0.47
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 103.25 s
Total hot run time: 30.07 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 23, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 27, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 27, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Jul 27, 2025

BE UT Coverage Report

Increment line coverage 16.54% (22/133) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.89% (11137/26584)
Line Coverage 32.41% (95369/294221)
Region Coverage 31.55% (49256/156096)
Branch Coverage 27.98% (25239/90202)

@doris-robot
Copy link

doris-robot commented Jul 27, 2025

TPC-H: Total hot run time: 39815 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e10f283d4e6e17d9df496977792257a1c8ad6092, data reload: false

------ Round 1 ----------------------------------
q1	17912	6855	6638	6638
q2	2095	159	160	159
q3	10686	1144	1110	1110
q4	10396	797	693	693
q5	7729	2947	2828	2828
q6	216	132	131	131
q7	984	633	602	602
q8	9366	1966	2030	1966
q9	6706	6431	6449	6431
q10	7039	2218	2281	2218
q11	469	266	264	264
q12	399	214	219	214
q13	17789	3017	3005	3005
q14	241	217	207	207
q15	501	464	471	464
q16	488	394	374	374
q17	985	626	602	602
q18	7377	6727	6596	6596
q19	1381	1115	1046	1046
q20	477	201	207	201
q21	3906	3087	3077	3077
q22	1128	1000	989	989
Total cold run time: 108270 ms
Total hot run time: 39815 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6699	6606	6549	6549
q2	340	232	230	230
q3	2961	2950	2995	2950
q4	2051	1842	1830	1830
q5	5706	5758	5725	5725
q6	210	132	132	132
q7	2209	1850	1826	1826
q8	3346	3631	3489	3489
q9	8877	8920	8857	8857
q10	3584	3497	3585	3497
q11	600	487	502	487
q12	804	618	605	605
q13	8973	3150	3155	3150
q14	311	266	274	266
q15	512	465	473	465
q16	477	434	450	434
q17	1851	1643	1654	1643
q18	8324	7756	7717	7717
q19	1670	1610	1547	1547
q20	2070	1890	1858	1858
q21	5165	5037	5004	5004
q22	1155	1111	1040	1040
Total cold run time: 67895 ms
Total hot run time: 59301 ms

@doris-robot
Copy link

doris-robot commented Jul 27, 2025

TPC-DS: Total hot run time: 198260 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e10f283d4e6e17d9df496977792257a1c8ad6092, data reload: false

query1	1269	919	882	882
query2	6274	1919	1838	1838
query3	10951	4457	4444	4444
query4	33435	23761	23487	23487
query5	4234	455	461	455
query6	269	173	188	173
query7	4016	308	323	308
query8	274	224	226	224
query9	9535	2602	2577	2577
query10	482	261	259	259
query11	17974	15086	15425	15086
query12	167	105	105	105
query13	1560	429	429	429
query14	9461	7585	7659	7585
query15	252	188	197	188
query16	8120	460	494	460
query17	1694	632	623	623
query18	2159	331	323	323
query19	370	178	166	166
query20	122	116	127	116
query21	207	113	112	112
query22	4880	4607	4631	4607
query23	35395	34758	34101	34101
query24	11175	2922	2952	2922
query25	599	429	426	426
query26	753	174	173	173
query27	2562	360	367	360
query28	7328	2218	2224	2218
query29	697	468	457	457
query30	254	155	159	155
query31	1040	823	818	818
query32	91	53	56	53
query33	757	295	336	295
query34	1307	510	509	509
query35	893	775	717	717
query36	1110	971	952	952
query37	113	72	71	71
query38	4075	3943	3925	3925
query39	1501	1470	1480	1470
query40	201	96	95	95
query41	49	47	50	47
query42	120	103	105	103
query43	520	466	477	466
query44	1337	856	845	845
query45	185	170	177	170
query46	1171	753	732	732
query47	2041	1968	1948	1948
query48	487	393	402	393
query49	882	395	396	395
query50	866	426	431	426
query51	7511	7277	7196	7196
query52	101	91	91	91
query53	263	192	199	192
query54	1215	482	480	480
query55	84	76	80	76
query56	256	262	241	241
query57	1316	1263	1209	1209
query58	253	210	232	210
query59	3214	2977	3006	2977
query60	297	267	275	267
query61	119	131	115	115
query62	874	717	707	707
query63	224	197	196	196
query64	3886	691	661	661
query65	3325	3319	3312	3312
query66	766	296	320	296
query67	16194	15892	15641	15641
query68	4495	591	601	591
query69	442	259	269	259
query70	1184	1117	1178	1117
query71	326	260	252	252
query72	6075	4095	4019	4019
query73	749	351	364	351
query74	10482	9065	9351	9065
query75	3356	2654	2660	2654
query76	2639	1166	1059	1059
query77	390	290	283	283
query78	10527	9577	9619	9577
query79	1578	592	610	592
query80	1183	440	427	427
query81	540	221	224	221
query82	939	89	89	89
query83	235	158	152	152
query84	240	76	80	76
query85	1326	303	292	292
query86	386	305	281	281
query87	4387	4272	4243	4243
query88	3612	2421	2399	2399
query89	417	291	290	290
query90	1894	191	183	183
query91	180	151	151	151
query92	61	49	51	49
query93	1899	554	550	550
query94	816	301	303	301
query95	362	257	259	257
query96	612	282	284	282
query97	3330	3194	3158	3158
query98	208	203	197	197
query99	1533	1287	1317	1287
Total cold run time: 301515 ms
Total hot run time: 198260 ms

@doris-robot
Copy link

doris-robot commented Jul 27, 2025

ClickBench: Total hot run time: 30.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e10f283d4e6e17d9df496977792257a1c8ad6092, data reload: false

query1	0.03	0.04	0.02
query2	0.06	0.04	0.03
query3	0.23	0.06	0.07
query4	1.62	0.11	0.11
query5	0.52	0.52	0.51
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.51	0.50
query10	0.55	0.55	0.58
query11	0.14	0.13	0.11
query12	0.13	0.12	0.10
query13	0.61	0.59	0.61
query14	0.75	0.79	0.79
query15	0.83	0.83	0.82
query16	0.37	0.38	0.38
query17	1.06	1.02	1.04
query18	0.23	0.22	0.22
query19	1.90	1.85	1.85
query20	0.01	0.01	0.02
query21	15.39	0.61	0.59
query22	2.34	1.77	2.50
query23	16.97	0.97	0.88
query24	2.68	1.48	1.89
query25	0.40	0.04	0.05
query26	0.42	0.13	0.14
query27	0.06	0.04	0.05
query28	9.54	0.51	0.46
query29	12.57	3.20	3.23
query30	0.24	0.06	0.06
query31	2.86	0.37	0.37
query32	3.26	0.46	0.46
query33	2.98	2.93	3.03
query34	17.01	4.52	4.55
query35	4.58	4.56	4.55
query36	0.66	0.49	0.47
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.15	0.13	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 103.22 s
Total hot run time: 30.72 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 27, 2025

BE Regression && UT Coverage Report

Increment line coverage 91.73% (122/133) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.99% (19675/26238)
Line Coverage 68.25% (200539/293827)
Region Coverage 66.33% (119894/180764)
Branch Coverage 59.74% (60911/101968)

HappenLee
HappenLee reviewed Jul 28, 2025
View reviewed changes
HappenLee
HappenLee reviewed Jul 28, 2025
View reviewed changes
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 28, 2025

run buildall

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 28, 2025

run buildall

@zclllyybb zclllyybb requested a review from HappenLee July 28, 2025 09:19
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 28, 2025

TPC-H: Total hot run time: 39811 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a930da63a3455313c5f0207bbc85c2a2f56328a, data reload: false

------ Round 1 ----------------------------------
q1	17622	7112	6615	6615
q2	2078	171	163	163
q3	10636	1137	1167	1137
q4	10361	793	769	769
q5	7757	2907	2841	2841
q6	210	130	134	130
q7	972	612	597	597
q8	9349	1969	2041	1969
q9	6669	6398	6441	6398
q10	6957	2266	2294	2266
q11	455	260	259	259
q12	415	216	226	216
q13	17790	2968	3013	2968
q14	232	207	208	207
q15	518	476	482	476
q16	478	387	373	373
q17	980	574	530	530
q18	7323	6749	6606	6606
q19	1392	1087	1141	1087
q20	475	207	205	205
q21	3882	3011	3271	3011
q22	1123	1025	988	988
Total cold run time: 107674 ms
Total hot run time: 39811 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6598	6747	6586	6586
q2	326	233	238	233
q3	2943	2991	2918	2918
q4	2068	1845	1820	1820
q5	5709	5743	5713	5713
q6	204	131	134	131
q7	2296	1865	1844	1844
q8	3379	3529	3523	3523
q9	8832	8888	8864	8864
q10	3586	3517	3564	3517
q11	581	484	504	484
q12	823	596	597	596
q13	10092	3123	3188	3123
q14	296	283	279	279
q15	535	469	478	469
q16	483	441	457	441
q17	1872	1661	1622	1622
q18	8319	7737	7871	7737
q19	1644	1682	1515	1515
q20	2102	1894	1861	1861
q21	5255	5124	5032	5032
q22	1159	1082	1017	1017
Total cold run time: 69102 ms
Total hot run time: 59325 ms

@doris-robot
Copy link

doris-robot commented Jul 28, 2025

BE UT Coverage Report

Increment line coverage 16.54% (22/133) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.90% (11139/26584)
Line Coverage 32.42% (95397/294227)
Region Coverage 31.56% (49271/156099)
Branch Coverage 27.98% (25243/90202)

@doris-robot
Copy link

doris-robot commented Jul 28, 2025

TPC-DS: Total hot run time: 197298 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a930da63a3455313c5f0207bbc85c2a2f56328a, data reload: false

query1	1294	908	888	888
query2	6230	1935	1914	1914
query3	10941	4485	4548	4485
query4	33028	23240	24175	23240
query5	4783	453	440	440
query6	278	189	171	171
query7	4003	309	321	309
query8	279	224	218	218
query9	9536	2586	2555	2555
query10	488	260	253	253
query11	18326	15111	15225	15111
query12	157	103	101	101
query13	1540	435	417	417
query14	9444	7107	7241	7107
query15	255	179	185	179
query16	8066	517	523	517
query17	1582	610	577	577
query18	2154	319	335	319
query19	354	169	164	164
query20	125	116	117	116
query21	202	104	110	104
query22	4777	4464	4506	4464
query23	35837	34249	34338	34249
query24	11307	3037	2966	2966
query25	690	429	423	423
query26	1410	171	167	167
query27	2708	354	348	348
query28	7513	2132	2159	2132
query29	958	480	461	461
query30	265	167	166	166
query31	1046	839	861	839
query32	112	56	51	51
query33	771	298	299	298
query34	980	518	513	513
query35	913	738	764	738
query36	1170	939	975	939
query37	132	67	65	65
query38	4066	3953	4048	3953
query39	1561	1470	1473	1470
query40	255	102	104	102
query41	54	50	51	50
query42	114	101	100	100
query43	559	481	494	481
query44	1274	821	824	821
query45	192	165	171	165
query46	1276	761	743	743
query47	2054	1928	1886	1886
query48	496	392	376	376
query49	894	399	413	399
query50	904	431	434	431
query51	7399	7232	7257	7232
query52	98	90	91	90
query53	269	184	181	181
query54	1244	470	473	470
query55	80	78	81	78
query56	270	257	258	257
query57	1362	1211	1189	1189
query58	226	208	215	208
query59	3281	2988	2956	2956
query60	287	259	262	259
query61	113	142	110	110
query62	860	676	703	676
query63	229	194	199	194
query64	5318	692	658	658
query65	3416	3297	3321	3297
query66	1193	298	308	298
query67	16215	15479	15508	15479
query68	4832	566	577	566
query69	434	260	259	259
query70	1173	1079	1105	1079
query71	327	246	248	246
query72	6259	4294	4151	4151
query73	798	345	358	345
query74	10399	9093	9152	9093
query75	3476	2687	2680	2680
query76	2655	1111	1112	1111
query77	437	275	282	275
query78	10653	9673	9575	9575
query79	1988	619	591	591
query80	1040	418	426	418
query81	569	224	221	221
query82	924	89	87	87
query83	230	149	140	140
query84	234	77	84	77
query85	1286	319	287	287
query86	420	289	296	289
query87	4355	4207	4302	4207
query88	3742	2374	2339	2339
query89	437	296	284	284
query90	1877	187	182	182
query91	182	151	149	149
query92	67	49	56	49
query93	2372	557	557	557
query94	717	308	309	308
query95	359	251	259	251
query96	683	280	274	274
query97	3395	3093	3168	3093
query98	228	208	195	195
query99	1585	1307	1319	1307
Total cold run time: 307346 ms
Total hot run time: 197298 ms

@doris-robot
Copy link

doris-robot commented Jul 28, 2025

ClickBench: Total hot run time: 29.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2a930da63a3455313c5f0207bbc85c2a2f56328a, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.54	0.51	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.57	0.51	0.48
query10	0.54	0.55	0.57
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	0.79	0.81	0.79
query15	0.83	0.83	0.81
query16	0.36	0.38	0.41
query17	1.06	0.96	1.00
query18	0.22	0.22	0.21
query19	1.86	1.90	1.71
query20	0.02	0.01	0.01
query21	15.40	0.59	0.58
query22	2.48	2.38	1.47
query23	16.91	1.18	0.91
query24	2.93	1.05	1.15
query25	0.16	0.15	0.12
query26	0.44	0.13	0.14
query27	0.04	0.04	0.06
query28	10.46	0.52	0.46
query29	12.59	3.20	3.17
query30	0.24	0.06	0.06
query31	2.86	0.39	0.38
query32	3.24	0.46	0.45
query33	3.00	3.04	3.00
query34	17.32	4.51	4.51
query35	4.61	4.58	4.57
query36	0.68	0.47	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.69 s
Total hot run time: 29.87 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 28, 2025

BE Regression && UT Coverage Report

Increment line coverage 91.73% (122/133) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.98% (19674/26238)
Line Coverage 68.25% (200534/293833)
Region Coverage 66.36% (119950/180767)
Branch Coverage 59.74% (60918/101968)

HappenLee
HappenLee approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit eb39ad3 into apache:branch-3.0 Aug 13, 2025
25 of 27 checks passed
@zclllyybb zclllyybb deleted the time_datetime_3 branch August 19, 2025 02:20
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Aug 19, 2025
@zclllyybb
[Enhancement-3.0](type) Support cast between time and datetime (apach…
f798195 
…e#53734)
@zclllyybb zclllyybb mentioned this pull request Aug 19, 2025
Merged
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Aug 19, 2025
@zclllyybb
[Enhancement-3.0](type) Support cast between time and datetime (apach…
ad76f21 
…e#53734)
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Open
morrySnow pushed a commit that referenced this pull request Sep 4, 2025
@zclllyybb
branch-3.1: [Enhancement-3.0](type) Support cast between time and dat…
96ed6ff 
…etime (#53734) (#54985)

cherry-pick #53734
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.8-merged dev/3.1.1-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zclllyybb @doris-robot @hello-stephen @HappenLee @dataroaring @morrySnow @Mryange