Skip to content

(#5390)fix NPE when replay colocate group #5391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wangbo merged 4 commits into from
Mar 12, 2021
Merged

(#5390)fix NPE when replay colocate group #5391

wangbo merged 4 commits into from
Mar 12, 2021

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented Feb 18, 2021 •
edited by EmmyMiao87
Loading

Proposed changes

see(Fixed #5390)
Duplicate create OlapTable with colocate group may cause NPE when replay from edit log

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

@EmmyMiao87
Copy link
Contributor

EmmyMiao87 commented Feb 24, 2021

I edit your commit log.
You can directly connect issue and pr by writing something like Fixed #xxx in the comment

morningman
morningman previously approved these changes Mar 6, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Mar 6, 2021
@morningman morningman added area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by one committer. labels Mar 6, 2021
morningman
morningman previously approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yangzhg
yangzhg approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo wangbo merged commit 543ed46 into apache:master Mar 12, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Apr 21, 2021
@wangbo @morningman-cmy
(apache#5390)fix NPE when replay colocate group (apache#5391)
0b16d73 
* (apache#5390)fix NPE when replay colocate group

* remove table id from colocate group when duplicate create table

* remove tablet id when duplicate create table,just like ddlexception

* add ut
This was referenced Aug 5, 2021
Closed
Merged
morningman pushed a commit that referenced this pull request Sep 3, 2021
@ccoffline
[Catalog] Enforce null check at Catalog.getDb and Database.getTable (#…
df54b34 
…6416)

fix #5378 #5391 #5688 #5973 #6155 and all replay NPE. All replay method can now throw MetaNotFoundException and caught to log a warning for potential inconsistent metadata cases.

try to establish a clear notice for future developer to check null.
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
(apache#5390)fix NPE when replay colocate group (apache#5391)
1d8166f 
* (apache#5390)fix NPE when replay colocate group

* remove table id from colocate group when duplicate create table

* remove tablet id when duplicate create table,just like ddlexception

* add ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman left review comments

@yangzhg yangzhg yangzhg approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management area/editlog-replay kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] NPE happends when replay colocate join index

4 participants

@wangbo @EmmyMiao87 @morningman @yangzhg