[opt](nereids) optimize normalize window #54947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33731 ms |
TPC-DS: Total hot run time: 184467 ms |
ClickBench: Total hot run time: 32.49 s |
924060929
force-pushed
the
opt-notmalize-window
branch
from
445beae to
575f7e7
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33623 ms |
TPC-DS: Total hot run time: 184724 ms |
ClickBench: Total hot run time: 32.53 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33920 ms |
TPC-DS: Total hot run time: 184990 ms |
ClickBench: Total hot run time: 32.7 s |
924060929
force-pushed
the
opt-notmalize-window
branch
from
575f7e7 to
255aabb
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33952 ms |
TPC-DS: Total hot run time: 184292 ms |
ClickBench: Total hot run time: 32.68 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
morrySnow
approved these changes
Aug 19, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
GoGoWen
approved these changes
Aug 19, 2025
github-actions
bot
added
dev/3.0.x-conflict
dev/2.1.x-conflict
dev/3.1.x-conflict
labels
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Aug 20, 2025
close apache#54577 optimize normalize window, only push down the expression's used slots to bottom projects, which the expression not contains WindowFunction, so we can push down more filter through window. for this sql: ```sql select SUBSTR(orderdate,1,10) AS dt, ROW_NUMBER() OVER(PARTITION BY orderdate ORDER BY orderid DESC) AS rn from lineorders having dt = '2025-01-01' ``` we not push down the `dt` slot under LogicalWindow, but push down [orderdate, orderid] to the bottom projects, because if we push down `dt`, the plan tree will be: ``` LogicalFilter(substr(dt#3, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2, substr(orderdate#1, 1, 10) as dt#3) ``` and can not push down filter by `PushDownFilterThroughWindow`, causing inefficiency, because dt#3 in LogicalFilter not contains in the partition key in LogicalWindow: [orderdate#2]. so we only push down orderdate in the LogicalFilter, not push down `dt`: ``` LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) ``` and then, `PushDownFilterThroughWindow` found the LogicalFilter's `orderdate#2` contains in the LogicalWindow's partition key: [orderdate#2], and can push down filter to: ``` LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) | LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') ``` (cherry picked from commit 0e669b9)
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Aug 20, 2025
close apache#54577 optimize normalize window, only push down the expression's used slots to bottom projects, which the expression not contains WindowFunction, so we can push down more filter through window. for this sql: ```sql select SUBSTR(orderdate,1,10) AS dt, ROW_NUMBER() OVER(PARTITION BY orderdate ORDER BY orderid DESC) AS rn from lineorders having dt = '2025-01-01' ``` we not push down the `dt` slot under LogicalWindow, but push down [orderdate, orderid] to the bottom projects, because if we push down `dt`, the plan tree will be: ``` LogicalFilter(substr(dt#3, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2, substr(orderdate#1, 1, 10) as dt#3) ``` and can not push down filter by `PushDownFilterThroughWindow`, causing inefficiency, because dt#3 in LogicalFilter not contains in the partition key in LogicalWindow: [orderdate#2]. so we only push down orderdate in the LogicalFilter, not push down `dt`: ``` LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) ``` and then, `PushDownFilterThroughWindow` found the LogicalFilter's `orderdate#2` contains in the LogicalWindow's partition key: [orderdate#2], and can push down filter to: ``` LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) | LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') ``` (cherry picked from commit 0e669b9)
924060929
added a commit
to 924060929/incubator-doris
that referenced
this pull request
Aug 20, 2025
close apache#54577 optimize normalize window, only push down the expression's used slots to bottom projects, which the expression not contains WindowFunction, so we can push down more filter through window. for this sql: ```sql select SUBSTR(orderdate,1,10) AS dt, ROW_NUMBER() OVER(PARTITION BY orderdate ORDER BY orderid DESC) AS rn from lineorders having dt = '2025-01-01' ``` we not push down the `dt` slot under LogicalWindow, but push down [orderdate, orderid] to the bottom projects, because if we push down `dt`, the plan tree will be: ``` LogicalFilter(substr(dt#3, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2, substr(orderdate#1, 1, 10) as dt#3) ``` and can not push down filter by `PushDownFilterThroughWindow`, causing inefficiency, because dt#3 in LogicalFilter not contains in the partition key in LogicalWindow: [orderdate#2]. so we only push down orderdate in the LogicalFilter, not push down `dt`: ``` LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) ``` and then, `PushDownFilterThroughWindow` found the LogicalFilter's `orderdate#2` contains in the LogicalWindow's partition key: [orderdate#2], and can push down filter to: ``` LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) | LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') ``` (cherry picked from commit 0e669b9)
yiguolei
pushed a commit
that referenced
this pull request
Aug 22, 2025
dataroaring
pushed a commit
that referenced
this pull request
Sep 3, 2025
morrySnow
pushed a commit
that referenced
this pull request
Sep 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #54577
optimize normalize window, only push down the expression's used slots to bottom projects, which the expression not contains WindowFunction, so we can push down more filter through window.
for this sql:
we not push down the
dtslot under LogicalWindow, but push down [orderdate, orderid]to the bottom projects, because if we push down
dt, the plan tree will be:and can not push down filter by
PushDownFilterThroughWindow, causing inefficiency,because dt#3 in LogicalFilter not contains in the partition key in LogicalWindow: [orderdate#2].
so we only push down orderdate in the LogicalFilter, not push down
dt:and then,
PushDownFilterThroughWindowfound the LogicalFilter'sorderdate#2containsin the LogicalWindow's partition key: [orderdate#2], and can push down filter to:
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)