branch-3.0: [opt](nereids) optimize normalize window (#54947) #55045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close apache#54577 optimize normalize window, only push down the expression's used slots to bottom projects, which the expression not contains WindowFunction, so we can push down more filter through window. for this sql: ```sql select SUBSTR(orderdate,1,10) AS dt, ROW_NUMBER() OVER(PARTITION BY orderdate ORDER BY orderid DESC) AS rn from lineorders having dt = '2025-01-01' ``` we not push down the `dt` slot under LogicalWindow, but push down [orderdate, orderid] to the bottom projects, because if we push down `dt`, the plan tree will be: ``` LogicalFilter(substr(dt#3, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2, substr(orderdate#1, 1, 10) as dt#3) ``` and can not push down filter by `PushDownFilterThroughWindow`, causing inefficiency, because dt#3 in LogicalFilter not contains in the partition key in LogicalWindow: [orderdate#2]. so we only push down orderdate in the LogicalFilter, not push down `dt`: ``` LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') | LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) ``` and then, `PushDownFilterThroughWindow` found the LogicalFilter's `orderdate#2` contains in the LogicalWindow's partition key: [orderdate#2], and can push down filter to: ``` LogicalWindow(rowNumber(partition by orderdate#2, order by orderid#1)) | LogicalProject(orderid#1, orderdate#2) | LogicalFilter(substr(orderdate#2, 1, 10) = '2025-01-01') ``` (cherry picked from commit 0e669b9)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
924060929
changed the title
924060929
changed the title
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40080 ms |
TPC-DS: Total hot run time: 192765 ms |
ClickBench: Total hot run time: 30.33 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39641 ms |
TPC-DS: Total hot run time: 191902 ms |
ClickBench: Total hot run time: 30.24 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from #54947