-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout. #55008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 34712 ms |
TPC-DS: Total hot run time: 184659 ms |
ClickBench: Total hot run time: 32.76 s |
|
run buildall |
TPC-H: Total hot run time: 33846 ms |
TPC-DS: Total hot run time: 185140 ms |
ClickBench: Total hot run time: 32.04 s |
FE UT Coverage ReportIncrement line coverage |
|
run p0 |
|
run cloud_p0 |
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 33846 ms |
TPC-DS: Total hot run time: 184776 ms |
|
run feut |
ClickBench: Total hot run time: 32.29 s |
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 33870 ms |
TPC-DS: Total hot run time: 184476 ms |
ClickBench: Total hot run time: 32.51 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…onnection is disconnected due to timeout. (apache#55008) ### What problem does this PR solve? bug: 1. create temporary table c(id int) properties("replication_num" = "1"); 2. set wait_timeout=5; 3. When `show data`, can always see the temporary table Additionally, in this scenario, the aliveSessionSet also cannot be properly cleared. fix: When the connection is lost, don't just call closeChannel—call cleanup instead. # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
…led (#55809) kill connection should not call `threadLocalInfo.remove();`,it will make current thread `getConnection` is null The current historical legacy issue: after killing the connection, it is not possible to execute threadLocalInfo. remove() on the corresponding thread; Resulting in more memory usage Related PR: #55008
…led (apache#55809) kill connection should not call `threadLocalInfo.remove();`,it will make current thread `getConnection` is null The current historical legacy issue: after killing the connection, it is not possible to execute threadLocalInfo. remove() on the corresponding thread; Resulting in more memory usage Related PR: apache#55008 # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java # fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/sessions/FlightSqlConnectContext.java
…led (apache#55809) kill connection should not call `threadLocalInfo.remove();`,it will make current thread `getConnection` is null The current historical legacy issue: after killing the connection, it is not possible to execute threadLocalInfo. remove() on the corresponding thread; Resulting in more memory usage Related PR: apache#55008 # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java # fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/sessions/FlightSqlConnectContext.java
What problem does this PR solve?
bug:
show data, can always see the temporary tableAdditionally, in this scenario, the aliveSessionSet also cannot be properly cleared.
fix:
When the connection is lost, don't just call closeChannel—call cleanup instead.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)