Skip to content

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Aug 28, 2025

pick: #55008, #55809

…onnection is disconnected due to timeout. (apache#55008)

### What problem does this PR solve?

bug:
1. create temporary table c(id int) properties("replication_num" = "1");
2. set wait_timeout=5;
3. When `show data`, can always see the temporary table

Additionally, in this scenario, the aliveSessionSet also cannot be
properly cleared.

fix:

When the connection is lost, don't just call closeChannel—call cleanup
instead.
# Conflicts:
#	fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
@zddr zddr requested a review from morrySnow as a code owner August 28, 2025 02:36
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Aug 28, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32719 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68926826b977b92a08fecf7d05e9b6217822d0e6, data reload: false

------ Round 1 ----------------------------------
q1	17596	5448	5450	5448
q2	2012	397	279	279
q3	11820	1223	756	756
q4	10444	871	464	464
q5	9650	2389	2113	2113
q6	187	165	129	129
q7	892	739	615	615
q8	9331	1433	1156	1156
q9	5265	4907	4960	4907
q10	6777	2258	1807	1807
q11	475	280	277	277
q12	338	354	211	211
q13	17764	3549	2986	2986
q14	239	231	208	208
q15	523	470	461	461
q16	432	425	383	383
q17	596	862	374	374
q18	6858	6441	6436	6436
q19	1206	953	526	526
q20	338	342	202	202
q21	2805	2151	2019	2019
q22	1050	1011	962	962
Total cold run time: 106598 ms
Total hot run time: 32719 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5512	5455	5462	5455
q2	227	328	236	236
q3	2247	2657	2294	2294
q4	1330	1778	1434	1434
q5	4372	4970	4991	4970
q6	167	168	126	126
q7	2093	2077	1867	1867
q8	2664	2882	2743	2743
q9	7429	7361	7326	7326
q10	3052	3319	2727	2727
q11	568	526	494	494
q12	689	771	588	588
q13	3450	3770	3205	3205
q14	293	303	260	260
q15	514	483	472	472
q16	440	495	442	442
q17	1245	1751	1274	1274
q18	7508	7483	7286	7286
q19	784	1057	1102	1057
q20	2051	2081	1909	1909
q21	5304	4857	4495	4495
q22	1082	1098	1047	1047
Total cold run time: 53021 ms
Total hot run time: 51707 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192839 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 68926826b977b92a08fecf7d05e9b6217822d0e6, data reload: false

query1	935	398	405	398
query2	6232	1914	1865	1865
query3	8683	197	193	193
query4	33810	24096	23714	23714
query5	4258	607	431	431
query6	306	215	175	175
query7	4199	494	311	311
query8	293	235	229	229
query9	9362	2609	2582	2582
query10	491	329	267	267
query11	18187	15400	15794	15400
query12	170	116	103	103
query13	1564	547	426	426
query14	10732	7132	7077	7077
query15	277	200	167	167
query16	7982	693	520	520
query17	1576	790	611	611
query18	2186	416	326	326
query19	233	197	167	167
query20	123	124	130	124
query21	216	131	109	109
query22	4512	4667	4451	4451
query23	35113	34015	34400	34015
query24	7328	2778	2752	2752
query25	549	491	432	432
query26	808	293	189	189
query27	2101	484	372	372
query28	5063	2228	2205	2205
query29	722	609	464	464
query30	240	190	173	173
query31	1022	925	838	838
query32	100	65	60	60
query33	544	363	314	314
query34	748	860	539	539
query35	797	817	733	733
query36	1024	1060	986	986
query37	112	99	67	67
query38	4023	4068	3935	3935
query39	1567	1473	1511	1473
query40	214	125	112	112
query41	50	51	52	51
query42	120	104	106	104
query43	514	499	474	474
query44	1446	846	842	842
query45	194	181	178	178
query46	904	1079	685	685
query47	1936	1953	1904	1904
query48	420	437	359	359
query49	730	501	410	410
query50	668	708	436	436
query51	7296	7430	7215	7215
query52	103	105	100	100
query53	246	267	196	196
query54	558	571	479	479
query55	85	78	82	78
query56	293	300	263	263
query57	1295	1257	1208	1208
query58	238	225	229	225
query59	3093	3090	3027	3027
query60	296	293	273	273
query61	121	112	112	112
query62	794	745	703	703
query63	239	200	194	194
query64	3725	1013	660	660
query65	3372	3294	3318	3294
query66	828	430	338	338
query67	16304	15646	15641	15641
query68	7557	831	533	533
query69	494	309	274	274
query70	1216	1127	1098	1098
query71	377	307	270	270
query72	5723	3693	3825	3693
query73	645	752	372	372
query74	10181	9075	8994	8994
query75	3216	3176	2707	2707
query76	2948	1162	766	766
query77	489	379	276	276
query78	10456	10503	9525	9525
query79	3614	889	589	589
query80	733	529	442	442
query81	514	253	220	220
query82	574	113	91	91
query83	162	163	145	145
query84	240	100	77	77
query85	785	371	298	298
query86	395	308	304	304
query87	4267	4346	4248	4248
query88	5260	2427	2394	2394
query89	403	327	290	290
query90	1763	193	189	189
query91	137	139	109	109
query92	64	55	54	54
query93	2602	882	537	537
query94	695	387	310	310
query95	346	283	270	270
query96	495	602	291	291
query97	3228	3266	3205	3205
query98	236	218	196	196
query99	1502	1425	1318	1318
Total cold run time: 295587 ms
Total hot run time: 192839 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 68926826b977b92a08fecf7d05e9b6217822d0e6, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.66	0.11	0.11
query5	0.53	0.51	0.50
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.60	0.50	0.49
query10	0.55	0.56	0.54
query11	0.18	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	0.77	0.79	0.79
query15	0.84	0.82	0.84
query16	0.37	0.38	0.38
query17	1.06	1.00	1.00
query18	0.24	0.22	0.23
query19	1.91	1.88	1.83
query20	0.02	0.01	0.01
query21	15.40	0.95	0.60
query22	0.74	0.84	0.54
query23	15.18	1.40	0.52
query24	2.95	1.43	1.89
query25	0.14	0.07	0.06
query26	0.24	0.14	0.13
query27	0.04	0.05	0.04
query28	14.38	1.02	0.44
query29	12.56	3.97	3.27
query30	0.27	0.10	0.07
query31	2.80	0.60	0.39
query32	3.22	0.53	0.46
query33	2.99	3.01	3.08
query34	16.68	5.17	4.57
query35	4.58	4.57	4.53
query36	0.66	0.51	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 104.34 s
Total hot run time: 29.22 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow changed the title branch-3.1:[fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout. (#55008) branch-3.1:[fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout. #55008 Aug 28, 2025
@morrySnow
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32783 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 68926826b977b92a08fecf7d05e9b6217822d0e6, data reload: false

------ Round 1 ----------------------------------
q1	17579	5483	5491	5483
q2	2032	392	289	289
q3	12029	1256	747	747
q4	10262	879	452	452
q5	8640	2436	2144	2144
q6	184	168	137	137
q7	925	763	611	611
q8	9360	1439	1184	1184
q9	5278	4939	4928	4928
q10	6780	2259	1823	1823
q11	475	289	264	264
q12	345	365	207	207
q13	17763	3624	3036	3036
q14	219	229	214	214
q15	531	474	456	456
q16	419	432	386	386
q17	625	876	380	380
q18	6971	6431	6324	6324
q19	1213	970	528	528
q20	338	349	210	210
q21	2939	2197	1989	1989
q22	1035	997	991	991
Total cold run time: 105942 ms
Total hot run time: 32783 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5568	5573	5532	5532
q2	237	327	240	240
q3	2261	2627	2274	2274
q4	1345	1775	1382	1382
q5	4421	4960	4974	4960
q6	177	164	130	130
q7	2070	1951	1863	1863
q8	2648	2830	2765	2765
q9	7285	7307	7236	7236
q10	3036	3271	2747	2747
q11	591	537	491	491
q12	658	770	657	657
q13	3449	3808	3214	3214
q14	282	305	289	289
q15	512	464	464	464
q16	433	487	450	450
q17	1277	1746	1279	1279
q18	7729	7378	7457	7378
q19	807	1103	1110	1103
q20	2036	2032	1892	1892
q21	5430	4890	4512	4512
q22	1085	1067	1045	1045
Total cold run time: 53337 ms
Total hot run time: 51903 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192466 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 68926826b977b92a08fecf7d05e9b6217822d0e6, data reload: false

query1	948	401	441	401
query2	6093	1962	1864	1864
query3	8702	198	194	194
query4	33226	23907	23473	23473
query5	3645	578	454	454
query6	287	204	184	184
query7	4210	496	320	320
query8	309	249	252	249
query9	9324	2623	2641	2623
query10	470	332	261	261
query11	17771	15660	15302	15302
query12	157	108	108	108
query13	1561	528	429	429
query14	9941	6600	7692	6600
query15	245	190	189	189
query16	8069	668	462	462
query17	1588	766	596	596
query18	2117	426	308	308
query19	217	195	168	168
query20	127	124	127	124
query21	211	134	112	112
query22	4601	4720	4388	4388
query23	34911	34291	34105	34105
query24	7202	2658	2673	2658
query25	526	474	410	410
query26	787	285	170	170
query27	2032	493	347	347
query28	5406	2231	2202	2202
query29	726	580	450	450
query30	241	196	159	159
query31	1008	918	828	828
query32	103	57	54	54
query33	538	383	320	320
query34	769	889	541	541
query35	783	821	753	753
query36	1012	1052	951	951
query37	103	93	69	69
query38	4041	4053	4041	4041
query39	1526	1486	1478	1478
query40	211	118	106	106
query41	47	54	46	46
query42	115	107	104	104
query43	505	532	492	492
query44	1362	831	824	824
query45	188	182	168	168
query46	891	1068	674	674
query47	1941	1969	1938	1938
query48	410	434	344	344
query49	717	515	413	413
query50	670	703	446	446
query51	7444	7329	7104	7104
query52	108	99	96	96
query53	245	267	204	204
query54	556	567	498	498
query55	82	81	82	81
query56	285	303	283	283
query57	1271	1289	1213	1213
query58	251	234	226	226
query59	3040	3155	3067	3067
query60	306	311	277	277
query61	138	135	130	130
query62	825	774	704	704
query63	234	197	209	197
query64	3921	1102	728	728
query65	3362	3294	3312	3294
query66	769	413	317	317
query67	16305	15789	15633	15633
query68	7129	828	540	540
query69	496	337	275	275
query70	1170	1112	1145	1112
query71	379	304	268	268
query72	5908	3806	3773	3773
query73	649	750	350	350
query74	10246	9375	9329	9329
query75	3217	3144	2665	2665
query76	2965	1192	761	761
query77	462	361	276	276
query78	10722	10522	9643	9643
query79	3004	897	611	611
query80	1385	528	440	440
query81	536	252	219	219
query82	641	118	88	88
query83	171	164	151	151
query84	239	106	78	78
query85	854	355	297	297
query86	476	311	276	276
query87	4301	4321	4236	4236
query88	5072	2437	2398	2398
query89	409	336	298	298
query90	1766	189	189	189
query91	146	141	107	107
query92	65	56	52	52
query93	2609	908	541	541
query94	734	396	301	301
query95	350	284	269	269
query96	497	618	290	290
query97	3194	3299	3186	3186
query98	244	222	204	204
query99	1334	1400	1291	1291
Total cold run time: 293102 ms
Total hot run time: 192466 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.46 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 68926826b977b92a08fecf7d05e9b6217822d0e6, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.04	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.11
query5	0.51	0.52	0.51
query6	1.12	0.73	0.74
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.60	0.50	0.50
query10	0.55	0.55	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	0.78	0.81	0.79
query15	0.85	0.83	0.82
query16	0.39	0.38	0.39
query17	1.02	1.01	1.06
query18	0.25	0.22	0.22
query19	1.97	1.73	1.79
query20	0.01	0.01	0.01
query21	15.38	0.90	0.56
query22	0.74	0.99	0.63
query23	14.97	1.40	0.54
query24	3.34	0.71	1.24
query25	0.15	0.16	0.07
query26	0.22	0.15	0.14
query27	0.07	0.05	0.05
query28	13.49	1.04	0.44
query29	12.55	3.96	3.25
query30	0.25	0.08	0.06
query31	2.83	0.60	0.36
query32	3.27	0.54	0.48
query33	2.97	3.02	3.06
query34	16.86	5.21	4.50
query35	4.60	4.57	4.55
query36	0.64	0.49	0.48
query37	0.10	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 103.8 s
Total hot run time: 28.46 s

@shuke987
Copy link
Collaborator

shuke987 commented Sep 8, 2025

run nonConcurrent

@zddr zddr marked this pull request as draft September 9, 2025 07:29
@zddr zddr marked this pull request as ready for review September 10, 2025 10:41
@zddr
Copy link
Contributor Author

zddr commented Sep 10, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32951 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2b227565f892a09f98ff10d018a078a8f3aeb92c, data reload: false

------ Round 1 ----------------------------------
q1	17618	5543	5474	5474
q2	2030	416	283	283
q3	12221	1266	762	762
q4	10564	898	458	458
q5	9571	2415	2167	2167
q6	196	165	134	134
q7	915	723	630	630
q8	9340	1444	1193	1193
q9	5300	4981	4959	4959
q10	6804	2318	1823	1823
q11	491	280	263	263
q12	346	365	215	215
q13	17780	3632	3016	3016
q14	224	232	219	219
q15	516	468	465	465
q16	428	431	367	367
q17	621	893	360	360
q18	6830	6587	6410	6410
q19	1085	970	571	571
q20	319	336	213	213
q21	2813	2208	1977	1977
q22	1039	1046	992	992
Total cold run time: 107051 ms
Total hot run time: 32951 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5547	5543	5485	5485
q2	234	325	226	226
q3	2279	2613	2311	2311
q4	1472	1822	1393	1393
q5	4429	5097	4991	4991
q6	172	167	128	128
q7	2125	1933	1819	1819
q8	2672	2880	2755	2755
q9	7409	7355	7282	7282
q10	3102	3242	2799	2799
q11	594	519	502	502
q12	633	789	588	588
q13	3438	3731	3166	3166
q14	275	302	282	282
q15	530	467	458	458
q16	420	497	431	431
q17	1244	1765	1283	1283
q18	7704	7582	7431	7431
q19	819	1168	1131	1131
q20	2021	2056	1892	1892
q21	5384	4988	4649	4649
q22	1092	1044	1054	1044
Total cold run time: 53595 ms
Total hot run time: 52046 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191969 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2b227565f892a09f98ff10d018a078a8f3aeb92c, data reload: false

query1	957	402	388	388
query2	6231	1930	1817	1817
query3	8686	211	208	208
query4	33668	23843	23561	23561
query5	3679	598	470	470
query6	286	210	184	184
query7	4219	493	331	331
query8	324	251	260	251
query9	9533	2671	2636	2636
query10	469	332	264	264
query11	17937	15487	15209	15209
query12	152	109	106	106
query13	1558	536	427	427
query14	9459	7212	6708	6708
query15	255	192	186	186
query16	8125	668	504	504
query17	1616	757	612	612
query18	2206	425	337	337
query19	240	187	163	163
query20	127	135	124	124
query21	209	130	107	107
query22	4606	4731	4456	4456
query23	34764	34265	33865	33865
query24	7574	2704	2685	2685
query25	557	516	442	442
query26	1182	290	171	171
query27	2047	482	370	370
query28	5032	2283	2227	2227
query29	795	610	480	480
query30	242	202	167	167
query31	1041	935	814	814
query32	88	56	57	56
query33	503	383	307	307
query34	752	873	514	514
query35	789	832	700	700
query36	1021	1070	932	932
query37	111	90	66	66
query38	4027	3999	3935	3935
query39	1542	1480	1522	1480
query40	213	123	111	111
query41	49	48	54	48
query42	132	105	104	104
query43	521	510	486	486
query44	1305	832	828	828
query45	195	183	172	172
query46	885	1080	676	676
query47	1974	1994	1915	1915
query48	408	430	355	355
query49	779	495	412	412
query50	676	711	446	446
query51	7420	7386	7186	7186
query52	98	104	91	91
query53	229	260	200	200
query54	569	572	485	485
query55	83	82	80	80
query56	282	273	271	271
query57	1261	1277	1239	1239
query58	240	228	231	228
query59	3036	3166	3064	3064
query60	309	303	277	277
query61	122	119	120	119
query62	796	759	705	705
query63	227	190	192	190
query64	4489	1013	675	675
query65	3376	3267	3297	3267
query66	970	412	314	314
query67	16666	15787	15759	15759
query68	7682	824	549	549
query69	494	300	275	275
query70	1193	1120	1128	1120
query71	437	306	268	268
query72	5168	3739	3981	3739
query73	642	746	354	354
query74	10219	9472	8932	8932
query75	3827	3177	2675	2675
query76	3418	1176	767	767
query77	769	395	284	284
query78	10172	10494	9572	9572
query79	5366	873	585	585
query80	648	525	422	422
query81	482	264	224	224
query82	236	119	91	91
query83	163	166	145	145
query84	282	106	84	84
query85	746	364	308	308
query86	357	314	294	294
query87	4355	4343	4216	4216
query88	4309	2415	2391	2391
query89	429	334	295	295
query90	2049	187	189	187
query91	139	142	112	112
query92	62	57	53	53
query93	3729	900	528	528
query94	656	420	291	291
query95	345	284	271	271
query96	487	615	289	289
query97	3216	3269	3152	3152
query98	229	220	206	206
query99	1434	1406	1327	1327
Total cold run time: 297659 ms
Total hot run time: 191969 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2b227565f892a09f98ff10d018a078a8f3aeb92c, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.11	0.10
query5	0.53	0.51	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.50
query10	0.55	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.61	0.58
query14	0.79	0.82	0.81
query15	0.83	0.84	0.83
query16	0.39	0.41	0.38
query17	1.05	1.04	1.07
query18	0.24	0.22	0.22
query19	1.88	1.81	1.80
query20	0.01	0.01	0.02
query21	15.42	0.94	0.58
query22	0.74	0.81	0.78
query23	14.98	1.39	0.61
query24	2.94	0.77	2.08
query25	0.16	0.14	0.08
query26	0.32	0.16	0.15
query27	0.06	0.04	0.04
query28	13.90	0.99	0.44
query29	12.64	3.96	3.27
query30	0.25	0.09	0.06
query31	2.82	0.58	0.38
query32	3.23	0.54	0.46
query33	3.04	3.03	3.06
query34	16.45	5.25	4.54
query35	4.60	4.61	4.56
query36	0.63	0.51	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.10	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.58 s
Total hot run time: 28.96 s

@morrySnow morrySnow merged commit 5a8ce14 into apache:branch-3.1 Sep 11, 2025
22 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants