-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.1:[fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout. #55008 #55396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection is disconnected due to timeout. (apache#55008) ### What problem does this PR solve? bug: 1. create temporary table c(id int) properties("replication_num" = "1"); 2. set wait_timeout=5; 3. When `show data`, can always see the temporary table Additionally, in this scenario, the aliveSessionSet also cannot be properly cleared. fix: When the connection is lost, don't just call closeChannel—call cleanup instead. # Conflicts: # fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32719 ms |
TPC-DS: Total hot run time: 192839 ms |
ClickBench: Total hot run time: 29.22 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
|
run buildall |
TPC-H: Total hot run time: 32783 ms |
TPC-DS: Total hot run time: 192466 ms |
ClickBench: Total hot run time: 28.46 s |
Collaborator
|
run nonConcurrent |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32951 ms |
TPC-DS: Total hot run time: 191969 ms |
ClickBench: Total hot run time: 28.96 s |
morrySnow
approved these changes
Sep 11, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick: #55008, #55809