Skip to content

Conversation

@zclllyybb
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

when the input datetime has decimal part start with zero, the result was wrong before. now fixed.

before:

mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.120 |
+-------------------------------------------+

now:

mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.012 |
+-------------------------------------------+

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 33755 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9d89736590113b64e955e6004206e3736ac49ed6, data reload: false

------ Round 1 ----------------------------------
q1	17614	5260	5099	5099
q2	1921	288	182	182
q3	10305	1262	724	724
q4	10216	989	551	551
q5	7539	2364	2298	2298
q6	177	159	132	132
q7	899	732	601	601
q8	9302	1282	1084	1084
q9	6958	5080	5131	5080
q10	6924	2386	1956	1956
q11	478	292	271	271
q12	348	360	218	218
q13	17779	3641	3018	3018
q14	225	235	215	215
q15	567	495	483	483
q16	425	412	375	375
q17	602	845	363	363
q18	7784	7025	6964	6964
q19	1128	939	576	576
q20	350	343	220	220
q21	3998	3257	2374	2374
q22	1079	1024	971	971
Total cold run time: 106618 ms
Total hot run time: 33755 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5240	5148	5154	5148
q2	235	321	218	218
q3	2184	2655	2285	2285
q4	1345	1764	1392	1392
q5	4193	4432	4579	4432
q6	220	179	132	132
q7	1968	2012	1805	1805
q8	2664	2658	2664	2658
q9	7362	7185	7291	7185
q10	3135	3351	2933	2933
q11	614	511	511	511
q12	725	807	654	654
q13	3496	3867	3320	3320
q14	376	397	265	265
q15	518	478	478	478
q16	456	480	441	441
q17	1240	1505	1360	1360
q18	7891	7595	7804	7595
q19	846	840	867	840
q20	2112	1985	1811	1811
q21	4802	4258	4289	4258
q22	1109	1050	964	964
Total cold run time: 52731 ms
Total hot run time: 50685 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.57% (16769/28150)
Line Coverage 48.51% (152553/314481)
Region Coverage 37.46% (115925/309495)
Branch Coverage 40.40% (51226/126804)

@doris-robot
Copy link

TPC-DS: Total hot run time: 184602 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9d89736590113b64e955e6004206e3736ac49ed6, data reload: false

query1	1002	376	405	376
query2	6524	1713	1712	1712
query3	6734	221	221	221
query4	26319	23821	22768	22768
query5	4353	647	502	502
query6	284	211	193	193
query7	4619	488	281	281
query8	261	228	212	212
query9	8601	2846	2850	2846
query10	506	323	290	290
query11	15315	15259	14733	14733
query12	159	113	107	107
query13	1671	542	429	429
query14	8737	5832	5902	5832
query15	207	181	171	171
query16	7190	607	456	456
query17	1212	724	600	600
query18	1993	429	324	324
query19	195	184	172	172
query20	123	118	118	118
query21	213	121	110	110
query22	4105	4015	4047	4015
query23	34273	33311	33562	33311
query24	8189	2359	2351	2351
query25	539	484	397	397
query26	1236	273	165	165
query27	2744	504	336	336
query28	4362	2218	2192	2192
query29	811	548	442	442
query30	283	221	185	185
query31	880	818	725	725
query32	80	73	70	70
query33	552	367	331	331
query34	798	835	516	516
query35	768	844	763	763
query36	985	999	912	912
query37	121	103	90	90
query38	4064	4046	3996	3996
query39	1470	1419	1413	1413
query40	220	132	119	119
query41	60	56	53	53
query42	124	110	116	110
query43	501	478	479	478
query44	1363	839	847	839
query45	170	180	173	173
query46	851	1003	658	658
query47	1757	1800	1702	1702
query48	379	419	312	312
query49	715	486	392	392
query50	647	674	396	396
query51	4049	4185	4142	4142
query52	110	108	103	103
query53	234	264	198	198
query54	591	600	525	525
query55	88	85	87	85
query56	324	306	300	300
query57	1181	1188	1139	1139
query58	277	263	272	263
query59	2593	2631	2547	2547
query60	346	333	327	327
query61	129	122	141	122
query62	800	762	670	670
query63	229	191	190	190
query64	4452	1083	721	721
query65	4320	4237	4220	4220
query66	1154	427	332	332
query67	15539	15149	15002	15002
query68	8160	917	575	575
query69	492	320	278	278
query70	1212	1125	1141	1125
query71	456	332	310	310
query72	5832	4812	4759	4759
query73	730	610	352	352
query74	8887	8975	8903	8903
query75	3817	3060	2631	2631
query76	3670	1133	748	748
query77	777	392	320	320
query78	9591	9677	8901	8901
query79	2154	830	607	607
query80	611	541	456	456
query81	480	262	226	226
query82	456	140	105	105
query83	251	254	239	239
query84	248	93	81	81
query85	788	367	396	367
query86	332	333	315	315
query87	4182	4264	4138	4138
query88	3140	2163	2146	2146
query89	387	318	286	286
query90	1919	218	207	207
query91	142	137	115	115
query92	92	69	68	68
query93	1182	971	643	643
query94	676	403	310	310
query95	390	312	308	308
query96	473	570	266	266
query97	2630	2720	2547	2547
query98	229	216	210	210
query99	1545	1396	1279	1279
Total cold run time: 271612 ms
Total hot run time: 184602 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9d89736590113b64e955e6004206e3736ac49ed6, data reload: false

query1	0.05	0.04	0.03
query2	0.09	0.04	0.04
query3	0.24	0.07	0.06
query4	1.62	0.10	0.11
query5	0.42	0.42	0.41
query6	1.17	0.65	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.52	0.51
query10	0.57	0.57	0.58
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	0.80	0.82	0.83
query15	0.86	0.85	0.86
query16	0.39	0.39	0.38
query17	1.01	1.02	1.05
query18	0.21	0.19	0.20
query19	1.92	1.85	1.83
query20	0.01	0.01	0.01
query21	15.40	0.93	0.59
query22	0.79	1.24	0.64
query23	14.91	1.39	0.62
query24	6.79	1.59	0.97
query25	0.52	0.24	0.06
query26	0.56	0.15	0.13
query27	0.06	0.05	0.05
query28	10.43	0.87	0.42
query29	12.60	3.89	3.24
query30	3.08	3.02	2.98
query31	2.83	0.58	0.38
query32	3.22	0.55	0.49
query33	3.10	3.13	3.10
query34	16.05	5.52	4.80
query35	4.92	4.88	4.95
query36	0.70	0.51	0.49
query37	0.09	0.07	0.08
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.45 s
Total hot run time: 32.56 s

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33501 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0bd4e72a0e3dfcc3588a1ce51c8fe32cc9b43638, data reload: false

------ Round 1 ----------------------------------
q1	17592	5222	5081	5081
q2	1928	284	188	188
q3	10299	1223	701	701
q4	10216	976	513	513
q5	7517	2363	2293	2293
q6	179	157	126	126
q7	898	725	583	583
q8	9310	1253	1042	1042
q9	6858	5037	5113	5037
q10	6925	2369	1956	1956
q11	501	286	277	277
q12	344	342	211	211
q13	17798	3607	3046	3046
q14	232	243	212	212
q15	552	466	484	466
q16	420	415	379	379
q17	586	855	353	353
q18	7280	7121	7055	7055
q19	1107	931	537	537
q20	334	334	224	224
q21	3853	2575	2273	2273
q22	1065	1037	948	948
Total cold run time: 105794 ms
Total hot run time: 33501 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5122	5108	5085	5085
q2	245	329	219	219
q3	2170	2715	2314	2314
q4	1344	1724	1388	1388
q5	4208	4248	4489	4248
q6	209	169	151	151
q7	2065	1968	1829	1829
q8	2566	2751	2573	2573
q9	7217	7222	7312	7222
q10	3088	3289	2826	2826
q11	591	542	486	486
q12	778	805	625	625
q13	3591	3932	3260	3260
q14	298	297	268	268
q15	539	482	473	473
q16	425	495	439	439
q17	1273	1608	1378	1378
q18	7710	7690	7598	7598
q19	807	855	840	840
q20	1959	1935	1792	1792
q21	4662	4294	4223	4223
q22	1080	1025	1001	1001
Total cold run time: 51947 ms
Total hot run time: 50238 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183979 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0bd4e72a0e3dfcc3588a1ce51c8fe32cc9b43638, data reload: false

query1	1014	381	416	381
query2	6548	1726	1780	1726
query3	6741	222	222	222
query4	26583	23242	23284	23242
query5	4322	605	477	477
query6	315	215	213	213
query7	4622	495	291	291
query8	290	239	228	228
query9	8606	2847	2882	2847
query10	493	327	286	286
query11	15901	15019	14827	14827
query12	169	112	120	112
query13	1659	555	418	418
query14	9092	5712	5673	5673
query15	207	183	162	162
query16	7341	653	452	452
query17	1186	709	559	559
query18	2003	390	307	307
query19	196	175	163	163
query20	127	120	114	114
query21	210	119	109	109
query22	4074	4150	4068	4068
query23	34130	33525	33086	33086
query24	8233	2400	2403	2400
query25	554	476	409	409
query26	1227	277	157	157
query27	2746	517	338	338
query28	4389	2290	2266	2266
query29	757	604	440	440
query30	286	222	184	184
query31	892	795	646	646
query32	86	73	73	73
query33	556	362	327	327
query34	795	832	503	503
query35	804	847	746	746
query36	936	998	937	937
query37	127	115	81	81
query38	4056	4054	3940	3940
query39	1460	1403	1400	1400
query40	224	120	118	118
query41	60	57	57	57
query42	118	109	121	109
query43	504	489	481	481
query44	1316	863	836	836
query45	171	171	171	171
query46	843	990	637	637
query47	1747	1772	1715	1715
query48	396	409	311	311
query49	725	489	385	385
query50	623	657	412	412
query51	4054	4126	3982	3982
query52	115	113	98	98
query53	228	259	187	187
query54	593	576	512	512
query55	93	86	83	83
query56	316	314	290	290
query57	1190	1159	1122	1122
query58	277	265	268	265
query59	2639	2648	2533	2533
query60	341	335	350	335
query61	125	126	122	122
query62	827	719	645	645
query63	225	212	190	190
query64	4353	996	685	685
query65	4256	4216	4182	4182
query66	1137	417	340	340
query67	15417	15207	15056	15056
query68	7672	887	570	570
query69	490	326	281	281
query70	1193	1130	1089	1089
query71	417	324	307	307
query72	5520	4708	4992	4708
query73	663	614	356	356
query74	8935	8966	8618	8618
query75	3139	3052	2615	2615
query76	3332	1115	706	706
query77	463	380	320	320
query78	9754	9610	8764	8764
query79	2986	828	587	587
query80	1570	539	478	478
query81	561	250	226	226
query82	768	131	111	111
query83	351	243	238	238
query84	250	97	82	82
query85	839	368	341	341
query86	474	308	286	286
query87	4347	4269	4202	4202
query88	3859	2179	2167	2167
query89	381	322	285	285
query90	1924	214	219	214
query91	139	134	112	112
query92	93	74	65	65
query93	2613	1014	635	635
query94	780	405	316	316
query95	396	312	302	302
query96	483	571	266	266
query97	2653	2691	2565	2565
query98	244	218	219	218
query99	1329	1404	1280	1280
Total cold run time: 275264 ms
Total hot run time: 183979 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0bd4e72a0e3dfcc3588a1ce51c8fe32cc9b43638, data reload: false

query1	0.04	0.04	0.04
query2	0.09	0.04	0.04
query3	0.24	0.07	0.07
query4	1.62	0.11	0.12
query5	0.44	0.42	0.41
query6	1.16	0.64	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.54	0.52
query10	0.57	0.57	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.64	0.62	0.60
query14	0.81	0.81	0.83
query15	0.88	0.86	0.86
query16	0.39	0.39	0.40
query17	1.04	1.02	1.03
query18	0.21	0.19	0.19
query19	1.92	1.77	1.79
query20	0.01	0.00	0.01
query21	15.39	0.92	0.59
query22	0.77	1.13	0.72
query23	14.91	1.40	0.67
query24	6.61	1.40	0.61
query25	0.52	0.19	0.14
query26	0.70	0.15	0.13
query27	0.06	0.05	0.05
query28	10.02	0.95	0.42
query29	12.59	3.83	3.26
query30	3.09	3.00	2.96
query31	2.82	0.57	0.38
query32	3.24	0.55	0.47
query33	3.03	3.10	3.13
query34	16.02	5.47	4.96
query35	4.91	4.94	4.96
query36	0.72	0.52	0.51
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.95 s
Total hot run time: 32.58 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.58% (16780/28164)
Line Coverage 48.52% (152643/314606)
Region Coverage 37.51% (116104/309559)
Branch Coverage 40.40% (51239/126836)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.13% (22665/27596)
Line Coverage 74.80% (235200/314438)
Region Coverage 61.90% (194997/315023)
Branch Coverage 66.09% (84455/127793)

@zclllyybb
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33763 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7270212ef8e156aa07d5f321167ac4f2fd8f7b82, data reload: false

------ Round 1 ----------------------------------
q1	17579	5210	5090	5090
q2	1912	277	181	181
q3	10317	1291	710	710
q4	10216	991	516	516
q5	7507	2359	2294	2294
q6	178	156	130	130
q7	888	726	589	589
q8	9296	1289	1045	1045
q9	6825	5124	5213	5124
q10	6947	2369	1973	1973
q11	476	282	265	265
q12	346	345	223	223
q13	17812	3628	3051	3051
q14	223	232	214	214
q15	563	480	472	472
q16	412	414	379	379
q17	592	850	354	354
q18	7268	7052	7102	7052
q19	1079	956	555	555
q20	335	328	215	215
q21	4095	3169	2357	2357
q22	1087	1035	974	974
Total cold run time: 105953 ms
Total hot run time: 33763 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5139	5098	5115	5098
q2	241	322	218	218
q3	2150	2673	2322	2322
q4	1366	1758	1332	1332
q5	4194	4381	4402	4381
q6	218	164	126	126
q7	2066	1977	1796	1796
q8	2610	2571	2508	2508
q9	7365	7163	7376	7163
q10	3076	3366	2886	2886
q11	589	522	516	516
q12	693	790	628	628
q13	3536	3867	3309	3309
q14	291	292	273	273
q15	525	462	508	462
q16	455	509	427	427
q17	1227	1474	1426	1426
q18	7733	7842	7420	7420
q19	899	809	853	809
q20	1945	1930	1801	1801
q21	4741	4252	4297	4252
q22	1083	1041	998	998
Total cold run time: 52142 ms
Total hot run time: 50151 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184993 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7270212ef8e156aa07d5f321167ac4f2fd8f7b82, data reload: false

query1	994	374	409	374
query2	6539	1786	1733	1733
query3	6742	223	220	220
query4	26521	23308	23450	23308
query5	4366	617	495	495
query6	303	206	202	202
query7	4628	492	296	296
query8	282	232	213	213
query9	8624	2816	2835	2816
query10	456	324	271	271
query11	15617	14914	14740	14740
query12	158	112	117	112
query13	1650	524	423	423
query14	8538	5781	5749	5749
query15	210	185	183	183
query16	7138	638	481	481
query17	951	687	578	578
query18	2002	403	307	307
query19	181	187	158	158
query20	123	121	113	113
query21	208	153	110	110
query22	3950	4179	3986	3986
query23	33962	33375	33183	33183
query24	8062	2329	2393	2329
query25	551	478	403	403
query26	1235	266	157	157
query27	2766	498	344	344
query28	4345	2222	2190	2190
query29	758	554	443	443
query30	288	214	196	196
query31	863	825	710	710
query32	80	73	74	73
query33	539	368	325	325
query34	787	847	512	512
query35	771	821	724	724
query36	973	1011	900	900
query37	118	103	83	83
query38	4015	4125	4005	4005
query39	1507	1493	1429	1429
query40	217	129	115	115
query41	61	53	51	51
query42	124	107	107	107
query43	524	490	471	471
query44	1312	836	840	836
query45	168	183	169	169
query46	851	1001	633	633
query47	1759	1789	1775	1775
query48	390	415	313	313
query49	715	513	387	387
query50	642	684	391	391
query51	4134	4102	4128	4102
query52	113	113	106	106
query53	236	265	192	192
query54	585	595	517	517
query55	89	91	83	83
query56	328	304	290	290
query57	1157	1221	1147	1147
query58	277	274	271	271
query59	2599	2728	2528	2528
query60	356	374	328	328
query61	129	128	121	121
query62	775	735	690	690
query63	231	192	190	190
query64	4288	1008	702	702
query65	4314	4244	4203	4203
query66	1164	410	325	325
query67	15547	15229	15139	15139
query68	5792	954	586	586
query69	488	341	276	276
query70	1188	1085	1080	1080
query71	427	304	302	302
query72	5639	4845	5015	4845
query73	732	712	354	354
query74	8937	9177	8673	8673
query75	3136	3063	2644	2644
query76	3176	1129	734	734
query77	490	394	328	328
query78	9423	9814	8989	8989
query79	1563	802	606	606
query80	677	540	473	473
query81	458	254	224	224
query82	197	139	107	107
query83	252	252	235	235
query84	289	98	87	87
query85	785	381	331	331
query86	349	298	317	298
query87	4194	4272	4191	4191
query88	2819	2241	2220	2220
query89	378	315	293	293
query90	1782	226	224	224
query91	142	140	115	115
query92	70	70	68	68
query93	1111	988	653	653
query94	634	401	323	323
query95	400	330	326	326
query96	489	592	280	280
query97	2608	2691	2569	2569
query98	233	220	214	214
query99	1325	1368	1289	1289
Total cold run time: 265069 ms
Total hot run time: 184993 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7270212ef8e156aa07d5f321167ac4f2fd8f7b82, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.05	0.04
query3	0.24	0.08	0.07
query4	1.62	0.11	0.11
query5	0.41	0.40	0.39
query6	1.17	0.64	0.66
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.61	0.54	0.53
query10	0.58	0.57	0.58
query11	0.16	0.10	0.10
query12	0.14	0.11	0.12
query13	0.64	0.61	0.60
query14	0.80	0.83	0.82
query15	0.88	0.86	0.85
query16	0.38	0.39	0.40
query17	1.07	1.03	1.05
query18	0.20	0.19	0.20
query19	1.92	1.86	1.80
query20	0.02	0.01	0.01
query21	15.39	0.92	0.60
query22	0.78	1.30	0.88
query23	14.78	1.41	0.63
query24	6.61	1.60	0.55
query25	0.51	0.27	0.07
query26	0.67	0.16	0.13
query27	0.06	0.05	0.05
query28	9.18	0.96	0.43
query29	12.57	3.85	3.24
query30	3.10	3.05	3.02
query31	2.82	0.58	0.38
query32	3.23	0.54	0.49
query33	3.06	3.03	3.05
query34	16.01	5.48	4.87
query35	4.87	4.92	4.96
query36	0.68	0.51	0.50
query37	0.08	0.07	0.07
query38	0.05	0.05	0.03
query39	0.03	0.02	0.03
query40	0.18	0.15	0.14
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.85 s
Total hot run time: 32.47 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.58% (16780/28165)
Line Coverage 48.50% (152615/314638)
Region Coverage 37.47% (116006/309638)
Branch Coverage 40.39% (51232/126854)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.13% (22665/27597)
Line Coverage 74.81% (235270/314475)
Region Coverage 62.01% (195391/315106)
Branch Coverage 66.19% (84603/127817)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zclllyybb zclllyybb merged commit 9cdccbb into apache:master Aug 20, 2025
28 of 31 checks passed
@zclllyybb zclllyybb deleted the fix_unix_ms branch August 20, 2025 09:02
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Aug 25, 2025
when the input datetime has decimal part start with zero, the result was
wrong before. now fixed.

before:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.120 |
+-------------------------------------------+
```

now:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.012 |
+-------------------------------------------+
```
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Aug 25, 2025
when the input datetime has decimal part start with zero, the result was
wrong before. now fixed.

before:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.120 |
+-------------------------------------------+
```

now:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.012 |
+-------------------------------------------+
```
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Sep 12, 2025
when the input datetime has decimal part start with zero, the result was
wrong before. now fixed.

before:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.120 |
+-------------------------------------------+
```

now:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.012 |
+-------------------------------------------+
```
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Sep 12, 2025
when the input datetime has decimal part start with zero, the result was
wrong before. now fixed.

before:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.120 |
+-------------------------------------------+
```

now:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.012 |
+-------------------------------------------+
```
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Sep 12, 2025
when the input datetime has decimal part start with zero, the result was
wrong before. now fixed.

before:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.120 |
+-------------------------------------------+
```

now:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.012 |
+-------------------------------------------+
```
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants