Skip to content

branch-3.1: [Fix](function) Fix wrong decimal of unix_timestamp (#55013) #55962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 12, 2025
Merged

branch-3.1: [Fix](function) Fix wrong decimal of unix_timestamp (#55013) #55962

morrySnow merged 1 commit into from
Sep 12, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Sep 12, 2025

pick #55013

@zclllyybb
[Fix](function) Fix wrong decimal of unix_timestamp (apache#55013)
7082eb0 
when the input datetime has decimal part start with zero, the result was
wrong before. now fixed.

before:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.120 |
+-------------------------------------------+
```

now:
```sql
mysql> select UNIX_TIMESTAMP('2015-11-13 10:20:19.012');
+-------------------------------------------+
| UNIX_TIMESTAMP('2015-11-13 10:20:19.012') |
+-------------------------------------------+
|                            1447381219.012 |
+-------------------------------------------+
```
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Sep 12, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Sep 12, 2025

TPC-H: Total hot run time: 32525 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7082eb00058a144be6ba865767ed2e3191802a4e, data reload: false

------ Round 1 ----------------------------------
q1	17613	5391	5406	5391
q2	2028	380	584	380
q3	11756	1240	738	738
q4	10248	867	441	441
q5	8566	2369	2112	2112
q6	178	160	133	133
q7	892	734	597	597
q8	9336	1438	1152	1152
q9	5179	4972	4894	4894
q10	6754	2257	1802	1802
q11	477	279	253	253
q12	340	353	203	203
q13	17775	3577	3024	3024
q14	239	228	206	206
q15	514	461	458	458
q16	414	435	377	377
q17	569	855	351	351
q18	6802	6442	6417	6417
q19	1222	946	520	520
q20	326	329	203	203
q21	2732	2156	1877	1877
q22	1061	1015	996	996
Total cold run time: 105021 ms
Total hot run time: 32525 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5441	5500	5623	5500
q2	234	321	247	247
q3	2252	2607	2296	2296
q4	1297	1750	1378	1378
q5	4367	4799	4969	4799
q6	168	165	129	129
q7	2065	1924	1856	1856
q8	2681	2811	2790	2790
q9	7426	7371	7318	7318
q10	3054	3356	2819	2819
q11	557	515	493	493
q12	649	725	606	606
q13	3517	3918	3275	3275
q14	283	302	271	271
q15	571	468	463	463
q16	436	492	425	425
q17	1198	1700	1272	1272
q18	7609	7591	7236	7236
q19	771	1097	1063	1063
q20	1980	2044	1880	1880
q21	5360	4923	4688	4688
q22	1060	1101	1011	1011
Total cold run time: 52976 ms
Total hot run time: 51815 ms

@doris-robot
Copy link

doris-robot commented Sep 12, 2025

TPC-DS: Total hot run time: 193347 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7082eb00058a144be6ba865767ed2e3191802a4e, data reload: false

query1	948	405	409	405
query2	6213	1977	1827	1827
query3	8707	205	199	199
query4	33733	24295	23473	23473
query5	4776	585	440	440
query6	297	202	180	180
query7	4249	482	316	316
query8	310	243	242	242
query9	9384	2636	2631	2631
query10	486	321	261	261
query11	18229	15410	15126	15126
query12	160	109	110	109
query13	1559	546	437	437
query14	9408	7363	7300	7300
query15	244	192	175	175
query16	8069	681	488	488
query17	1464	828	592	592
query18	2145	414	324	324
query19	235	195	182	182
query20	123	125	120	120
query21	208	132	111	111
query22	4583	4725	4405	4405
query23	34854	34409	34300	34300
query24	7276	2742	2754	2742
query25	546	507	452	452
query26	1202	304	182	182
query27	2012	481	367	367
query28	5101	2226	2187	2187
query29	794	614	481	481
query30	238	187	170	170
query31	1033	899	848	848
query32	97	67	64	64
query33	554	373	313	313
query34	744	857	519	519
query35	786	817	724	724
query36	1011	1070	954	954
query37	108	91	68	68
query38	4042	4055	3933	3933
query39	1539	1483	1463	1463
query40	204	122	111	111
query41	49	49	48	48
query42	127	112	104	104
query43	502	523	493	493
query44	1368	824	833	824
query45	188	184	170	170
query46	885	1064	683	683
query47	1956	1984	1937	1937
query48	416	427	353	353
query49	764	495	425	425
query50	679	695	439	439
query51	7387	7438	7293	7293
query52	101	99	93	93
query53	235	252	188	188
query54	556	549	493	493
query55	83	81	80	80
query56	278	290	257	257
query57	1294	1267	1224	1224
query58	248	229	222	222
query59	2969	3227	3021	3021
query60	309	275	268	268
query61	129	107	107	107
query62	799	746	699	699
query63	226	192	208	192
query64	4507	1008	646	646
query65	3390	3385	3345	3345
query66	965	404	315	315
query67	16391	15735	15806	15735
query68	7687	813	540	540
query69	483	309	270	270
query70	1178	1125	1094	1094
query71	359	303	269	269
query72	5816	3812	3868	3812
query73	626	738	349	349
query74	10558	9296	9127	9127
query75	3214	3160	2716	2716
query76	2975	1144	765	765
query77	523	346	282	282
query78	10482	10441	9668	9668
query79	3675	899	599	599
query80	719	527	444	444
query81	503	261	223	223
query82	676	122	90	90
query83	171	157	145	145
query84	244	106	78	78
query85	784	361	293	293
query86	399	305	318	305
query87	4370	4333	4274	4274
query88	5142	2417	2405	2405
query89	410	338	298	298
query90	1727	191	193	191
query91	140	136	109	109
query92	67	60	53	53
query93	2748	899	537	537
query94	703	401	310	310
query95	359	284	273	273
query96	491	618	277	277
query97	3190	3297	3172	3172
query98	243	213	196	196
query99	1325	1428	1308	1308
Total cold run time: 296459 ms
Total hot run time: 193347 ms

@doris-robot
Copy link

doris-robot commented Sep 12, 2025

ClickBench: Total hot run time: 29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7082eb00058a144be6ba865767ed2e3191802a4e, data reload: false

query1	0.03	0.03	0.02
query2	0.06	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.51	0.49	0.52
query6	1.12	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.59	0.50	0.51
query10	0.56	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.62	0.60	0.60
query14	0.77	0.78	0.80
query15	0.85	0.82	0.83
query16	0.38	0.40	0.41
query17	1.00	1.06	1.11
query18	0.24	0.24	0.22
query19	1.89	1.87	1.77
query20	0.01	0.01	0.01
query21	15.41	0.92	0.58
query22	0.73	1.06	0.68
query23	14.84	1.50	0.55
query24	3.25	0.99	1.55
query25	0.22	0.10	0.11
query26	0.38	0.14	0.13
query27	0.04	0.05	0.05
query28	13.45	0.98	0.43
query29	12.60	3.86	3.25
query30	0.26	0.10	0.06
query31	2.81	0.58	0.39
query32	3.22	0.54	0.47
query33	3.01	3.05	3.10
query34	16.59	5.26	4.56
query35	4.60	4.57	4.52
query36	0.64	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.39 s
Total hot run time: 29 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 12, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.54% (12761/28023)
Line Coverage 36.37% (113780/312826)
Region Coverage 34.00% (65071/191379)
Branch Coverage 31.04% (34154/110048)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 12, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.44% (21068/27561)
Line Coverage 69.73% (217444/311855)
Region Coverage 67.68% (130056/192156)
Branch Coverage 61.20% (67661/110562)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 12, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.11% (20976/27561)
Line Coverage 69.31% (216148/311855)
Region Coverage 67.21% (129157/192156)
Branch Coverage 60.80% (67222/110562)

@morrySnow morrySnow merged commit 18aa5c8 into apache:branch-3.1 Sep 12, 2025
22 of 23 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zclllyybb @hello-stephen @doris-robot @morrySnow