-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[bugfix](catalog) replace Math.abs with bitwise AND to ensure non-negative ID generation #55183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 35017 ms |
TPC-DS: Total hot run time: 185878 ms |
ClickBench: Total hot run time: 32.9 s |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 33751 ms |
TPC-DS: Total hot run time: 184889 ms |
ClickBench: Total hot run time: 32.66 s |
|
run p0 |
|
run buildall |
TPC-H: Total hot run time: 34160 ms |
TPC-DS: Total hot run time: 186342 ms |
ClickBench: Total hot run time: 33.22 s |
FE UT Coverage ReportIncrement line coverage |
208f220 to
ce9d05b
Compare
|
run buildall |
TPC-H: Total hot run time: 34296 ms |
TPC-DS: Total hot run time: 186925 ms |
ClickBench: Total hot run time: 32.96 s |
|
run buildall |
TPC-H: Total hot run time: 33704 ms |
TPC-DS: Total hot run time: 186757 ms |
ClickBench: Total hot run time: 32.85 s |
|
run buildall |
TPC-H: Total hot run time: 34362 ms |
TPC-DS: Total hot run time: 187442 ms |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
FE Regression Coverage ReportIncrement line coverage |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ative ID generation (#55183) ### What problem does this PR solve? Problem Summary: `Replace Math.abs() with bitwise AND operation in genIdByName() method` problem: - Math.abs(Long.MIN_VALUE) returns Long.MIN_VALUE (still negative) due to overflow - This violates the requirement that external db/table IDs must be >= 0 - Could cause issues in DescriptorTable.toThrift() as mentioned in comments fix: - Use bitwise AND with Long.MAX_VALUE to clear the sign bit - Guarantees non-negative result in range [0, Long.MAX_VALUE] - Better performance than Math.abs() conditional check ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…ative ID generation (#55183) ### What problem does this PR solve? Problem Summary: `Replace Math.abs() with bitwise AND operation in genIdByName() method` problem: - Math.abs(Long.MIN_VALUE) returns Long.MIN_VALUE (still negative) due to overflow - This violates the requirement that external db/table IDs must be >= 0 - Could cause issues in DescriptorTable.toThrift() as mentioned in comments fix: - Use bitwise AND with Long.MAX_VALUE to clear the sign bit - Guarantees non-negative result in range [0, Long.MAX_VALUE] - Better performance than Math.abs() conditional check ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…sure non-negative ID generation apache#55183
…ative ID generation (apache#55183) ### What problem does this PR solve? Problem Summary: `Replace Math.abs() with bitwise AND operation in genIdByName() method` problem: - Math.abs(Long.MIN_VALUE) returns Long.MIN_VALUE (still negative) due to overflow - This violates the requirement that external db/table IDs must be >= 0 - Could cause issues in DescriptorTable.toThrift() as mentioned in comments fix: - Use bitwise AND with Long.MAX_VALUE to clear the sign bit - Guarantees non-negative result in range [0, Long.MAX_VALUE] - Better performance than Math.abs() conditional check ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
What problem does this PR solve?
Problem Summary:
Replace Math.abs() with bitwise AND operation in genIdByName() methodproblem:
fix:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)