Skip to content

Conversation

@felixwluo
Copy link
Contributor

What problem does this PR solve?

pick: #55183

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@felixwluo
Copy link
Contributor Author

run buildall

@felixwluo
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39767 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b8950aa572e7fd349834168e524214093486bc56, data reload: false

------ Round 1 ----------------------------------
q1	17602	6724	6678	6678
q2	2039	204	179	179
q3	10653	1123	1165	1123
q4	10524	801	681	681
q5	7728	2933	2829	2829
q6	212	138	135	135
q7	958	618	610	610
q8	9370	1917	1961	1917
q9	6614	6371	6427	6371
q10	7036	2281	2295	2281
q11	463	265	264	264
q12	403	211	218	211
q13	17794	2973	2977	2973
q14	234	210	208	208
q15	520	469	466	466
q16	499	378	384	378
q17	991	602	645	602
q18	7349	6668	6607	6607
q19	1395	1112	1000	1000
q20	472	197	209	197
q21	3852	3081	3208	3081
q22	1066	976	995	976
Total cold run time: 107774 ms
Total hot run time: 39767 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6607	6612	6571	6571
q2	330	227	240	227
q3	2922	2872	2951	2872
q4	2064	1798	1899	1798
q5	5707	5712	5716	5712
q6	206	126	127	126
q7	2189	1812	1766	1766
q8	3358	3515	3595	3515
q9	8825	8931	8862	8862
q10	3559	3491	3483	3483
q11	595	496	491	491
q12	818	578	583	578
q13	10128	3227	3126	3126
q14	305	273	272	272
q15	522	465	467	465
q16	487	444	444	444
q17	1851	1612	1618	1612
q18	8205	7793	7648	7648
q19	1722	1496	1528	1496
q20	2078	1830	1842	1830
q21	5154	5176	5014	5014
q22	1159	1031	1027	1027
Total cold run time: 68791 ms
Total hot run time: 58935 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192352 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b8950aa572e7fd349834168e524214093486bc56, data reload: false

query1	937	407	405	405
query2	6263	1907	1880	1880
query3	8681	201	199	199
query4	33940	23556	23869	23556
query5	4113	460	446	446
query6	299	177	181	177
query7	4214	302	312	302
query8	282	221	228	221
query9	9398	2569	2564	2564
query10	496	266	261	261
query11	18101	15304	15183	15183
query12	159	107	102	102
query13	1554	452	436	436
query14	8407	7631	7364	7364
query15	256	174	173	173
query16	8153	499	554	499
query17	1627	607	599	599
query18	2218	306	317	306
query19	391	167	174	167
query20	120	117	121	117
query21	208	110	108	108
query22	4812	4448	4425	4425
query23	35317	34275	33947	33947
query24	11950	2976	2880	2880
query25	695	423	419	419
query26	1804	169	177	169
query27	2924	342	376	342
query28	7642	2148	2164	2148
query29	1072	465	441	441
query30	262	161	158	158
query31	1086	825	839	825
query32	107	57	61	57
query33	781	320	314	314
query34	1144	500	509	500
query35	831	744	750	744
query36	1090	969	944	944
query37	269	72	64	64
query38	4048	3922	4007	3922
query39	1511	1477	1472	1472
query40	247	112	103	103
query41	54	49	49	49
query42	111	107	101	101
query43	504	486	471	471
query44	1280	798	807	798
query45	195	170	173	170
query46	1162	728	721	721
query47	1990	1938	1958	1938
query48	474	369	382	369
query49	1158	406	417	406
query50	839	410	422	410
query51	7575	7295	7249	7249
query52	110	89	90	89
query53	266	183	184	183
query54	1169	467	462	462
query55	78	81	79	79
query56	277	235	251	235
query57	1313	1191	1216	1191
query58	225	207	217	207
query59	3128	3029	3108	3029
query60	300	275	273	273
query61	147	116	123	116
query62	864	698	677	677
query63	227	191	189	189
query64	5238	663	646	646
query65	3354	3256	3317	3256
query66	1378	296	297	296
query67	16184	15649	15503	15503
query68	5316	555	576	555
query69	436	279	261	261
query70	1246	1158	1068	1068
query71	343	256	258	256
query72	6162	4060	4030	4030
query73	747	348	349	348
query74	10648	9042	8953	8953
query75	3383	2620	2654	2620
query76	3185	1101	1009	1009
query77	397	276	265	265
query78	10569	9612	9557	9557
query79	2396	608	600	600
query80	1073	422	426	422
query81	537	219	218	218
query82	609	87	85	85
query83	228	138	142	138
query84	248	82	82	82
query85	1361	310	299	299
query86	442	309	303	303
query87	4390	4206	4193	4193
query88	4174	2390	2376	2376
query89	416	283	284	283
query90	2015	186	189	186
query91	180	146	151	146
query92	67	50	50	50
query93	2341	555	555	555
query94	956	294	279	279
query95	361	257	254	254
query96	638	281	282	281
query97	3262	3156	3144	3144
query98	222	204	197	197
query99	1481	1287	1303	1287
Total cold run time: 306838 ms
Total hot run time: 192352 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b8950aa572e7fd349834168e524214093486bc56, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.10	0.11
query5	0.50	0.50	0.51
query6	1.13	0.72	0.72
query7	0.01	0.02	0.02
query8	0.03	0.03	0.03
query9	0.56	0.50	0.51
query10	0.56	0.55	0.58
query11	0.14	0.10	0.10
query12	0.13	0.11	0.11
query13	0.61	0.59	0.59
query14	0.78	0.78	0.80
query15	0.83	0.82	0.81
query16	0.39	0.41	0.39
query17	1.00	1.03	0.99
query18	0.25	0.22	0.22
query19	1.93	1.80	1.82
query20	0.01	0.01	0.02
query21	15.38	0.56	0.57
query22	2.28	2.41	2.11
query23	17.17	1.12	0.84
query24	3.45	0.83	0.89
query25	0.32	0.16	0.11
query26	0.28	0.14	0.15
query27	0.05	0.03	0.04
query28	10.47	0.52	0.50
query29	12.58	3.20	3.20
query30	0.25	0.07	0.07
query31	2.86	0.38	0.39
query32	3.25	0.46	0.45
query33	3.03	3.03	3.01
query34	17.10	4.51	4.49
query35	4.62	4.54	4.67
query36	0.70	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.12
query41	0.09	0.02	0.03
query42	0.03	0.02	0.02
query43	0.05	0.04	0.03
Total cold run time: 105.1 s
Total hot run time: 30.4 s

@felixwluo
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39677 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 984f867573e3cbf4ddfffba04d355a40a11ca86a, data reload: false

------ Round 1 ----------------------------------
q1	17605	6934	6612	6612
q2	2082	181	167	167
q3	10645	1139	1116	1116
q4	10558	708	699	699
q5	7730	2932	2812	2812
q6	217	136	137	136
q7	997	609	600	600
q8	9594	1942	1978	1942
q9	7857	6398	6409	6398
q10	7060	2279	2294	2279
q11	449	265	257	257
q12	399	210	209	209
q13	17783	3020	2963	2963
q14	236	206	203	203
q15	523	463	456	456
q16	468	386	378	378
q17	973	592	480	480
q18	7360	6636	6728	6636
q19	1416	1041	1072	1041
q20	492	199	205	199
q21	4098	3174	3131	3131
q22	1089	963	998	963
Total cold run time: 109631 ms
Total hot run time: 39677 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6658	6579	6638	6579
q2	330	234	245	234
q3	2888	2751	2785	2751
q4	1970	1709	1684	1684
q5	5419	5454	5436	5436
q6	205	126	129	126
q7	2114	1700	1720	1700
q8	3251	3405	3441	3405
q9	8504	8533	8495	8495
q10	3507	3455	3436	3436
q11	574	502	478	478
q12	770	545	601	545
q13	6637	3009	2969	2969
q14	278	279	266	266
q15	520	454	477	454
q16	459	427	414	414
q17	1796	1568	1576	1568
q18	7734	7552	7512	7512
q19	1621	1567	1437	1437
q20	2046	1798	1812	1798
q21	5092	4835	4837	4835
q22	1109	995	1010	995
Total cold run time: 63482 ms
Total hot run time: 57117 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190430 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 984f867573e3cbf4ddfffba04d355a40a11ca86a, data reload: false

query1	974	384	403	384
query2	6538	1978	1909	1909
query3	6706	226	220	220
query4	33508	23430	23571	23430
query5	4721	445	450	445
query6	283	190	177	177
query7	4630	318	320	318
query8	305	232	223	223
query9	9644	2582	2568	2568
query10	510	265	256	256
query11	18364	15223	15320	15223
query12	173	104	101	101
query13	1641	412	420	412
query14	9610	7202	7381	7202
query15	327	173	182	173
query16	8066	506	482	482
query17	1682	580	560	560
query18	2154	306	309	306
query19	392	158	155	155
query20	118	111	108	108
query21	211	108	106	106
query22	4319	4167	4048	4048
query23	34452	33842	33580	33580
query24	11630	2849	2907	2849
query25	723	422	423	422
query26	1836	169	175	169
query27	2903	345	351	345
query28	7631	2114	2095	2095
query29	1058	441	432	432
query30	327	161	156	156
query31	1024	813	824	813
query32	100	63	61	61
query33	822	307	302	302
query34	931	504	541	504
query35	929	725	710	710
query36	1094	935	941	935
query37	176	72	75	72
query38	4037	3866	3845	3845
query39	1515	1458	1424	1424
query40	290	103	102	102
query41	54	52	58	52
query42	119	103	104	103
query43	530	484	486	484
query44	1254	803	800	800
query45	186	168	172	168
query46	1123	722	713	713
query47	1931	1837	1830	1830
query48	478	379	381	379
query49	1291	431	420	420
query50	800	412	411	411
query51	7238	7006	7075	7006
query52	105	93	94	93
query53	261	190	195	190
query54	1275	477	467	467
query55	80	82	84	82
query56	290	262	279	262
query57	1273	1169	1149	1149
query58	231	206	215	206
query59	3189	2821	2881	2821
query60	278	260	257	257
query61	109	107	120	107
query62	876	674	675	674
query63	226	195	197	195
query64	5093	637	628	628
query65	3283	3203	3188	3188
query66	1407	309	312	309
query67	15959	15694	15462	15462
query68	5005	581	559	559
query69	451	269	269	269
query70	1114	1074	1087	1074
query71	418	253	257	253
query72	6417	4008	4096	4008
query73	756	350	349	349
query74	10274	8963	9250	8963
query75	3473	2654	2640	2640
query76	2963	965	1038	965
query77	381	278	272	272
query78	10501	9541	9613	9541
query79	1136	598	598	598
query80	765	444	425	425
query81	515	218	217	217
query82	1270	91	88	88
query83	229	145	147	145
query84	237	84	85	84
query85	1065	298	289	289
query86	332	292	297	292
query87	4339	4236	4222	4222
query88	3510	2399	2367	2367
query89	414	300	296	296
query90	2075	202	224	202
query91	189	149	150	149
query92	61	53	53	53
query93	1047	556	556	556
query94	783	298	309	298
query95	368	260	256	256
query96	611	287	287	287
query97	3289	3131	3137	3131
query98	206	200	196	196
query99	1505	1321	1308	1308
Total cold run time: 300992 ms
Total hot run time: 190430 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 984f867573e3cbf4ddfffba04d355a40a11ca86a, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.11	0.10
query5	0.52	0.50	0.53
query6	1.13	0.73	0.74
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.54	0.56	0.56
query11	0.16	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.77	0.81	0.79
query15	0.86	0.82	0.82
query16	0.41	0.39	0.38
query17	1.06	1.05	1.12
query18	0.24	0.22	0.22
query19	1.88	1.81	1.85
query20	0.02	0.01	0.02
query21	15.39	0.59	0.56
query22	2.21	1.74	1.58
query23	17.04	0.95	0.69
query24	3.21	0.70	0.95
query25	0.22	0.14	0.06
query26	0.40	0.13	0.14
query27	0.04	0.04	0.06
query28	10.64	0.50	0.50
query29	12.59	3.21	3.20
query30	0.25	0.07	0.06
query31	2.85	0.39	0.38
query32	3.24	0.45	0.46
query33	2.97	2.98	3.07
query34	17.12	4.50	4.57
query35	4.55	4.54	4.56
query36	0.64	0.47	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.09	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.76 s
Total hot run time: 29.58 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

@felixwluo
Copy link
Contributor Author

run external

@felixwluo
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39697 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 866c0e18f5bcee8b3bc19ae41cf4f294ee1a4f51, data reload: false

------ Round 1 ----------------------------------
q1	17587	6797	6600	6600
q2	2027	208	174	174
q3	10587	1110	1138	1110
q4	10243	685	662	662
q5	7752	2802	2856	2802
q6	214	132	128	128
q7	962	609	607	607
q8	9357	1956	2004	1956
q9	6710	6376	6371	6371
q10	7036	2248	2273	2248
q11	459	260	254	254
q12	407	214	214	214
q13	17806	3002	2983	2983
q14	231	199	208	199
q15	517	463	467	463
q16	483	376	384	376
q17	978	530	523	523
q18	7340	6635	6671	6635
q19	1411	1099	1081	1081
q20	470	195	197	195
q21	4383	3113	3195	3113
q22	1099	1013	1003	1003
Total cold run time: 108059 ms
Total hot run time: 39697 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6616	6522	6529	6522
q2	327	229	237	229
q3	2917	2893	2895	2893
q4	2018	1770	1799	1770
q5	5720	5703	5674	5674
q6	214	127	131	127
q7	2214	1802	1802	1802
q8	3322	3492	3581	3492
q9	8791	8899	8900	8899
q10	3577	3505	3512	3505
q11	593	487	476	476
q12	794	622	610	610
q13	8827	3146	3194	3146
q14	298	283	283	283
q15	513	474	461	461
q16	493	455	436	436
q17	1827	1602	1595	1595
q18	8237	7899	7888	7888
q19	1673	1452	1504	1452
q20	2058	1834	1867	1834
q21	5153	5098	4915	4915
q22	1164	1074	1009	1009
Total cold run time: 67346 ms
Total hot run time: 59018 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192365 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 866c0e18f5bcee8b3bc19ae41cf4f294ee1a4f51, data reload: false

query1	935	403	413	403
query2	6293	1919	1893	1893
query3	8709	194	191	191
query4	33844	23449	23388	23388
query5	3464	452	449	449
query6	305	188	193	188
query7	4205	322	335	322
query8	304	240	234	234
query9	9314	2590	2585	2585
query10	446	262	258	258
query11	18353	15183	15509	15183
query12	163	104	104	104
query13	1547	424	411	411
query14	9818	7013	6727	6727
query15	248	185	179	179
query16	7954	464	511	464
query17	1596	630	614	614
query18	2154	331	349	331
query19	263	172	171	171
query20	125	117	115	115
query21	209	107	117	107
query22	4645	4550	4300	4300
query23	34579	34324	34009	34009
query24	11153	2972	3006	2972
query25	691	449	428	428
query26	1602	178	172	172
query27	2887	351	365	351
query28	7676	2134	2136	2134
query29	1028	460	452	452
query30	267	166	161	161
query31	1076	868	831	831
query32	98	55	54	54
query33	768	306	299	299
query34	1065	557	530	530
query35	904	749	737	737
query36	1150	970	991	970
query37	123	67	68	67
query38	4051	4062	3961	3961
query39	1521	1480	1501	1480
query40	254	107	98	98
query41	51	47	49	47
query42	112	99	98	98
query43	524	486	486	486
query44	1372	836	819	819
query45	186	174	169	169
query46	1178	740	718	718
query47	2030	1914	1934	1914
query48	469	406	387	387
query49	1065	390	395	390
query50	840	418	414	414
query51	7527	7238	7399	7238
query52	103	92	92	92
query53	279	191	180	180
query54	1231	477	467	467
query55	83	84	75	75
query56	283	260	255	255
query57	1347	1197	1193	1193
query58	218	206	208	206
query59	3248	3135	3111	3111
query60	289	267	253	253
query61	132	106	115	106
query62	865	681	709	681
query63	227	194	193	193
query64	5180	693	696	693
query65	3342	3345	3325	3325
query66	1339	301	297	297
query67	15811	15578	15551	15551
query68	4823	570	548	548
query69	448	271	261	261
query70	1179	1143	1105	1105
query71	355	250	268	250
query72	6208	4082	4008	4008
query73	765	342	367	342
query74	10358	9229	9262	9229
query75	3398	2662	2663	2662
query76	2790	1084	1071	1071
query77	418	260	270	260
query78	10537	9628	9569	9569
query79	2416	595	607	595
query80	1061	421	427	421
query81	538	219	216	216
query82	629	88	85	85
query83	229	147	141	141
query84	235	78	83	78
query85	1328	299	303	299
query86	457	285	288	285
query87	4389	4306	4238	4238
query88	4033	2383	2352	2352
query89	420	292	295	292
query90	1974	185	185	185
query91	190	153	147	147
query92	71	50	51	50
query93	2529	541	541	541
query94	834	301	299	299
query95	355	251	251	251
query96	637	291	291	291
query97	3279	3120	3134	3120
query98	226	204	202	202
query99	1468	1298	1291	1291
Total cold run time: 303695 ms
Total hot run time: 192365 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 866c0e18f5bcee8b3bc19ae41cf4f294ee1a4f51, data reload: false

query1	0.03	0.03	0.02
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.51	0.51	0.50
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.56	0.50	0.48
query10	0.55	0.55	0.55
query11	0.14	0.10	0.11
query12	0.14	0.11	0.10
query13	0.61	0.60	0.59
query14	0.78	0.82	0.78
query15	0.83	0.82	0.82
query16	0.38	0.37	0.42
query17	1.08	1.00	0.98
query18	0.23	0.23	0.22
query19	1.92	1.88	1.84
query20	0.01	0.01	0.01
query21	15.41	0.58	0.59
query22	2.87	1.92	1.45
query23	16.88	0.93	0.81
query24	3.41	1.19	0.51
query25	0.31	0.09	0.14
query26	0.36	0.14	0.14
query27	0.06	0.04	0.04
query28	10.59	0.51	0.51
query29	12.60	3.19	3.17
query30	0.25	0.06	0.06
query31	2.86	0.38	0.38
query32	3.24	0.47	0.46
query33	2.99	3.03	3.05
query34	17.01	4.54	4.57
query35	4.55	4.68	4.52
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.15	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.4 s
Total hot run time: 29.38 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 5ae407c into apache:branch-3.0 Sep 11, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants