-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [bugfix](catalog) replace Math.abs with bitwise AND to ensure non-negative ID generation #55183 #55708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sure non-negative ID generation apache#55183
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 39767 ms |
TPC-DS: Total hot run time: 192352 ms |
ClickBench: Total hot run time: 30.4 s |
|
run buildall |
TPC-H: Total hot run time: 39677 ms |
TPC-DS: Total hot run time: 190430 ms |
ClickBench: Total hot run time: 29.58 s |
FE UT Coverage ReportIncrement line coverage |
|
run external |
|
run buildall |
TPC-H: Total hot run time: 39697 ms |
TPC-DS: Total hot run time: 192365 ms |
ClickBench: Total hot run time: 29.38 s |
FE UT Coverage ReportIncrement line coverage |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
pick: #55183
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)