Skip to content

branch-3.1: [opt](txn lazy commit) Make convert tmp rowsets batch more adaptive #55035 #55573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 4, 2025
Merged

branch-3.1: [opt](txn lazy commit) Make convert tmp rowsets batch more adaptive #55035 #55573

morrySnow merged 1 commit into from
Sep 4, 2025

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Sep 2, 2025 •
edited by morrySnow
Loading

bp #55035

@swjtu-zhanglei
[opt](txn lazy commit) Make convert tmp rowsets batch more adaptive (a…
2dd46d8 
…pache#55035)

* default txn_lazy_max_rowsets_per_batch is 1000, when RowsetMetaCloudPB
size exceeds `10MB / 1000`, fdb will refuse kv_txn, so we calculate
batch size dynamically
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 2, 2025

pick #55035

@swjtu-zhanglei
Copy link
Contributor Author

swjtu-zhanglei commented Sep 2, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 2, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.20% (1214/1495)
Line Coverage 65.76% (21837/33207)
Region Coverage 67.25% (10957/16294)
Branch Coverage 56.91% (5788/10170)

dataroaring
dataroaring approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow changed the title [opt](txn lazy commit) Make convert tmp rowsets batch more adaptive (#55035) branch-3.1: [opt](txn lazy commit) Make convert tmp rowsets batch more adaptive #55035 Sep 4, 2025
@morrySnow morrySnow merged commit d893d6e into apache:branch-3.1 Sep 4, 2025
25 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swjtu-zhanglei @hello-stephen @doris-robot @dataroaring @morrySnow