[opt](txn lazy commit) Make convert tmp rowsets batch more adaptive #55035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swjtu-zhanglei
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
swjtu-zhanglei
force-pushed
the
master-fix16
branch
from
9b88f34 to
2a06431
Compare
w41ter
previously approved these changes
Aug 20, 2025
Contributor
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Aug 20, 2025
gavinchou
requested changes
Aug 20, 2025
|
|
||
| // fdb txn limit 10MB, we use 4MB as the max size for each batch. | ||
| size_t max_rowsets_per_batch = config::txn_lazy_max_rowsets_per_batch; | ||
| if (max_rowset_meta_size > 0) { |
Contributor
There was a problem hiding this comment.
4L << 20 / max_rowset_meta_size 这个表达是是错的 应该会先算 除法 再移位 .
这里最好加个syncpoint 用来观察 实际 max_rowset_meta_size 是多少, 在单测里通通过 syncpoint来 check 它的值
Contributor
Author
There was a problem hiding this comment.
4L << 20 / max_rowset_meta_size这个表达是是错的 应该会先算 除法 再移位 . 这里最好加个syncpoint 用来观察 实际 max_rowset_meta_size 是多少, 在单测里通通过 syncpoint来 check 它的值
done
github-actions
bot
removed
the
approved
swjtu-zhanglei
force-pushed
the
master-fix16
branch
from
2a06431 to
017d294
Compare
Contributor
Author
|
run buildall |
* default txn_lazy_max_rowsets_per_batch is 1000, when RowsetMetaCloudPB size exceeds `10MB / 1000`, fdb will refuse kv_txn, so we calculate batch size dynamically
Contributor
Author
|
run buildall |
swjtu-zhanglei
force-pushed
the
master-fix16
branch
from
017d294 to
79e46e5
Compare
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Aug 22, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Aug 28, 2025
…pache#55035) * default txn_lazy_max_rowsets_per_batch is 1000, when RowsetMetaCloudPB size exceeds `10MB / 1000`, fdb will refuse kv_txn, so we calculate batch size dynamically
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Sep 2, 2025
…pache#55035) * default txn_lazy_max_rowsets_per_batch is 1000, when RowsetMetaCloudPB size exceeds `10MB / 1000`, fdb will refuse kv_txn, so we calculate batch size dynamically
swjtu-zhanglei
added a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Sep 2, 2025
…pache#55035) * default txn_lazy_max_rowsets_per_batch is 1000, when RowsetMetaCloudPB size exceeds `10MB / 1000`, fdb will refuse kv_txn, so we calculate batch size dynamically
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
Sep 3, 2025
…55035) (#55574) * default txn_lazy_max_rowsets_per_batch is 1000, when RowsetMetaCloudPB size exceeds `10MB / 1000`, fdb will refuse kv_txn, so we calculate batch size dynamically ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
morrySnow
pushed a commit
that referenced
this pull request
Sep 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10MB / 1000, fdb will refuse kv_txn, so we calculate batch size dynamicallyWhat problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)