-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](sc) fix check_table_size_correctness failed after schema change when enable skip_writing_empty_rowset_metadata #55742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… when enable skip_writing_empty_rowset_metadata
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34794 ms |
TPC-DS: Total hot run time: 188713 ms |
ClickBench: Total hot run time: 29.45 s |
|
run buildall |
TPC-H: Total hot run time: 34699 ms |
TPC-DS: Total hot run time: 188822 ms |
ClickBench: Total hot run time: 30.14 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
2 similar comments
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
… when enable skip_writing_empty_rowset_metadata (apache#55742) Issue Number: close #xxx Related PR: apache#54395
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #54395
Problem Summary:
During schema change, new tablet may have some later version empty rowsets without resource_id, but middle rowsets get resource_id after historical rowsets are converted. We need to iterate backwards to find a rowset with non-empty resource_id.
02:59:22 *** SIGABRT unknown detail explain (@0x3fba19) received by PID 4176409 (TID 4176919 OR 0x7bf108742700) from PID 4176409; stack trace: ***
02:59:22 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420
02:59:22 1# 0x00007FF4491FA420 in /lib/x86_64-linux-gnu/libpthread.so.0
02:59:22 2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
02:59:22 3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
02:59:22 4# 0x000055907358D285 in /home/work/unlimit_teamcity/TeamCity/Agents/20250903194337agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
02:59:22 5# 0x000055907357EB3A in /home/work/unlimit_teamcity/TeamCity/Agents/20250903194337agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
02:59:22 6# google::LogMessage::SendToLog() in /home/work/unlimit_teamcity/TeamCity/Agents/20250903194337agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
02:59:22 7# google::LogMessage::Flush() in /home/work/unlimit_teamcity/TeamCity/Agents/20250903194337agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
02:59:22 8# google::LogMessageFatal::~LogMessageFatal() in /home/work/unlimit_teamcity/TeamCity/Agents/20250903194337agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
02:59:22 9# doris::cloud::CloudMetaMgr::check_table_size_correctness(doris::RowsetMeta const&) at /root/doris/be/src/cloud/cloud_meta_mgr.cpp:1862
02:59:22 10# doris::cloud::CloudMetaMgr::commit_rowset(doris::RowsetMeta&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, std::shared_ptrdoris::RowsetMeta*) in /home/work/unlimit_teamcity/TeamCity/Agents/20250903194337agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
02:59:22 11# doris::CloudCompactionMixin::execute_compact_impl(long) at /root/doris/be/src/olap/compaction.cpp:1500
02:59:22 12# doris::CloudCompactionMixin::execute_compact() at /root/doris/be/src/olap/compaction.cpp:1521
02:59:22 13# doris::CloudCumulativeCompaction::execute_compact() at /root/doris/be/src/cloud/cloud_cumulative_compaction.cpp:203
02:59:22 14# std::_Function_handler<void (), doris::CloudStorageEngine::_submit_cumulative_compaction_task(std::shared_ptrdoris::CloudTablet
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)