[fix](compaction) fix compaction core dump when enable skip_writing_empty_rowset_metadata #55837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liaoxin01
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
…mpty_rowset_metadata
liaoxin01
force-pushed
the
fix_empty_compaction
branch
from
c9601d4 to
b81cb9f
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34406 ms |
TPC-DS: Total hot run time: 187293 ms |
ClickBench: Total hot run time: 30.13 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 5 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
approved these changes
Sep 10, 2025
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Sep 12, 2025
…mpty_rowset_metadata (apache#55837) Rowsets generated by multiple empty rowset compactions may also lack resource id, and this condition was missed in the DCHECK.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #55742
Problem Summary:
Rowsets generated by multiple empty rowset compactions may also lack resource id, and this condition was missed in the DCHECK.
F20250909 15:32:51.967670 309276 compaction.cpp:1575] Check failed: rowset->is_hole_rowset() || rowset->end_version() == 1 Non-hole rowset with version != [0-1] must have non-empty resource_id, rowset_id=0200000000000346484eac5c34cb52957cfa7d080c595eba, version=[2-6], is_hole_rowset=0, tablet_id=1757390702458
*** Check failure stack trace: ***
@ 0x5605002a49cf google::LogMessage::SendToLog()
@ 0x56050029afe0 google::LogMessage::Flush()
@ 0x56050029e6d9 google::LogMessageFatal::~LogMessageFatal()
@ 0x5604e9c77880 doris::CloudCompactionMixin::construct_output_rowset_writer()
@ 0x5604e9c7e2d0 doris::Compaction::merge_input_rowsets()
@ 0x5604e9cae844 doris::CloudCompactionMixin::execute_compact_impl()
@ 0x5604e9c74575 doris::CloudCompactionMixin::execute_compact()
@ 0x5605000be3fb doris::CloudCumulativeCompaction::execute_compact()
@ 0x56050007b679 std::_Function_handler<>::_M_invoke()
@ 0x5604ebdad1f3 doris::ThreadPool::dispatch_thread()
@ 0x5604ebd8a267 doris::Thread::supervise_thread()
@ 0x5604e75c2d27 asan_thread_start()
@ 0x7fd555ff1ac3 (unknown)
@ 0x7fd556083850 (unknown)
@ (nil) (unknown)
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)