Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2025

Cherry-picked from #55425

…aN (#55425)

Do not do BE constant fold when float/double is NaN
@github-actions github-actions bot requested a review from morrySnow as a code owner September 8, 2025 11:26
@Thearas
Copy link
Contributor

Thearas commented Sep 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Sep 8, 2025
@dataroaring dataroaring reopened this Sep 8, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33145 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2433e31d4e17534ee8c2e7b899a478711ae5d024, data reload: false

------ Round 1 ----------------------------------
q1	17938	5532	5459	5459
q2	2033	411	289	289
q3	12317	1288	767	767
q4	10279	909	470	470
q5	9037	2465	2196	2196
q6	181	162	134	134
q7	924	752	621	621
q8	9338	1475	1228	1228
q9	5259	4994	4961	4961
q10	6808	2287	1845	1845
q11	475	287	268	268
q12	347	373	224	224
q13	17785	3637	3074	3074
q14	234	228	214	214
q15	529	460	452	452
q16	422	438	388	388
q17	623	891	381	381
q18	7047	6500	6418	6418
q19	1211	956	562	562
q20	344	345	209	209
q21	2995	2272	2039	2039
q22	1092	1023	946	946
Total cold run time: 107218 ms
Total hot run time: 33145 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5488	5465	5502	5465
q2	236	321	234	234
q3	2279	2650	2337	2337
q4	1417	1811	1372	1372
q5	4390	5059	4999	4999
q6	178	166	132	132
q7	2097	1995	1820	1820
q8	2650	2816	2681	2681
q9	7335	7228	7175	7175
q10	3081	3236	2815	2815
q11	590	514	492	492
q12	678	814	602	602
q13	3435	3776	3147	3147
q14	296	287	279	279
q15	531	485	463	463
q16	440	477	433	433
q17	1285	1755	1280	1280
q18	7693	7411	7350	7350
q19	880	1195	1140	1140
q20	1993	2076	1920	1920
q21	5394	4837	4622	4622
q22	1054	1049	965	965
Total cold run time: 53420 ms
Total hot run time: 51723 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192482 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2433e31d4e17534ee8c2e7b899a478711ae5d024, data reload: false

query1	946	433	416	416
query2	6230	2048	1952	1952
query3	8682	205	195	195
query4	33584	23816	23678	23678
query5	3683	608	457	457
query6	299	195	185	185
query7	4200	501	309	309
query8	313	262	244	244
query9	9274	2646	2631	2631
query10	476	323	266	266
query11	18190	15512	15183	15183
query12	160	108	106	106
query13	1561	551	429	429
query14	9786	6599	7091	6599
query15	252	183	169	169
query16	8102	655	490	490
query17	1523	780	585	585
query18	2179	431	308	308
query19	218	178	161	161
query20	125	120	130	120
query21	204	132	106	106
query22	4610	4778	4410	4410
query23	35697	34360	34332	34332
query24	7814	2694	2760	2694
query25	494	476	436	436
query26	1066	268	178	178
query27	2060	491	362	362
query28	5561	2234	2226	2226
query29	612	533	469	469
query30	236	201	157	157
query31	998	920	815	815
query32	94	59	57	57
query33	503	363	312	312
query34	787	884	545	545
query35	772	800	734	734
query36	1021	1077	993	993
query37	110	86	67	67
query38	4026	4044	4005	4005
query39	1568	1473	1492	1473
query40	202	121	102	102
query41	52	53	47	47
query42	117	104	102	102
query43	524	522	470	470
query44	1326	839	825	825
query45	195	173	169	169
query46	889	1068	681	681
query47	1960	2006	1974	1974
query48	423	469	371	371
query49	791	495	429	429
query50	706	704	424	424
query51	7366	7401	7214	7214
query52	109	99	94	94
query53	232	264	198	198
query54	541	563	470	470
query55	84	80	80	80
query56	260	274	254	254
query57	1270	1258	1207	1207
query58	231	218	215	215
query59	3102	3235	3111	3111
query60	300	296	271	271
query61	117	116	113	113
query62	813	763	666	666
query63	235	192	202	192
query64	4505	1028	642	642
query65	3373	3282	3297	3282
query66	932	417	324	324
query67	16356	15879	15390	15390
query68	2767	857	575	575
query69	465	317	317	317
query70	1216	1150	1106	1106
query71	359	284	265	265
query72	6004	3823	3743	3743
query73	651	745	367	367
query74	10003	9152	9185	9152
query75	3191	3138	2660	2660
query76	2990	1151	765	765
query77	501	365	277	277
query78	10376	10423	9566	9566
query79	2501	819	606	606
query80	1676	531	435	435
query81	552	261	218	218
query82	362	117	91	91
query83	236	158	149	149
query84	243	108	84	84
query85	784	365	288	288
query86	462	282	305	282
query87	4312	4330	4285	4285
query88	3820	2420	2384	2384
query89	397	335	300	300
query90	1639	188	192	188
query91	134	141	111	111
query92	59	56	51	51
query93	1334	881	550	550
query94	659	405	302	302
query95	340	286	273	273
query96	491	617	290	290
query97	3221	3335	3130	3130
query98	225	210	197	197
query99	1349	1446	1304	1304
Total cold run time: 288346 ms
Total hot run time: 192482 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2433e31d4e17534ee8c2e7b899a478711ae5d024, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.11	0.10
query5	0.53	0.52	0.52
query6	1.13	0.74	0.72
query7	0.03	0.02	0.01
query8	0.05	0.03	0.03
query9	0.57	0.50	0.48
query10	0.55	0.56	0.55
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.59
query14	0.79	0.82	0.80
query15	0.87	0.83	0.83
query16	0.41	0.39	0.39
query17	1.05	1.05	1.05
query18	0.23	0.22	0.23
query19	1.96	1.88	1.93
query20	0.02	0.01	0.01
query21	15.37	0.90	0.57
query22	0.74	0.74	0.60
query23	15.21	1.47	0.61
query24	3.20	1.62	1.50
query25	0.24	0.16	0.09
query26	0.20	0.14	0.14
query27	0.04	0.06	0.04
query28	13.83	0.97	0.44
query29	12.56	3.91	3.27
query30	0.25	0.09	0.06
query31	2.81	0.62	0.39
query32	3.25	0.54	0.48
query33	2.99	3.04	3.04
query34	16.65	5.20	4.54
query35	4.57	4.64	4.60
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.11 s
Total hot run time: 29.67 s

@morrySnow
Copy link
Contributor

p0 failed, should pick mannually

@morrySnow morrySnow closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants