Skip to content

[fix](constant fold)Do not do BE constant fold when float/double is NaN #55425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jibing-Li merged 1 commit into from
Sep 8, 2025
Merged

[fix](constant fold)Do not do BE constant fold when float/double is NaN #55425

Jibing-Li merged 1 commit into from
Sep 8, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Aug 28, 2025

What problem does this PR solve?

Do not do BE constant fold when float/double is NaN
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Aug 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review August 28, 2025 08:26
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Aug 28, 2025

run buildall

morrySnow
morrySnow previously approved these changes Aug 28, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Aug 28, 2025

TPC-H: Total hot run time: 34165 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 864994111d2f4ba48b4687c5f07eca58c796946b, data reload: false

------ Round 1 ----------------------------------
q1	17619	5258	5092	5092
q2	2016	383	208	208
q3	10175	1290	734	734
q4	10221	1017	518	518
q5	7541	2465	2331	2331
q6	181	168	135	135
q7	968	750	615	615
q8	9342	1346	1108	1108
q9	6970	5142	5178	5142
q10	6887	2399	1983	1983
q11	470	320	278	278
q12	352	364	236	236
q13	17762	3629	3127	3127
q14	242	244	222	222
q15	556	504	494	494
q16	422	434	372	372
q17	596	862	366	366
q18	7530	7217	7097	7097
q19	1249	961	562	562
q20	334	338	231	231
q21	3716	3174	2353	2353
q22	1089	1040	961	961
Total cold run time: 106238 ms
Total hot run time: 34165 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5157	5141	5145	5141
q2	258	331	226	226
q3	2197	2711	2254	2254
q4	1349	1772	1337	1337
q5	4238	4366	4633	4366
q6	220	180	137	137
q7	2108	1953	1838	1838
q8	2652	2679	2651	2651
q9	7364	7274	7410	7274
q10	3184	3575	2922	2922
q11	579	546	501	501
q12	699	802	663	663
q13	3613	3984	3278	3278
q14	310	323	286	286
q15	517	481	484	481
q16	452	520	489	489
q17	1206	1590	1392	1392
q18	7923	7676	7716	7676
q19	861	860	1079	860
q20	1992	2106	1936	1936
q21	4944	4701	4390	4390
q22	1083	1071	1038	1038
Total cold run time: 52906 ms
Total hot run time: 51136 ms

@doris-robot
Copy link

doris-robot commented Aug 28, 2025

TPC-DS: Total hot run time: 187160 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 864994111d2f4ba48b4687c5f07eca58c796946b, data reload: false

query1	1078	432	405	405
query2	6580	1817	1856	1817
query3	6757	228	228	228
query4	26414	23990	23158	23158
query5	4981	685	505	505
query6	342	234	214	214
query7	4645	501	310	310
query8	309	270	249	249
query9	8642	2888	2888	2888
query10	538	364	293	293
query11	16099	15011	14947	14947
query12	180	122	117	117
query13	1698	565	443	443
query14	9973	5937	5833	5833
query15	218	195	168	168
query16	7664	696	477	477
query17	1224	765	641	641
query18	2049	446	336	336
query19	209	205	174	174
query20	133	128	125	125
query21	228	140	119	119
query22	4069	4136	3997	3997
query23	33925	33025	32935	32935
query24	8118	2426	2397	2397
query25	598	550	484	484
query26	1244	290	226	226
query27	2648	512	362	362
query28	4318	2265	2235	2235
query29	780	598	499	499
query30	297	227	201	201
query31	936	816	744	744
query32	92	88	83	83
query33	593	401	371	371
query34	788	837	513	513
query35	829	850	777	777
query36	1001	1060	936	936
query37	137	113	94	94
query38	4115	4107	4105	4105
query39	1478	1467	1543	1467
query40	224	138	134	134
query41	74	68	63	63
query42	128	116	127	116
query43	513	523	522	522
query44	1409	865	864	864
query45	193	182	183	182
query46	875	1026	655	655
query47	1765	1835	1772	1772
query48	410	424	350	350
query49	744	524	479	479
query50	673	682	406	406
query51	4074	4159	4081	4081
query52	118	118	111	111
query53	251	286	219	219
query54	628	618	545	545
query55	96	119	93	93
query56	337	333	338	333
query57	1212	1214	1150	1150
query58	298	286	275	275
query59	2674	2767	2608	2608
query60	364	363	356	356
query61	167	160	163	160
query62	812	730	670	670
query63	234	198	197	197
query64	4464	1149	862	862
query65	4267	4264	4218	4218
query66	1101	446	350	350
query67	15605	15109	15011	15011
query68	7994	926	594	594
query69	497	334	298	298
query70	1231	1140	1155	1140
query71	450	357	328	328
query72	5847	5063	5151	5063
query73	704	661	368	368
query74	8933	9140	8784	8784
query75	3697	3122	2623	2623
query76	3534	1141	747	747
query77	797	432	340	340
query78	9589	9494	8873	8873
query79	2291	838	598	598
query80	649	580	531	531
query81	506	268	225	225
query82	489	146	114	114
query83	266	327	254	254
query84	265	125	107	107
query85	903	476	449	449
query86	390	345	304	304
query87	4264	4229	4116	4116
query88	3795	2251	2227	2227
query89	398	346	299	299
query90	1992	241	233	233
query91	161	171	140	140
query92	96	77	75	75
query93	1877	1017	659	659
query94	736	413	331	331
query95	420	338	333	333
query96	490	580	276	276
query97	2601	2666	2574	2574
query98	255	222	216	216
query99	1359	1395	1286	1286
Total cold run time: 277113 ms
Total hot run time: 187160 ms

@doris-robot
Copy link

doris-robot commented Aug 28, 2025

ClickBench: Total hot run time: 32.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 864994111d2f4ba48b4687c5f07eca58c796946b, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.06
query3	0.26	0.08	0.08
query4	1.60	0.11	0.11
query5	0.44	0.42	0.44
query6	1.22	0.64	0.67
query7	0.04	0.03	0.02
query8	0.05	0.04	0.05
query9	0.60	0.54	0.52
query10	0.58	0.59	0.57
query11	0.17	0.11	0.12
query12	0.16	0.13	0.13
query13	0.64	0.61	0.63
query14	0.80	0.85	0.83
query15	0.87	0.86	0.85
query16	0.41	0.41	0.40
query17	1.09	1.03	1.06
query18	0.21	0.20	0.20
query19	1.93	1.84	1.82
query20	0.02	0.01	0.01
query21	15.46	0.95	0.59
query22	0.76	1.08	0.78
query23	14.96	1.34	0.61
query24	6.63	2.42	0.39
query25	0.45	0.12	0.12
query26	0.65	0.17	0.15
query27	0.08	0.06	0.06
query28	10.21	0.89	0.43
query29	12.57	3.85	3.26
query30	3.06	3.04	3.02
query31	2.82	0.58	0.40
query32	3.25	0.56	0.49
query33	3.14	3.12	3.20
query34	16.22	5.50	4.83
query35	5.01	4.90	4.91
query36	0.73	0.52	0.50
query37	0.10	0.07	0.08
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.15
query41	0.09	0.03	0.04
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.78 s
Total hot run time: 32.51 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 28, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 5, 2025
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Sep 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

TPC-H: Total hot run time: 34275 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c3d926d38485a347e5c2f0cf0596d08ef516468f, data reload: false

------ Round 1 ----------------------------------
q1	17605	5237	5055	5055
q2	2015	317	225	225
q3	10264	1299	714	714
q4	10246	1024	531	531
q5	7522	2461	2594	2461
q6	180	169	137	137
q7	951	781	635	635
q8	9358	1357	1136	1136
q9	6954	5145	5169	5145
q10	6969	2424	1954	1954
q11	498	309	293	293
q12	372	356	227	227
q13	17808	3665	3037	3037
q14	235	251	229	229
q15	579	503	484	484
q16	434	426	379	379
q17	600	884	364	364
q18	7454	7224	7079	7079
q19	1097	975	562	562
q20	353	351	242	242
q21	3766	3194	2380	2380
q22	1073	1066	1006	1006
Total cold run time: 106333 ms
Total hot run time: 34275 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5141	5101	5057	5057
q2	261	331	229	229
q3	2217	2723	2337	2337
q4	1324	1831	1333	1333
q5	4231	4451	4548	4451
q6	243	184	137	137
q7	2074	1935	1820	1820
q8	2696	2678	2578	2578
q9	7496	7410	7269	7269
q10	3149	3323	2879	2879
q11	585	516	516	516
q12	700	764	653	653
q13	3418	3916	3307	3307
q14	388	304	280	280
q15	544	492	480	480
q16	452	544	438	438
q17	1194	1518	1373	1373
q18	8072	7799	7558	7558
q19	822	835	915	835
q20	2015	2045	1944	1944
q21	4991	4658	4295	4295
q22	1110	1034	1022	1022
Total cold run time: 53123 ms
Total hot run time: 50791 ms

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

TPC-DS: Total hot run time: 186612 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c3d926d38485a347e5c2f0cf0596d08ef516468f, data reload: false

query1	1052	441	409	409
query2	6584	1701	1673	1673
query3	6762	241	218	218
query4	26048	23720	22973	22973
query5	4417	638	550	550
query6	356	235	232	232
query7	4667	525	315	315
query8	318	270	249	249
query9	8663	2926	2927	2926
query10	511	346	290	290
query11	16173	14962	14749	14749
query12	166	121	117	117
query13	1677	581	442	442
query14	8797	5938	5884	5884
query15	262	198	173	173
query16	7178	637	475	475
query17	1233	743	621	621
query18	2006	437	337	337
query19	205	209	180	180
query20	131	128	121	121
query21	213	132	124	124
query22	3940	4066	4026	4026
query23	34009	33029	32973	32973
query24	8187	2468	2437	2437
query25	580	534	458	458
query26	1251	284	168	168
query27	2706	506	366	366
query28	4333	2270	2220	2220
query29	828	610	488	488
query30	298	238	200	200
query31	909	837	745	745
query32	136	82	85	82
query33	575	398	367	367
query34	806	848	532	532
query35	836	830	750	750
query36	978	1043	920	920
query37	135	113	91	91
query38	4159	4037	4064	4037
query39	1479	1457	1396	1396
query40	229	131	136	131
query41	72	64	63	63
query42	133	118	116	116
query43	525	512	495	495
query44	1401	900	881	881
query45	186	181	173	173
query46	890	1012	661	661
query47	1822	1829	1730	1730
query48	388	450	328	328
query49	739	512	417	417
query50	661	685	402	402
query51	4407	4183	4023	4023
query52	120	119	109	109
query53	247	274	218	218
query54	610	627	542	542
query55	98	96	96	96
query56	337	334	332	332
query57	1186	1209	1139	1139
query58	296	291	287	287
query59	2645	2643	2531	2531
query60	366	361	358	358
query61	167	164	173	164
query62	825	726	684	684
query63	244	211	209	209
query64	4625	1153	840	840
query65	4291	4168	4203	4168
query66	1190	443	349	349
query67	15572	15351	15058	15058
query68	6713	933	582	582
query69	511	342	304	304
query70	1171	1164	1172	1164
query71	540	360	337	337
query72	5847	5178	5242	5178
query73	695	709	372	372
query74	8931	8809	8852	8809
query75	3129	3096	2683	2683
query76	3169	1163	761	761
query77	508	521	336	336
query78	9513	9816	8794	8794
query79	1682	914	593	593
query80	689	587	523	523
query81	502	269	227	227
query82	200	142	118	118
query83	274	272	248	248
query84	263	123	91	91
query85	897	466	476	466
query86	403	337	335	335
query87	4331	4252	4131	4131
query88	2922	2299	2269	2269
query89	415	337	308	308
query90	2009	243	240	240
query91	166	171	133	133
query92	90	84	72	72
query93	1905	1021	656	656
query94	703	428	332	332
query95	427	341	339	339
query96	494	600	286	286
query97	2662	2707	2587	2587
query98	256	228	232	228
query99	1366	1400	1292	1292
Total cold run time: 271219 ms
Total hot run time: 186612 ms

@doris-robot
Copy link

doris-robot commented Sep 5, 2025

ClickBench: Total hot run time: 30.06 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c3d926d38485a347e5c2f0cf0596d08ef516468f, data reload: false

query1	0.06	0.04	0.04
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.11	0.12
query5	0.46	0.43	0.41
query6	1.19	0.65	0.66
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.60	0.53	0.52
query10	0.58	0.58	0.57
query11	0.17	0.12	0.11
query12	0.16	0.12	0.12
query13	0.62	0.63	0.63
query14	0.79	0.85	0.83
query15	0.88	0.87	0.87
query16	0.40	0.41	0.41
query17	1.04	1.06	1.06
query18	0.22	0.21	0.20
query19	1.96	1.85	1.83
query20	0.01	0.02	0.01
query21	15.40	0.99	0.58
query22	0.79	1.07	0.68
query23	14.96	1.37	0.63
query24	6.94	0.79	1.31
query25	0.49	0.23	0.10
query26	0.68	0.16	0.15
query27	0.07	0.05	0.06
query28	9.83	0.96	0.43
query29	12.64	3.87	3.28
query30	0.28	0.13	0.11
query31	2.83	0.61	0.38
query32	3.24	0.56	0.49
query33	3.02	3.13	3.07
query34	16.03	5.47	4.91
query35	4.95	4.95	4.93
query36	0.68	0.51	0.50
query37	0.11	0.08	0.08
query38	0.07	0.05	0.05
query39	0.04	0.04	0.03
query40	0.19	0.16	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 104.59 s
Total hot run time: 30.06 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 5, 2025

FE Regression Coverage Report

Increment line coverage 50.00% (4/8) 🎉
Increment coverage report
Complete coverage report

@Jibing-Li Jibing-Li force-pushed the becast branch 3 times, most recently from 646ce6d to 41b04af Compare September 8, 2025 04:18
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Sep 8, 2025

run performance

@doris-robot
Copy link

doris-robot commented Sep 8, 2025

TPC-H: Total hot run time: 35161 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c265267868d09d196877d20846d2b9996b9967a1, data reload: false

------ Round 1 ----------------------------------
q1	17626	5222	5072	5072
q2	1987	372	227	227
q3	10234	1326	734	734
q4	10385	1074	531	531
q5	10031	2401	2425	2401
q6	251	170	137	137
q7	972	761	646	646
q8	9388	1350	1402	1350
q9	6999	5105	5172	5105
q10	6958	2404	1975	1975
q11	513	308	292	292
q12	374	379	227	227
q13	17791	3716	3074	3074
q14	255	257	234	234
q15	577	500	489	489
q16	1019	1001	950	950
q17	646	877	380	380
q18	7523	7195	7131	7131
q19	1095	961	579	579
q20	375	352	238	238
q21	4167	3304	2403	2403
q22	1081	1027	986	986
Total cold run time: 110247 ms
Total hot run time: 35161 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5201	5118	5139	5118
q2	255	343	236	236
q3	2242	2699	2290	2290
q4	1336	1816	1312	1312
q5	4222	4192	4150	4150
q6	217	177	132	132
q7	1912	1833	1705	1705
q8	2550	2524	2520	2520
q9	6893	6833	6849	6833
q10	2966	3168	2751	2751
q11	572	502	491	491
q12	655	751	572	572
q13	3315	3616	3046	3046
q14	267	302	281	281
q15	519	469	476	469
q16	1023	1056	1020	1020
q17	1151	1514	1375	1375
q18	7380	7269	7073	7073
q19	844	807	892	807
q20	1974	1960	1808	1808
q21	4749	4396	4246	4246
q22	1092	1068	1034	1034
Total cold run time: 51335 ms
Total hot run time: 49269 ms

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Sep 8, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 8, 2025

FE Regression Coverage Report

Increment line coverage 88.46% (23/26) 🎉
Increment coverage report
Complete coverage report

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Sep 8, 2025

run performance

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 8, 2025

FE Regression Coverage Report

Increment line coverage 88.46% (23/26) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Sep 8, 2025

TPC-H: Total hot run time: 34770 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c265267868d09d196877d20846d2b9996b9967a1, data reload: false

------ Round 1 ----------------------------------
q1	17596	5217	5131	5131
q2	1977	340	205	205
q3	10235	1316	692	692
q4	10239	1048	522	522
q5	7545	2480	2362	2362
q6	187	172	138	138
q7	938	768	653	653
q8	9359	1341	1121	1121
q9	7001	5158	5203	5158
q10	6960	2403	1973	1973
q11	494	312	289	289
q12	353	375	225	225
q13	17781	3649	3061	3061
q14	249	240	212	212
q15	583	499	494	494
q16	1014	1000	957	957
q17	603	867	372	372
q18	7335	7202	7105	7105
q19	1376	969	558	558
q20	342	341	234	234
q21	3739	3179	2329	2329
q22	1053	1030	979	979
Total cold run time: 106959 ms
Total hot run time: 34770 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5214	5115	5121	5115
q2	263	334	232	232
q3	2133	2669	2320	2320
q4	1330	1790	1316	1316
q5	4242	4531	4595	4531
q6	226	180	140	140
q7	2041	1942	1901	1901
q8	2618	2653	2550	2550
q9	7485	7294	7422	7294
q10	3174	3281	2859	2859
q11	583	562	519	519
q12	670	782	648	648
q13	3552	3969	3303	3303
q14	300	322	271	271
q15	512	482	474	474
q16	1060	1136	1063	1063
q17	1208	1616	1413	1413
q18	8052	7715	7368	7368
q19	816	774	801	774
q20	1914	1947	1827	1827
q21	4857	4327	4200	4200
q22	1083	1047	1007	1007
Total cold run time: 53333 ms
Total hot run time: 51125 ms

@doris-robot
Copy link

doris-robot commented Sep 8, 2025

TPC-DS: Total hot run time: 189597 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c265267868d09d196877d20846d2b9996b9967a1, data reload: false

query1	1045	457	433	433
query2	6574	1701	1690	1690
query3	6751	230	224	224
query4	26242	23578	23192	23192
query5	4430	652	517	517
query6	374	263	246	246
query7	4893	542	317	317
query8	308	277	293	277
query9	8774	2945	2922	2922
query10	505	347	310	310
query11	15976	15017	15222	15017
query12	177	120	116	116
query13	1670	561	424	424
query14	11028	9131	9208	9131
query15	208	189	174	174
query16	7425	659	504	504
query17	1266	746	648	648
query18	2025	431	338	338
query19	209	196	209	196
query20	135	126	120	120
query21	220	137	117	117
query22	4138	4272	4173	4173
query23	34045	33070	32911	32911
query24	8232	2376	2436	2376
query25	576	539	448	448
query26	1249	281	193	193
query27	2696	503	352	352
query28	4361	2277	2244	2244
query29	799	616	500	500
query30	292	228	198	198
query31	935	816	738	738
query32	86	83	130	83
query33	569	401	353	353
query34	792	864	529	529
query35	850	821	749	749
query36	978	1028	937	937
query37	123	118	95	95
query38	3564	3609	3464	3464
query39	1514	1411	1427	1411
query40	225	133	123	123
query41	64	63	61	61
query42	133	113	117	113
query43	509	502	453	453
query44	1346	868	866	866
query45	188	177	178	177
query46	867	1030	672	672
query47	1788	1828	1763	1763
query48	381	438	318	318
query49	750	510	399	399
query50	659	695	423	423
query51	3949	3962	3831	3831
query52	116	115	115	115
query53	250	269	199	199
query54	655	634	567	567
query55	100	92	89	89
query56	387	344	348	344
query57	1206	1222	1117	1117
query58	302	292	297	292
query59	2607	2716	2572	2572
query60	376	399	348	348
query61	167	159	180	159
query62	784	735	666	666
query63	230	198	198	198
query64	4496	1160	819	819
query65	4049	3972	3982	3972
query66	1148	450	377	377
query67	15454	15237	15073	15073
query68	7959	938	587	587
query69	483	333	299	299
query70	1322	1326	1274	1274
query71	578	355	335	335
query72	5817	5000	5129	5000
query73	729	660	369	369
query74	9188	9166	8931	8931
query75	3879	3258	2840	2840
query76	3634	1171	766	766
query77	805	406	343	343
query78	9494	9867	8838	8838
query79	2170	900	600	600
query80	643	582	527	527
query81	479	258	295	258
query82	434	171	136	136
query83	262	271	263	263
query84	248	112	93	93
query85	872	475	430	430
query86	344	337	324	324
query87	3700	3826	3594	3594
query88	3270	2279	2267	2267
query89	415	343	292	292
query90	1950	241	232	232
query91	172	171	142	142
query92	98	75	71	71
query93	1255	1026	658	658
query94	701	420	329	329
query95	418	345	328	328
query96	493	584	284	284
query97	2942	3000	2876	2876
query98	252	220	214	214
query99	1340	1409	1324	1324
Total cold run time: 275566 ms
Total hot run time: 189597 ms

@doris-robot
Copy link

doris-robot commented Sep 8, 2025

ClickBench: Total hot run time: 30.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c265267868d09d196877d20846d2b9996b9967a1, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.25	0.09	0.08
query4	1.61	0.12	0.12
query5	0.29	0.27	0.26
query6	1.19	0.68	0.64
query7	0.04	0.03	0.02
query8	0.05	0.04	0.05
query9	0.63	0.52	0.51
query10	0.58	0.58	0.57
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.64	0.63	0.63
query14	1.02	1.02	1.03
query15	0.87	0.85	0.89
query16	0.42	0.40	0.40
query17	1.04	1.03	1.05
query18	0.21	0.20	0.21
query19	1.98	1.84	1.76
query20	0.01	0.02	0.01
query21	15.40	0.97	0.60
query22	0.76	1.21	0.98
query23	14.72	1.39	0.65
query24	6.59	2.42	0.93
query25	0.56	0.14	0.14
query26	0.60	0.16	0.13
query27	0.07	0.05	0.05
query28	10.56	0.86	0.44
query29	12.60	4.00	3.28
query30	0.30	0.14	0.11
query31	2.82	0.59	0.38
query32	3.23	0.56	0.47
query33	3.21	3.14	3.08
query34	16.24	5.48	4.86
query35	4.95	4.92	4.98
query36	0.71	0.52	0.50
query37	0.11	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.04	0.04	0.06
Total cold run time: 105.16 s
Total hot run time: 30.35 s

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 8, 2025
@Jibing-Li Jibing-Li merged commit d594b8d into apache:master Sep 8, 2025
27 of 28 checks passed
@Jibing-Li Jibing-Li deleted the becast branch September 8, 2025 11:25
github-actions bot pushed a commit that referenced this pull request Sep 8, 2025
@Jibing-Li
[fix](constant fold)Do not do BE constant fold when float/double is N…
2433e31 
…aN (#55425)

Do not do BE constant fold when float/double is NaN
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
Closed
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Sep 10, 2025
@Jibing-Li
[fix](constant fold)Do not do BE constant fold when float/double is N…
b5cb82e 
…aN (apache#55425)

Do not do BE constant fold when float/double is NaN
@Jibing-Li Jibing-Li mentioned this pull request Sep 10, 2025
Merged
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Sep 10, 2025
@Jibing-Li
[fix](constant fold)Do not do BE constant fold when float/double is N…
46adcfc 
…aN (apache#55425)

Do not do BE constant fold when float/double is NaN
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Sep 10, 2025
@Jibing-Li
[fix](constant fold)Do not do BE constant fold when float/double is N…
adcc858 
…aN (apache#55425)

Do not do BE constant fold when float/double is NaN
morrySnow pushed a commit that referenced this pull request Sep 11, 2025
@Jibing-Li
branch-3.1: [fix](constant fold)Do not do BE constant fold when float…
4defdfd 
…/double is NaN #55425 (#55874)

backport: #55425
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jibing-Li @Thearas @doris-robot @hello-stephen @yujun777 @morrySnow