Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Sep 10, 2025

backport: #55425

@Thearas
Copy link
Contributor

Thearas commented Sep 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

…aN (apache#55425)

Do not do BE constant fold when float/double is NaN
@Jibing-Li Jibing-Li marked this pull request as ready for review September 10, 2025 15:05
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32789 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit adcc858adca89463a8d5c3af05cbc98ae8aa4f70, data reload: false

------ Round 1 ----------------------------------
q1	17843	5623	5593	5593
q2	2044	387	291	291
q3	12168	1262	744	744
q4	10570	881	455	455
q5	9601	2375	2144	2144
q6	188	160	136	136
q7	902	752	606	606
q8	9347	1438	1135	1135
q9	5231	4970	5007	4970
q10	6779	2280	1845	1845
q11	484	281	255	255
q12	335	363	217	217
q13	17797	3625	2978	2978
q14	239	226	220	220
q15	521	473	468	468
q16	421	425	377	377
q17	620	868	366	366
q18	6829	6500	6323	6323
q19	1220	975	538	538
q20	323	328	211	211
q21	2798	2141	1946	1946
q22	1032	1040	971	971
Total cold run time: 107292 ms
Total hot run time: 32789 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5579	5644	5565	5565
q2	240	331	234	234
q3	2267	2670	2343	2343
q4	1435	1838	1503	1503
q5	4400	5067	5016	5016
q6	174	165	128	128
q7	2072	1957	1830	1830
q8	2697	2848	2712	2712
q9	7291	7255	7260	7255
q10	3091	3244	2788	2788
q11	591	514	496	496
q12	677	794	622	622
q13	3415	3808	3137	3137
q14	276	301	283	283
q15	517	473	469	469
q16	425	490	440	440
q17	1251	1762	1237	1237
q18	7746	7518	7438	7438
q19	797	1121	1092	1092
q20	2023	2079	1894	1894
q21	5352	4881	4579	4579
q22	1101	1099	1015	1015
Total cold run time: 53417 ms
Total hot run time: 52076 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192808 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit adcc858adca89463a8d5c3af05cbc98ae8aa4f70, data reload: false

query1	938	396	401	396
query2	6192	1890	1846	1846
query3	8682	207	207	207
query4	33633	24605	23848	23848
query5	4125	637	443	443
query6	312	199	193	193
query7	4225	529	324	324
query8	320	280	267	267
query9	9493	2658	2654	2654
query10	466	333	255	255
query11	18092	15620	15176	15176
query12	165	105	109	105
query13	1550	544	413	413
query14	10183	6527	7664	6527
query15	239	202	182	182
query16	8106	674	516	516
query17	1614	826	594	594
query18	2199	445	326	326
query19	249	199	184	184
query20	135	129	127	127
query21	211	138	110	110
query22	4554	4740	4282	4282
query23	35418	34123	34379	34123
query24	7687	2716	2743	2716
query25	561	527	446	446
query26	1202	313	176	176
query27	1977	499	361	361
query28	5682	2260	2246	2246
query29	778	657	486	486
query30	244	208	173	173
query31	1048	961	836	836
query32	94	60	57	57
query33	548	400	341	341
query34	771	922	529	529
query35	818	873	735	735
query36	1085	1104	941	941
query37	108	98	67	67
query38	4060	4036	4082	4036
query39	1528	1481	1501	1481
query40	213	121	111	111
query41	52	49	48	48
query42	132	114	100	100
query43	506	532	463	463
query44	1351	838	831	831
query45	185	184	175	175
query46	959	1154	679	679
query47	2007	2049	1917	1917
query48	427	444	359	359
query49	784	517	411	411
query50	712	755	431	431
query51	7371	7290	7252	7252
query52	106	105	98	98
query53	260	273	190	190
query54	580	578	492	492
query55	82	84	81	81
query56	271	277	263	263
query57	1319	1277	1216	1216
query58	229	234	244	234
query59	3054	3117	3043	3043
query60	319	285	272	272
query61	120	115	114	114
query62	843	768	707	707
query63	245	198	190	190
query64	4816	1040	652	652
query65	3449	3280	3323	3280
query66	971	454	326	326
query67	16318	15691	15596	15596
query68	7307	865	552	552
query69	506	319	275	275
query70	1189	1109	1108	1108
query71	378	311	269	269
query72	5788	3957	3964	3957
query73	636	795	348	348
query74	10648	9457	9189	9189
query75	3343	3257	2655	2655
query76	3065	1274	815	815
query77	485	388	273	273
query78	10737	10552	9580	9580
query79	2972	942	600	600
query80	949	544	438	438
query81	541	268	223	223
query82	724	132	93	93
query83	171	174	147	147
query84	234	102	83	83
query85	811	366	309	309
query86	412	333	289	289
query87	4340	4306	4249	4249
query88	5388	2424	2407	2407
query89	440	354	300	300
query90	1811	190	185	185
query91	143	156	116	116
query92	72	61	53	53
query93	2705	926	535	535
query94	802	440	312	312
query95	346	279	268	268
query96	496	664	288	288
query97	3273	3343	3121	3121
query98	241	212	205	205
query99	1373	1445	1310	1310
Total cold run time: 299299 ms
Total hot run time: 192808 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.91 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit adcc858adca89463a8d5c3af05cbc98ae8aa4f70, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.52	0.49	0.52
query6	1.15	0.74	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.49	0.50
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.13	0.11	0.11
query13	0.63	0.59	0.59
query14	0.78	0.80	0.79
query15	0.84	0.84	0.82
query16	0.38	0.39	0.39
query17	1.05	0.99	0.99
query18	0.25	0.23	0.22
query19	1.84	1.88	1.77
query20	0.02	0.01	0.00
query21	15.43	0.92	0.57
query22	0.74	0.84	0.56
query23	15.16	1.39	0.57
query24	3.26	1.06	1.98
query25	0.16	0.20	0.16
query26	0.21	0.15	0.14
query27	0.05	0.06	0.05
query28	14.45	0.96	0.43
query29	12.59	3.93	3.26
query30	0.26	0.09	0.06
query31	2.83	0.61	0.40
query32	3.23	0.54	0.47
query33	3.00	3.03	3.01
query34	16.72	5.18	4.54
query35	4.57	4.61	4.52
query36	0.64	0.50	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.62 s
Total hot run time: 28.91 s

@Jibing-Li
Copy link
Contributor Author

run external

@morrySnow morrySnow changed the title branch-3.1: [fix](constant fold)Do not do BE constant fold when float/double is NaN (#55425) branch-3.1: [fix](constant fold)Do not do BE constant fold when float/double is NaN #55425 Sep 11, 2025
@morrySnow morrySnow merged commit 4defdfd into apache:branch-3.1 Sep 11, 2025
24 checks passed
@morrySnow morrySnow deleted the becast3.1 branch September 11, 2025 02:40
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants