Skip to content

Conversation

@deardeng
Copy link
Contributor

cherry pick from #55579

…pache#55579)

Here, replayUpdateCloudReplica adds a table write lock, which seems to
protect nothing. Try deleting it.
@deardeng
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Sep 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 39526 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cdab3972b4613340afec1134af74fa3e8342de4e, data reload: false

------ Round 1 ----------------------------------
q1	17654	7076	6605	6605
q2	2060	187	173	173
q3	10575	1100	1161	1100
q4	10228	717	726	717
q5	7726	2839	2769	2769
q6	210	131	130	130
q7	953	613	600	600
q8	9342	1887	1977	1887
q9	6663	6368	6374	6368
q10	6983	2242	2287	2242
q11	461	259	257	257
q12	455	214	219	214
q13	17768	2969	3001	2969
q14	220	204	215	204
q15	494	464	457	457
q16	478	377	377	377
q17	962	549	580	549
q18	7272	6535	6651	6535
q19	1519	1133	1061	1061
q20	466	203	206	203
q21	3846	3131	3138	3131
q22	1101	998	978	978
Total cold run time: 107436 ms
Total hot run time: 39526 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6594	6531	6547	6531
q2	333	228	228	228
q3	2833	2925	2901	2901
q4	2067	1837	1852	1837
q5	5745	5725	5669	5669
q6	211	125	129	125
q7	2261	1762	1805	1762
q8	3383	3525	3523	3523
q9	8747	8808	8776	8776
q10	3553	3552	3497	3497
q11	606	500	502	500
q12	800	594	630	594
q13	9602	3222	3130	3130
q14	295	271	267	267
q15	511	475	480	475
q16	489	441	433	433
q17	1844	1595	1608	1595
q18	8202	7932	7952	7932
q19	1682	1677	1572	1572
q20	2100	1940	1932	1932
q21	5420	5090	5019	5019
q22	1150	1088	993	993
Total cold run time: 68428 ms
Total hot run time: 59291 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192306 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cdab3972b4613340afec1134af74fa3e8342de4e, data reload: false

query1	955	417	394	394
query2	6223	1936	1846	1846
query3	8712	201	200	200
query4	33811	23879	23217	23217
query5	3764	456	447	447
query6	302	199	183	183
query7	4203	311	306	306
query8	293	229	222	222
query9	9479	2564	2559	2559
query10	481	288	268	268
query11	17917	15162	15165	15162
query12	156	110	104	104
query13	1557	434	434	434
query14	8627	7245	6933	6933
query15	259	172	179	172
query16	8028	511	476	476
query17	1599	638	613	613
query18	2189	333	337	333
query19	371	162	161	161
query20	128	126	123	123
query21	215	103	112	103
query22	4794	4431	4344	4344
query23	35064	35205	34507	34507
query24	11146	2921	2981	2921
query25	554	426	421	421
query26	747	176	173	173
query27	2575	362	365	362
query28	7281	2146	2138	2138
query29	694	467	450	450
query30	267	164	159	159
query31	1071	812	804	804
query32	102	55	58	55
query33	764	307	309	307
query34	963	544	530	530
query35	873	728	727	727
query36	1122	956	943	943
query37	114	66	69	66
query38	4087	3951	3911	3911
query39	1540	1488	1638	1488
query40	208	99	96	96
query41	48	48	47	47
query42	117	110	104	104
query43	544	490	491	490
query44	1305	809	820	809
query45	182	167	171	167
query46	1173	752	738	738
query47	2042	1931	1902	1902
query48	470	371	400	371
query49	952	396	395	395
query50	843	447	434	434
query51	7389	7246	7333	7246
query52	110	93	90	90
query53	271	187	184	184
query54	1312	471	474	471
query55	84	80	79	79
query56	270	250	252	250
query57	1312	1192	1203	1192
query58	221	217	227	217
query59	3257	3000	3020	3000
query60	288	275	256	256
query61	127	108	112	108
query62	879	679	702	679
query63	230	187	195	187
query64	3958	680	624	624
query65	3337	3266	3292	3266
query66	854	292	324	292
query67	16702	15669	15624	15624
query68	4479	578	599	578
query69	453	275	265	265
query70	1163	1112	1091	1091
query71	417	247	254	247
query72	6085	3988	4042	3988
query73	760	351	358	351
query74	9856	9175	9026	9026
query75	3338	2612	2646	2612
query76	2758	983	1151	983
query77	386	283	279	279
query78	10525	9618	9606	9606
query79	2544	605	609	605
query80	1049	432	419	419
query81	544	223	223	223
query82	618	88	84	84
query83	251	143	155	143
query84	244	86	87	86
query85	1339	295	292	292
query86	446	284	306	284
query87	4383	4190	4254	4190
query88	4460	2369	2358	2358
query89	409	288	294	288
query90	1939	190	186	186
query91	178	152	151	151
query92	65	50	51	50
query93	2368	563	570	563
query94	858	295	296	295
query95	368	260	266	260
query96	618	279	284	279
query97	3265	3142	3179	3142
query98	218	201	194	194
query99	1560	1321	1308	1308
Total cold run time: 299456 ms
Total hot run time: 192306 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.92 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cdab3972b4613340afec1134af74fa3e8342de4e, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.52	0.51	0.51
query6	1.14	0.72	0.75
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.50
query10	0.55	0.55	0.55
query11	0.15	0.11	0.10
query12	0.14	0.10	0.10
query13	0.61	0.60	0.59
query14	0.78	0.81	0.79
query15	0.85	0.82	0.83
query16	0.40	0.37	0.38
query17	1.06	1.06	1.06
query18	0.26	0.23	0.23
query19	2.00	1.80	1.84
query20	0.02	0.01	0.01
query21	15.37	0.60	0.60
query22	2.26	1.70	1.74
query23	17.08	0.99	0.86
query24	3.38	0.61	1.27
query25	0.20	0.13	0.06
query26	0.41	0.13	0.14
query27	0.04	0.04	0.06
query28	10.38	0.52	0.48
query29	12.54	3.29	3.23
query30	0.24	0.06	0.06
query31	2.86	0.38	0.40
query32	3.23	0.46	0.46
query33	2.97	3.04	3.00
query34	17.05	4.59	4.57
query35	4.57	4.56	4.58
query36	0.68	0.47	0.47
query37	0.09	0.06	0.05
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.83 s
Total hot run time: 29.92 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 16, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit dc89fca into apache:branch-3.0 Sep 16, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants