Skip to content

[fix](cloud) Delete useless table lock in replayUpdateCloudReplica #55579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Sep 4, 2025
Merged

[fix](cloud) Delete useless table lock in replayUpdateCloudReplica #55579

dataroaring merged 2 commits into from
Sep 4, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Sep 2, 2025

What problem does this PR solve?

Here, replayUpdateCloudReplica adds a table write lock, which seems to protect nothing. Try deleting it.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

deardeng commented Sep 2, 2025

run buildall

dataroaring
dataroaring approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Sep 2, 2025

TPC-H: Total hot run time: 34457 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17baf58f6b9fb14ed00f6e910bd17192ecc5193c, data reload: false

------ Round 1 ----------------------------------
q1	17596	5230	5074	5074
q2	1988	343	214	214
q3	10273	1279	742	742
q4	10224	1035	543	543
q5	7536	2451	2660	2451
q6	184	167	141	141
q7	946	748	636	636
q8	9342	1319	1134	1134
q9	7092	5144	5191	5144
q10	6901	2406	1995	1995
q11	488	302	279	279
q12	365	365	241	241
q13	17788	3649	3080	3080
q14	241	251	229	229
q15	579	506	490	490
q16	425	423	375	375
q17	600	863	361	361
q18	7502	7278	7144	7144
q19	1223	956	568	568
q20	339	346	228	228
q21	3836	2565	2395	2395
q22	1036	1045	993	993
Total cold run time: 106504 ms
Total hot run time: 34457 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5476	5143	5179	5143
q2	251	331	228	228
q3	2173	2689	2330	2330
q4	1369	1832	1344	1344
q5	4235	4560	4597	4560
q6	215	174	133	133
q7	2086	2022	1805	1805
q8	2645	2568	2578	2568
q9	7486	7460	7333	7333
q10	3186	3302	2874	2874
q11	606	525	509	509
q12	674	781	648	648
q13	3542	3902	3593	3593
q14	296	306	287	287
q15	529	488	492	488
q16	466	510	458	458
q17	1229	1572	1446	1446
q18	7823	7772	7588	7588
q19	824	803	853	803
q20	2014	2083	1887	1887
q21	5021	4522	4258	4258
q22	1106	1059	1015	1015
Total cold run time: 53252 ms
Total hot run time: 51298 ms

@doris-robot
Copy link

doris-robot commented Sep 2, 2025

TPC-DS: Total hot run time: 186774 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17baf58f6b9fb14ed00f6e910bd17192ecc5193c, data reload: false

query1	1058	465	415	415
query2	6560	1762	1776	1762
query3	6754	232	227	227
query4	26131	23354	22972	22972
query5	4463	647	506	506
query6	352	244	250	244
query7	4653	527	294	294
query8	313	279	269	269
query9	8676	2907	2888	2888
query10	504	358	313	313
query11	16072	14927	14936	14927
query12	176	119	120	119
query13	1680	546	439	439
query14	9114	5802	5804	5802
query15	226	201	176	176
query16	7230	676	496	496
query17	1238	744	675	675
query18	2009	432	333	333
query19	206	203	176	176
query20	132	135	125	125
query21	222	134	117	117
query22	4170	4189	4030	4030
query23	33949	33175	32971	32971
query24	8209	2389	2400	2389
query25	595	533	456	456
query26	1249	285	164	164
query27	2743	514	361	361
query28	4371	2336	2281	2281
query29	834	622	517	517
query30	292	240	209	209
query31	908	794	742	742
query32	91	83	83	83
query33	573	403	373	373
query34	792	855	519	519
query35	840	824	773	773
query36	980	1049	934	934
query37	130	112	92	92
query38	4036	4030	4019	4019
query39	1522	1447	1427	1427
query40	223	139	133	133
query41	65	96	61	61
query42	135	118	119	118
query43	530	524	479	479
query44	1334	868	866	866
query45	183	176	172	172
query46	854	1020	668	668
query47	1785	1798	1742	1742
query48	391	435	328	328
query49	767	519	416	416
query50	659	691	424	424
query51	4061	4148	4125	4125
query52	125	119	108	108
query53	248	283	205	205
query54	616	609	547	547
query55	95	93	90	90
query56	356	367	347	347
query57	1200	1204	1148	1148
query58	313	314	299	299
query59	2755	2734	2600	2600
query60	391	375	360	360
query61	198	215	162	162
query62	805	715	672	672
query63	231	193	190	190
query64	4563	1150	845	845
query65	4293	4227	4235	4227
query66	1167	447	357	357
query67	15712	15181	15066	15066
query68	7876	913	587	587
query69	503	333	301	301
query70	1233	1150	1077	1077
query71	543	359	319	319
query72	5984	5213	4985	4985
query73	667	637	360	360
query74	9109	9159	8720	8720
query75	3172	3092	2632	2632
query76	3189	1148	747	747
query77	495	429	345	345
query78	9632	9638	8903	8903
query79	2501	846	609	609
query80	655	688	521	521
query81	504	268	227	227
query82	460	156	115	115
query83	258	265	244	244
query84	259	111	94	94
query85	891	482	431	431
query86	387	315	312	312
query87	4308	4356	4227	4227
query88	3747	2231	2217	2217
query89	397	341	307	307
query90	1902	230	224	224
query91	169	169	136	136
query92	94	77	74	74
query93	1927	1000	637	637
query94	752	396	344	344
query95	416	340	328	328
query96	495	602	289	289
query97	2650	2699	2570	2570
query98	255	222	217	217
query99	1349	1403	1305	1305
Total cold run time: 274887 ms
Total hot run time: 186774 ms

@doris-robot
Copy link

doris-robot commented Sep 2, 2025

ClickBench: Total hot run time: 32.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 17baf58f6b9fb14ed00f6e910bd17192ecc5193c, data reload: false

query1	0.06	0.05	0.06
query2	0.09	0.06	0.06
query3	0.25	0.08	0.09
query4	1.61	0.12	0.11
query5	0.46	0.44	0.41
query6	1.18	0.64	0.65
query7	0.03	0.02	0.02
query8	0.06	0.05	0.04
query9	0.62	0.52	0.54
query10	0.59	0.58	0.58
query11	0.17	0.11	0.11
query12	0.16	0.13	0.12
query13	0.63	0.64	0.61
query14	0.79	0.83	0.84
query15	0.87	0.85	0.85
query16	0.41	0.41	0.41
query17	1.07	1.09	1.05
query18	0.21	0.22	0.21
query19	1.98	1.90	1.86
query20	0.01	0.02	0.01
query21	15.40	0.97	0.60
query22	0.77	1.18	0.69
query23	14.94	1.40	0.58
query24	6.65	0.65	0.96
query25	0.51	0.13	0.16
query26	0.60	0.16	0.14
query27	0.07	0.06	0.05
query28	9.75	0.92	0.42
query29	12.55	3.86	3.23
query30	3.10	3.03	3.02
query31	2.83	0.60	0.39
query32	3.26	0.55	0.47
query33	3.03	3.16	3.20
query34	16.25	5.49	4.89
query35	4.97	4.92	4.92
query36	0.70	0.52	0.51
query37	0.11	0.08	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.03	0.04	0.03
query43	0.05	0.04	0.03
Total cold run time: 107.19 s
Total hot run time: 32.79 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 2, 2025

FE Regression Coverage Report

Increment line coverage 25.00% (1/4) 🎉
Increment coverage report
Complete coverage report

@dataroaring dataroaring merged commit 6ba9b4f into apache:master Sep 4, 2025
26 of 28 checks passed
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@deardeng @wenzhenghu
[fix](cloud) Delete useless table lock in replayUpdateCloudReplica (a…
8d1a1b6 
…pache#55579)

Here, replayUpdateCloudReplica adds a table write lock, which seems to
protect nothing. Try deleting it.
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Sep 12, 2025
@deardeng
[fix](cloud) Delete useless table lock in replayUpdateCloudReplica (a…
cdab397 
…pache#55579)

Here, replayUpdateCloudReplica adds a table write lock, which seems to
protect nothing. Try deleting it.
@deardeng deardeng mentioned this pull request Sep 12, 2025
Merged
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Sep 12, 2025
@deardeng
[fix](cloud) Delete useless table lock in replayUpdateCloudReplica (a…
c034ff2 
…pache#55579)

Here, replayUpdateCloudReplica adds a table write lock, which seems to
protect nothing. Try deleting it.
@deardeng deardeng mentioned this pull request Sep 12, 2025
Merged
dataroaring pushed a commit that referenced this pull request Sep 16, 2025
@deardeng
branch-3.0: [fix](cloud) Delete useless table lock in replayUpdateClo…
dc89fca 
…udReplica #55579 (#55954)

cherry pick from #55579
morrySnow pushed a commit that referenced this pull request Sep 19, 2025
@deardeng
branch-3.1: [fix](cloud) Delete useless table lock in replayUpdateClo…
6e5ed9f 
…udReplica #55579 (#55955)

cherry pick from #55579
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.9-merged dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deardeng @hello-stephen @doris-robot @gavinchou @dataroaring @morrySnow