Skip to content

Conversation

@deardeng
Copy link
Contributor

cherry pick from #55579

…pache#55579)

Here, replayUpdateCloudReplica adds a table write lock, which seems to
protect nothing. Try deleting it.
@deardeng deardeng requested a review from morrySnow as a code owner September 12, 2025 07:22
@deardeng
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Sep 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 32376 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c034ff24fd81a64d8084efc4c0c342c3cca727b8, data reload: false

------ Round 1 ----------------------------------
q1	17606	5536	5310	5310
q2	2040	405	276	276
q3	11904	1229	742	742
q4	10328	863	453	453
q5	9488	2388	2129	2129
q6	182	164	132	132
q7	876	738	620	620
q8	9317	1435	1127	1127
q9	5151	4950	4861	4861
q10	6764	2249	1844	1844
q11	466	291	261	261
q12	341	353	214	214
q13	17771	3583	3011	3011
q14	226	231	217	217
q15	517	461	463	461
q16	415	422	369	369
q17	572	842	353	353
q18	6885	6346	6349	6346
q19	1201	948	534	534
q20	333	331	196	196
q21	2731	2135	1936	1936
q22	1042	1042	984	984
Total cold run time: 106156 ms
Total hot run time: 32376 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5470	5480	5455	5455
q2	232	330	230	230
q3	2254	2638	2379	2379
q4	1383	1772	1402	1402
q5	4437	4918	5002	4918
q6	172	158	136	136
q7	2039	2009	1804	1804
q8	2644	2891	2762	2762
q9	7345	7296	7341	7296
q10	3036	3343	2766	2766
q11	567	511	502	502
q12	633	761	594	594
q13	3396	3757	3129	3129
q14	272	294	263	263
q15	532	474	491	474
q16	440	489	433	433
q17	1230	1720	1268	1268
q18	7543	7417	7250	7250
q19	775	1073	1061	1061
q20	2032	2036	1888	1888
q21	5345	4778	4694	4694
q22	1065	1059	1031	1031
Total cold run time: 52842 ms
Total hot run time: 51735 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192139 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c034ff24fd81a64d8084efc4c0c342c3cca727b8, data reload: false

query1	950	391	379	379
query2	6234	1937	1844	1844
query3	8688	206	201	201
query4	33488	23549	23423	23423
query5	3686	609	450	450
query6	289	193	187	187
query7	4206	506	323	323
query8	318	256	259	256
query9	9606	2623	2601	2601
query10	459	328	257	257
query11	18134	15372	15292	15292
query12	163	107	110	107
query13	1559	557	413	413
query14	9372	6542	6689	6542
query15	223	192	181	181
query16	7977	623	515	515
query17	1570	778	601	601
query18	2108	444	354	354
query19	240	192	171	171
query20	126	122	118	118
query21	224	126	102	102
query22	4684	4781	4416	4416
query23	35045	33795	33924	33795
query24	8879	2686	2695	2686
query25	506	473	411	411
query26	944	287	172	172
query27	2613	489	365	365
query28	5798	2209	2172	2172
query29	723	594	437	437
query30	241	188	166	166
query31	1004	884	851	851
query32	88	55	54	54
query33	506	378	302	302
query34	717	891	540	540
query35	787	818	726	726
query36	1040	1057	965	965
query37	103	88	65	65
query38	3974	4105	3976	3976
query39	1541	1470	1490	1470
query40	217	118	107	107
query41	47	47	46	46
query42	120	110	108	108
query43	491	507	484	484
query44	1331	840	825	825
query45	194	175	170	170
query46	882	1072	676	676
query47	2012	1987	1984	1984
query48	408	416	346	346
query49	778	496	397	397
query50	662	697	453	453
query51	7367	7290	7292	7290
query52	101	105	94	94
query53	231	257	190	190
query54	534	544	503	503
query55	80	81	84	81
query56	272	275	271	271
query57	1281	1272	1223	1223
query58	251	210	218	210
query59	2992	3153	3000	3000
query60	294	272	278	272
query61	123	140	134	134
query62	781	748	691	691
query63	239	207	195	195
query64	4358	1096	731	731
query65	3367	3319	3296	3296
query66	976	425	338	338
query67	16232	15872	15782	15782
query68	5923	831	556	556
query69	495	321	281	281
query70	1236	1176	1104	1104
query71	382	296	271	271
query72	5815	3682	3895	3682
query73	628	735	347	347
query74	10237	9240	9206	9206
query75	3181	3192	2668	2668
query76	2973	1167	773	773
query77	543	374	272	272
query78	10364	10586	9656	9656
query79	2831	897	616	616
query80	708	532	433	433
query81	495	256	221	221
query82	387	116	88	88
query83	157	156	143	143
query84	232	105	79	79
query85	786	352	307	307
query86	395	317	301	301
query87	4283	4340	4246	4246
query88	5145	2429	2401	2401
query89	400	335	302	302
query90	1741	195	194	194
query91	137	144	113	113
query92	63	57	52	52
query93	2353	906	540	540
query94	694	417	300	300
query95	341	277	272	272
query96	493	611	286	286
query97	3159	3267	3155	3155
query98	240	212	198	198
query99	1571	1436	1293	1293
Total cold run time: 293822 ms
Total hot run time: 192139 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c034ff24fd81a64d8084efc4c0c342c3cca727b8, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.24	0.06	0.06
query4	1.61	0.12	0.11
query5	0.50	0.49	0.51
query6	1.14	0.74	0.73
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.59	0.51	0.50
query10	0.56	0.54	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.62	0.60	0.60
query14	0.77	0.80	0.79
query15	0.86	0.83	0.83
query16	0.38	0.39	0.40
query17	0.99	0.98	1.01
query18	0.25	0.21	0.22
query19	1.93	1.89	1.88
query20	0.02	0.02	0.01
query21	15.39	0.93	0.55
query22	0.74	0.77	0.59
query23	15.20	1.41	0.55
query24	3.11	1.20	1.44
query25	0.20	0.13	0.16
query26	0.29	0.14	0.13
query27	0.06	0.05	0.04
query28	14.17	1.02	0.43
query29	12.56	3.92	3.23
query30	0.24	0.10	0.06
query31	2.82	0.59	0.39
query32	3.24	0.55	0.46
query33	3.01	3.04	3.08
query34	16.31	5.18	4.60
query35	4.66	4.59	4.55
query36	0.64	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.07	0.02	0.03
query42	0.03	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.05 s
Total hot run time: 29.17 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit 6e5ed9f into apache:branch-3.1 Sep 19, 2025
23 checks passed
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants