Skip to content

branch-3.1: [fix](cloud) Delete useless table lock in replayUpdateCloudReplica #55579 #55955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Sep 19, 2025
Merged

branch-3.1: [fix](cloud) Delete useless table lock in replayUpdateCloudReplica #55579 #55955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,25 +1020,27 @@ public void replayUpdateCloudReplica(UpdateCloudReplicaInfo info) throws MetaNot
LOG.warn("replay update cloud replica, unknown table {}", info.toString());
return;
}
LOG.debug("replay update a cloud replica {}", info);

olapTable.writeLock();
try {
unprotectUpdateCloudReplica(olapTable, info);
} catch (Exception e) {
LOG.warn("unexpected exception", e);
} finally {
olapTable.writeUnlock();
}
}

private void unprotectUpdateCloudReplica(OlapTable olapTable, UpdateCloudReplicaInfo info) {
LOG.debug("replay update a cloud replica {}", info);
Partition partition = olapTable.getPartition(info.getPartitionId());
if (partition == null) {
LOG.warn("replay update cloud replica, unknown partition {}, may be dropped", info.toString());
return;
}

MaterializedIndex materializedIndex = partition.getIndex(info.getIndexId());
if (materializedIndex == null) {
LOG.warn("replay update cloud replica, unknown index {}, may be dropped", info.toString());
return;
}

try {
if (info.getTabletId() != -1) {
Expand Down