Skip to content

Conversation

@deardeng
Copy link
Contributor

cherry pick from #55054

Add db lock to protect rename db editlog, and when writing create table
editlog, check whether the db name has been modified. If the db name has
been modified, the table creation statement will report an error.
@deardeng
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Sep 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

dataroaring
dataroaring previously approved these changes Sep 15, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 15, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@deardeng
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 15, 2025
@deardeng
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39860 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a730b9ccd81ed0e013d6f8399228f28b718ecc92, data reload: false

------ Round 1 ----------------------------------
q1	17588	7244	6750	6750
q2	2032	212	173	173
q3	10622	1131	1175	1131
q4	10478	731	689	689
q5	7761	2845	2816	2816
q6	217	132	133	132
q7	985	629	631	629
q8	9359	1894	2022	1894
q9	6638	6342	6405	6342
q10	7040	2213	2267	2213
q11	472	258	267	258
q12	401	217	215	215
q13	17790	2979	2974	2974
q14	239	208	205	205
q15	510	460	453	453
q16	471	378	378	378
q17	966	612	552	552
q18	7154	6766	6608	6608
q19	1420	1072	1138	1072
q20	483	196	204	196
q21	4050	3197	3187	3187
q22	1099	998	993	993
Total cold run time: 107775 ms
Total hot run time: 39860 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6783	6652	6653	6652
q2	329	230	227	227
q3	2881	2906	2938	2906
q4	1993	1839	1816	1816
q5	5706	5708	5698	5698
q6	216	129	132	129
q7	2268	1772	1786	1772
q8	3367	3498	3546	3498
q9	8706	8881	8872	8872
q10	3557	3520	3503	3503
q11	594	491	485	485
q12	794	599	573	573
q13	7069	3200	3158	3158
q14	291	284	274	274
q15	521	474	478	474
q16	485	449	437	437
q17	1844	1599	1575	1575
q18	8179	7837	7934	7837
q19	1743	1620	1566	1566
q20	2093	1868	1867	1867
q21	5367	5129	5038	5038
q22	1154	1099	1048	1048
Total cold run time: 65940 ms
Total hot run time: 59405 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192347 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a730b9ccd81ed0e013d6f8399228f28b718ecc92, data reload: false

query1	932	394	372	372
query2	6350	1903	1936	1903
query3	8690	198	196	196
query4	33760	23622	23942	23622
query5	3843	465	442	442
query6	288	189	201	189
query7	4197	310	331	310
query8	292	238	222	222
query9	9522	2580	2578	2578
query10	492	261	263	261
query11	18581	15201	15309	15201
query12	170	104	100	100
query13	1554	437	433	433
query14	9457	7337	7399	7337
query15	251	170	178	170
query16	8020	504	517	504
query17	1599	602	591	591
query18	2179	328	333	328
query19	375	164	180	164
query20	120	113	123	113
query21	203	105	106	105
query22	4623	4495	4359	4359
query23	34808	34588	33554	33554
query24	10655	2896	2946	2896
query25	626	440	441	440
query26	771	177	175	175
query27	2157	374	368	368
query28	6415	2152	2155	2152
query29	799	475	460	460
query30	279	163	158	158
query31	1035	817	843	817
query32	105	62	60	60
query33	663	323	340	323
query34	914	519	528	519
query35	897	727	741	727
query36	1126	967	951	951
query37	122	71	72	71
query38	4062	3986	3966	3966
query39	1509	1474	1489	1474
query40	204	112	106	106
query41	57	53	50	50
query42	115	105	111	105
query43	545	497	486	486
query44	1165	818	818	818
query45	185	169	168	168
query46	1164	739	734	734
query47	2063	1924	1913	1913
query48	475	389	385	385
query49	994	412	398	398
query50	814	432	427	427
query51	7442	7154	7216	7154
query52	105	95	88	88
query53	260	186	180	180
query54	1453	473	457	457
query55	83	79	78	78
query56	265	262	257	257
query57	1330	1182	1188	1182
query58	218	211	215	211
query59	3279	3145	3114	3114
query60	297	267	279	267
query61	114	126	112	112
query62	840	683	682	682
query63	233	192	196	192
query64	4029	696	654	654
query65	3346	3307	3331	3307
query66	800	296	309	296
query67	16278	15579	15704	15579
query68	4408	580	574	574
query69	443	290	267	267
query70	1154	1084	1098	1084
query71	346	257	281	257
query72	6289	4050	3997	3997
query73	754	343	356	343
query74	10388	8995	8855	8855
query75	3377	2655	2689	2655
query76	2817	1176	1089	1089
query77	402	285	276	276
query78	10509	9643	9482	9482
query79	2469	610	621	610
query80	1152	420	431	420
query81	561	219	215	215
query82	573	89	89	89
query83	237	144	139	139
query84	236	77	83	77
query85	1700	305	300	300
query86	481	259	299	259
query87	4372	4255	4258	4255
query88	4226	2383	2458	2383
query89	414	298	285	285
query90	1950	185	189	185
query91	187	154	169	154
query92	63	51	51	51
query93	2436	547	557	547
query94	794	295	286	286
query95	368	260	258	258
query96	614	276	282	276
query97	3274	3189	3211	3189
query98	221	204	194	194
query99	1522	1285	1331	1285
Total cold run time: 299331 ms
Total hot run time: 192347 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a730b9ccd81ed0e013d6f8399228f28b718ecc92, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.51	0.52	0.50
query6	1.12	0.73	0.73
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.51
query10	0.55	0.56	0.56
query11	0.14	0.10	0.11
query12	0.14	0.10	0.10
query13	0.61	0.60	0.59
query14	0.79	0.80	0.79
query15	0.84	0.83	0.82
query16	0.41	0.40	0.38
query17	1.00	1.01	1.09
query18	0.24	0.23	0.23
query19	1.95	1.86	1.86
query20	0.01	0.01	0.02
query21	15.40	0.59	0.56
query22	2.31	1.89	1.56
query23	16.77	0.90	0.85
query24	3.53	1.23	2.42
query25	0.19	0.19	0.06
query26	0.60	0.14	0.12
query27	0.03	0.04	0.04
query28	8.51	0.53	0.45
query29	12.55	3.27	3.21
query30	0.25	0.07	0.07
query31	2.84	0.38	0.37
query32	3.25	0.46	0.45
query33	2.96	3.06	3.02
query34	17.02	4.58	4.58
query35	4.60	4.58	4.59
query36	0.64	0.48	0.48
query37	0.09	0.05	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 102.85 s
Total hot run time: 30.38 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 36.36% (12/33) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 0c441df into apache:branch-3.0 Sep 16, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants