-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](database) Fix rename db and create table race #55054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
c4d3eaa to
379816c
Compare
|
run buildall |
TPC-H: Total hot run time: 33907 ms |
TPC-DS: Total hot run time: 184134 ms |
ClickBench: Total hot run time: 31.97 s |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 33635 ms |
FE UT Coverage ReportIncrement line coverage |
TPC-DS: Total hot run time: 184835 ms |
ClickBench: Total hot run time: 32.42 s |
3c5eca4 to
3aba765
Compare
|
run buildall |
3aba765 to
077c2cc
Compare
TPC-DS: Total hot run time: 185066 ms |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FE UT Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 32.56 s |
yujun777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add db lock to protect rename db editlog, and when writing create table editlog, check whether the db name has been modified. If the db name has been modified, the table creation statement will report an error.
Add db lock to protect rename db editlog, and when writing create table editlog, check whether the db name has been modified. If the db name has been modified, the table creation statement will report an error.
Add db lock to protect rename db editlog, and when writing create table editlog, check whether the db name has been modified. If the db name has been modified, the table creation statement will report an error.
Add db lock to protect rename db editlog, and when writing create table editlog, check whether the db name has been modified. If the db name has been modified, the table creation statement will report an error.
Add db lock to protect rename db editlog, and when writing create table editlog, check whether the db name has been modified. If the db name has been modified, the table creation statement will report an error.
…pache#4981) pick from apache#55054 Add db lock to protect rename db editlog, and when writing create table editlog, check whether the db name has been modified. If the db name has been modified, the table creation statement will report an error. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
What problem does this PR solve?
Add db lock to protect rename db editlog, and when writing create table editlog, check whether the db name has been modified. If the db name has been modified, the table creation statement will report an error.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)